Patchwork [2/2] irda: use GFP_KERNEL in irda_connect_response()

login
register
mail settings
Submitter Mathias Krause
Date April 5, 2013, 8:41 p.m.
Message ID <1365194488-23462-3-git-send-email-minipli@googlemail.com>
Download mbox | patch
Permalink /patch/234281/
State Accepted
Delegated to: David Miller
Headers show

Comments

Mathias Krause - April 5, 2013, 8:41 p.m.
The only call site of irda_connect_response() is irda_accept() -- a
function called from user context only. Therefore it has no need for
GFP_ATOMIC.

Signed-off-by: Mathias Krause <minipli@googlemail.com>
---
 net/irda/af_irda.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Patch

diff --git a/net/irda/af_irda.c b/net/irda/af_irda.c
index 2846cf5..a7f6ef1 100644
--- a/net/irda/af_irda.c
+++ b/net/irda/af_irda.c
@@ -305,8 +305,7 @@  static void irda_connect_response(struct irda_sock *self)
 
 	IRDA_DEBUG(2, "%s()\n", __func__);
 
-	skb = alloc_skb(TTP_MAX_HEADER + TTP_SAR_HEADER,
-			GFP_ATOMIC);
+	skb = alloc_skb(TTP_MAX_HEADER + TTP_SAR_HEADER, GFP_KERNEL);
 	if (skb == NULL) {
 		IRDA_DEBUG(0, "%s() Unable to allocate sk_buff!\n",
 			   __func__);