Patchwork [PULL,v2,01/13] tcg-s390: Fix movi

login
register
mail settings
Submitter Richard Henderson
Date April 5, 2013, 6:47 p.m.
Message ID <1365187661-17023-2-git-send-email-rth@twiddle.net>
Download mbox | patch
Permalink /patch/234247/
State New
Headers show

Comments

Richard Henderson - April 5, 2013, 6:47 p.m.
The code to load the high 64 bits assumed that the insn used to
load the low 64 bits zero-extended.  Enforce that.
---
 tcg/s390/tcg-target.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch

diff --git a/tcg/s390/tcg-target.c b/tcg/s390/tcg-target.c
index e12a152..0132010 100644
--- a/tcg/s390/tcg-target.c
+++ b/tcg/s390/tcg-target.c
@@ -770,7 +770,7 @@  static void tcg_out_movi(TCGContext *s, TCGType type,
     /* If we get here, both the high and low parts have non-zero bits.  */
 
     /* Recurse to load the lower 32-bits.  */
-    tcg_out_movi(s, TCG_TYPE_I32, ret, sval);
+    tcg_out_movi(s, TCG_TYPE_I64, ret, uval & 0xffffffff);
 
     /* Insert data into the high 32-bits.  */
     uval = uval >> 31 >> 1;