Patchwork [1/1,libata] SCSI: really use SATL version in VPD

login
register
mail settings
Submitter Baruch Even
Date April 5, 2013, 2:50 p.m.
Message ID <1365173425-16599-1-git-send-email-baruch@ev-en.org>
Download mbox | patch
Permalink /patch/234167/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Baruch Even - April 5, 2013, 2:50 p.m.
As per c78968bb by Jeff Garzik ([libata] SCSI: simulator version, not device version, belongs in VPD)
We need to provide the SATL driver version and not the disk firmware version
but the code overwrites the driver version with the disk version.

Signed-off-by: Baruch Even <baruch@ev-en.org>
---
 drivers/ata/libata-scsi.c |    1 -
 1 file changed, 1 deletion(-)
Sergei Shtylyov - April 5, 2013, 3:24 p.m.
Hello.

On 05-04-2013 18:50, Baruch Even wrote:

    When you post a new revision of the patch, this should be marked in the 
subject, like this: {PATCH v2].

> As per c78968bb by Jeff Garzik ([libata] SCSI: simulator version, not device version, belongs in VPD)

    Please wrap your lines at 80 characters max.

> We need to provide the SATL driver version and not the disk firmware version
> but the code overwrites the driver version with the disk version.

> Signed-off-by: Baruch Even <baruch@ev-en.org>

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
index 318b413..e61a054 100644
--- a/drivers/ata/libata-scsi.c
+++ b/drivers/ata/libata-scsi.c
@@ -2126,7 +2126,6 @@  static unsigned int ata_scsiop_inq_89(struct ata_scsi_args *args, u8 *rbuf)
 	memcpy(&rbuf[8], "linux   ", 8);
 	memcpy(&rbuf[16], "libata          ", 16);
 	memcpy(&rbuf[32], DRV_VERSION, 4);
-	ata_id_string(args->id, &rbuf[32], ATA_ID_FW_REV, 4);
 
 	/* we don't store the ATA device signature, so we fake it */