Patchwork [Ulogd2,2/3] Lower libnfnetlink requirement to 1.0.0

login
register
mail settings
Submitter Victor Julien
Date April 5, 2013, 2:33 p.m.
Message ID <1365172437-15042-3-git-send-email-victor@inliniac.net>
Download mbox | patch
Permalink /patch/234163/
State Not Applicable
Headers show

Comments

Victor Julien - April 5, 2013, 2:33 p.m.
Build and run tested against 1.0.0, worked fine for me.

---
 configure.ac |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Pablo Neira - April 5, 2013, 3:39 p.m.
On Fri, Apr 05, 2013 at 04:33:56PM +0200, Victor Julien wrote:
> Build and run tested against 1.0.0, worked fine for me.
> 
> ---
>  configure.ac |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure.ac b/configure.ac
> index a439bee..5755cf5 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -48,7 +48,7 @@ regular_CFLAGS="-Wall -Wextra -Wno-unused-parameter"
>  AC_SUBST([regular_CFLAGS])
>  
>  dnl Check for the right nfnetlink version
> -PKG_CHECK_MODULES([LIBNFNETLINK], [libnfnetlink >= 1.0.1])
> +PKG_CHECK_MODULES([LIBNFNETLINK], [libnfnetlink >= 1.0.0])

Same thing here. There was also a reason to bump the version
dependency.

There's a fix in libnfnetlink in the nlif interface.

commit 8b15e485c0d5f4a1e56b2148a34995ed1fa9e95b
Author: Pablo Neira Ayuso <pablo@netfilter.org>
Date:   Mon Aug 13 19:49:58 2012 +0200

    iftable: fix incomplete list of interfaces via nlif_query

In systems with lots of NICs, nlif_query may fail without that patch
in libnfnetlink.

Please, don't downgrade the dependencies.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Victor Julien - April 5, 2013, 4:08 p.m.
On 04/05/2013 05:39 PM, Pablo Neira Ayuso wrote:
> On Fri, Apr 05, 2013 at 04:33:56PM +0200, Victor Julien wrote:
>> Build and run tested against 1.0.0, worked fine for me.
>>
>> ---
>>  configure.ac |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/configure.ac b/configure.ac
>> index a439bee..5755cf5 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -48,7 +48,7 @@ regular_CFLAGS="-Wall -Wextra -Wno-unused-parameter"
>>  AC_SUBST([regular_CFLAGS])
>>  
>>  dnl Check for the right nfnetlink version
>> -PKG_CHECK_MODULES([LIBNFNETLINK], [libnfnetlink >= 1.0.1])
>> +PKG_CHECK_MODULES([LIBNFNETLINK], [libnfnetlink >= 1.0.0])
> 
> Same thing here. There was also a reason to bump the version
> dependency.
> 
> There's a fix in libnfnetlink in the nlif interface.
> 
> commit 8b15e485c0d5f4a1e56b2148a34995ed1fa9e95b
> Author: Pablo Neira Ayuso <pablo@netfilter.org>
> Date:   Mon Aug 13 19:49:58 2012 +0200
> 
>     iftable: fix incomplete list of interfaces via nlif_query
> 
> In systems with lots of NICs, nlif_query may fail without that patch
> in libnfnetlink.
> 
> Please, don't downgrade the dependencies.

Okay, got it. Would have been nice to be able to work with the versions
installed by recent distro's though.
Pablo Neira - April 5, 2013, 4:23 p.m.
On Fri, Apr 05, 2013 at 06:08:05PM +0200, Victor Julien wrote:
> On 04/05/2013 05:39 PM, Pablo Neira Ayuso wrote:
> > On Fri, Apr 05, 2013 at 04:33:56PM +0200, Victor Julien wrote:
> >> Build and run tested against 1.0.0, worked fine for me.
> >>
> >> ---
> >>  configure.ac |    2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/configure.ac b/configure.ac
> >> index a439bee..5755cf5 100644
> >> --- a/configure.ac
> >> +++ b/configure.ac
> >> @@ -48,7 +48,7 @@ regular_CFLAGS="-Wall -Wextra -Wno-unused-parameter"
> >>  AC_SUBST([regular_CFLAGS])
> >>  
> >>  dnl Check for the right nfnetlink version
> >> -PKG_CHECK_MODULES([LIBNFNETLINK], [libnfnetlink >= 1.0.1])
> >> +PKG_CHECK_MODULES([LIBNFNETLINK], [libnfnetlink >= 1.0.0])
> > 
> > Same thing here. There was also a reason to bump the version
> > dependency.
> > 
> > There's a fix in libnfnetlink in the nlif interface.
> > 
> > commit 8b15e485c0d5f4a1e56b2148a34995ed1fa9e95b
> > Author: Pablo Neira Ayuso <pablo@netfilter.org>
> > Date:   Mon Aug 13 19:49:58 2012 +0200
> > 
> >     iftable: fix incomplete list of interfaces via nlif_query
> > 
> > In systems with lots of NICs, nlif_query may fail without that patch
> > in libnfnetlink.
> > 
> > Please, don't downgrade the dependencies.
> 
> Okay, got it. Would have been nice to be able to work with the versions
> installed by recent distro's though.

Pull your vendor to upgrade, not me :-).
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/configure.ac b/configure.ac
index a439bee..5755cf5 100644
--- a/configure.ac
+++ b/configure.ac
@@ -48,7 +48,7 @@  regular_CFLAGS="-Wall -Wextra -Wno-unused-parameter"
 AC_SUBST([regular_CFLAGS])
 
 dnl Check for the right nfnetlink version
-PKG_CHECK_MODULES([LIBNFNETLINK], [libnfnetlink >= 1.0.1])
+PKG_CHECK_MODULES([LIBNFNETLINK], [libnfnetlink >= 1.0.0])
 AC_ARG_ENABLE(nflog,
        AS_HELP_STRING([--enable-nflog], [Enable nflog module [default=yes]]),,[enable_nflog=yes])
 AS_IF([test "x$enable_nflog" = "xyes"], [