Patchwork [Ulogd2,1/3] Remove configure check for libmnl, it is not used

login
register
mail settings
Submitter Victor Julien
Date April 5, 2013, 2:33 p.m.
Message ID <1365172437-15042-2-git-send-email-victor@inliniac.net>
Download mbox | patch
Permalink /patch/234162/
State RFC
Headers show

Comments

Victor Julien - April 5, 2013, 2:33 p.m.
If libmnl is missing configure fails. However, the lib is not used nor
linked to.

---
 configure.ac |    1 -
 1 file changed, 1 deletion(-)
Pablo Neira - April 5, 2013, 3:34 p.m.
On Fri, Apr 05, 2013 at 04:33:55PM +0200, Victor Julien wrote:
> If libmnl is missing configure fails. However, the lib is not used nor
> linked to.
> 
> ---
>  configure.ac |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/configure.ac b/configure.ac
> index c94704b..a439bee 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -49,7 +49,6 @@ AC_SUBST([regular_CFLAGS])
>  
>  dnl Check for the right nfnetlink version
>  PKG_CHECK_MODULES([LIBNFNETLINK], [libnfnetlink >= 1.0.1])
> -PKG_CHECK_MODULES([LIBMNL], [libmnl >= 1.0.3])

input/sum/ulogd_inpflow_NFACCT.c

needs this.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Victor Julien - April 5, 2013, 3:47 p.m.
On 04/05/2013 05:34 PM, Pablo Neira Ayuso wrote:
> On Fri, Apr 05, 2013 at 04:33:55PM +0200, Victor Julien wrote:
>> If libmnl is missing configure fails. However, the lib is not used nor
>> linked to.
>>
>> ---
>>  configure.ac |    1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/configure.ac b/configure.ac
>> index c94704b..a439bee 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -49,7 +49,6 @@ AC_SUBST([regular_CFLAGS])
>>  
>>  dnl Check for the right nfnetlink version
>>  PKG_CHECK_MODULES([LIBNFNETLINK], [libnfnetlink >= 1.0.1])
>> -PKG_CHECK_MODULES([LIBMNL], [libmnl >= 1.0.3])
> 
> input/sum/ulogd_inpflow_NFACCT.c
> 
> needs this.

Shouldn't it be a conditional check then? Only if nfacct is enabled?

I'm testing with only nflog support and it builds and runs fine with my
patch.
Pablo Neira - April 5, 2013, 4 p.m.
On Fri, Apr 05, 2013 at 05:47:13PM +0200, Victor Julien wrote:
> On 04/05/2013 05:34 PM, Pablo Neira Ayuso wrote:
> > On Fri, Apr 05, 2013 at 04:33:55PM +0200, Victor Julien wrote:
> >> If libmnl is missing configure fails. However, the lib is not used nor
> >> linked to.
> >>
> >> ---
> >>  configure.ac |    1 -
> >>  1 file changed, 1 deletion(-)
> >>
> >> diff --git a/configure.ac b/configure.ac
> >> index c94704b..a439bee 100644
> >> --- a/configure.ac
> >> +++ b/configure.ac
> >> @@ -49,7 +49,6 @@ AC_SUBST([regular_CFLAGS])
> >>  
> >>  dnl Check for the right nfnetlink version
> >>  PKG_CHECK_MODULES([LIBNFNETLINK], [libnfnetlink >= 1.0.1])
> >> -PKG_CHECK_MODULES([LIBMNL], [libmnl >= 1.0.3])
> > 
> > input/sum/ulogd_inpflow_NFACCT.c
> > 
> > needs this.
> 
> Shouldn't it be a conditional check then? Only if nfacct is enabled?

That's fine with me.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/configure.ac b/configure.ac
index c94704b..a439bee 100644
--- a/configure.ac
+++ b/configure.ac
@@ -49,7 +49,6 @@  AC_SUBST([regular_CFLAGS])
 
 dnl Check for the right nfnetlink version
 PKG_CHECK_MODULES([LIBNFNETLINK], [libnfnetlink >= 1.0.1])
-PKG_CHECK_MODULES([LIBMNL], [libmnl >= 1.0.3])
 AC_ARG_ENABLE(nflog,
        AS_HELP_STRING([--enable-nflog], [Enable nflog module [default=yes]]),,[enable_nflog=yes])
 AS_IF([test "x$enable_nflog" = "xyes"], [