Message ID | CAPgLHd-sTt5eKoiLb13dWHipT6Q46qCbG=b9mCYNq=Q7YLmGVA@mail.gmail.com |
---|---|
State | Not Applicable, archived |
Headers | show |
On Fri, Apr 05, 2013 at 09:45:36PM +0800, Wei Yongjun wrote: > From: Wei Yongjun <yongjun_wei@trendmicro.com.cn> > > Neither tegra20_spi_cdata nor tegra30_spi_cdata are used outside this > file so they can, and should, be static. > > Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> > --- > drivers/spi/spi-tegra20-slink.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/spi/spi-tegra20-slink.c b/drivers/spi/spi-tegra20-slink.c > index 4e58b53..b224a82 100644 > --- a/drivers/spi/spi-tegra20-slink.c > +++ b/drivers/spi/spi-tegra20-slink.c > @@ -1087,11 +1087,11 @@ static struct tegra_spi_platform_data *tegra_slink_parse_dt( > return pdata; > } > > -const struct tegra_slink_chip_data tegra30_spi_cdata = { > +static const struct tegra_slink_chip_data tegra30_spi_cdata = { > .cs_hold_time = true, > }; > > -const struct tegra_slink_chip_data tegra20_spi_cdata = { > +static const struct tegra_slink_chip_data tegra20_spi_cdata = { > .cs_hold_time = false, > }; > Reviewed-by: Thierry Reding <thierry.reding@avionic-design.de>
On Fri, Apr 05, 2013 at 09:45:36PM +0800, Wei Yongjun wrote: > From: Wei Yongjun <yongjun_wei@trendmicro.com.cn> > > Neither tegra20_spi_cdata nor tegra30_spi_cdata are used outside this > file so they can, and should, be static. Applied, thanks.
diff --git a/drivers/spi/spi-tegra20-slink.c b/drivers/spi/spi-tegra20-slink.c index 4e58b53..b224a82 100644 --- a/drivers/spi/spi-tegra20-slink.c +++ b/drivers/spi/spi-tegra20-slink.c @@ -1087,11 +1087,11 @@ static struct tegra_spi_platform_data *tegra_slink_parse_dt( return pdata; } -const struct tegra_slink_chip_data tegra30_spi_cdata = { +static const struct tegra_slink_chip_data tegra30_spi_cdata = { .cs_hold_time = true, }; -const struct tegra_slink_chip_data tegra20_spi_cdata = { +static const struct tegra_slink_chip_data tegra20_spi_cdata = { .cs_hold_time = false, };