Patchwork aircrack-ng: needs toolchain with threads support

login
register
mail settings
Submitter gilles.talis@gmail.com
Date April 4, 2013, 11:09 p.m.
Message ID <1365116959-25148-1-git-send-email-gilles.talis@gmail.com>
Download mbox | patch
Permalink /patch/233985/
State Accepted
Headers show

Comments

gilles.talis@gmail.com - April 4, 2013, 11:09 p.m.
Fixes:
http://autobuild.buildroot.org/results/418c9385a9a5a5087a6790001560056d32cd9708

Signed-off-by: Gilles Talis <gilles.talis@gmail.com>
---
 package/aircrack-ng/Config.in |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
Gustavo Zacarias - April 5, 2013, 10:47 a.m.
On 04/04/2013 08:09 PM, Gilles Talis wrote:

> Fixes:
> http://autobuild.buildroot.org/results/418c9385a9a5a5087a6790001560056d32cd9708
> 
> Signed-off-by: Gilles Talis <gilles.talis@gmail.com>

Acked-by: Gustavo Zacarias <gustavo@zacarias.com.ar>

> +	depends on BR2_TOOLCHAIN_HAS_THREADS # iw

However it's not because of iw, it's because of aircrack itself
(aircrack is failing to compile) :)
Regards.
gilles.talis@gmail.com - April 5, 2013, 3:49 p.m.
On Apr 5, 2013 3:47 AM, "Gustavo Zacarias" <gustavo@zacarias.com.ar> wrote:

> On 04/04/2013 08:09 PM, Gilles Talis wrote:
>
> > Fixes:
> >
> http://autobuild.buildroot.org/results/418c9385a9a5a5087a6790001560056d32cd9708
> >
> > Signed-off-by: Gilles Talis <gilles.talis@gmail.com>
>
> Acked-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
>
> > +     depends on BR2_TOOLCHAIN_HAS_THREADS # iw
>
> However it's not because of iw, it's because of aircrack itself
> (aircrack is failing to compile) :)
>

Fully right :-).  Meant to show to iw ALSO had that dependency. But I
realize that my comment does not reflect that at all :-)
Thanks for the ack.
Regards
Gilles.
Peter Korsgaard - April 11, 2013, 2 p.m.
>>>>> "Gilles" == Gilles Talis <gilles.talis@gmail.com> writes:

 Gilles> Fixes:
 Gilles> http://autobuild.buildroot.org/results/418c9385a9a5a5087a6790001560056d32cd9708

Committed (with iw comment dropped), thanks.

Patch

diff --git a/package/aircrack-ng/Config.in b/package/aircrack-ng/Config.in
index 319b7c4..daea48f 100644
--- a/package/aircrack-ng/Config.in
+++ b/package/aircrack-ng/Config.in
@@ -4,11 +4,12 @@  config BR2_PACKAGE_AIRCRACK_NG
 	depends on BR2_USE_MMU # uses fork()
 	select BR2_PACKAGE_OPENSSL
 	select BR2_PACKAGE_IW # runtime
+	depends on BR2_TOOLCHAIN_HAS_THREADS # iw
 	help
 	  A set of tools for auditing wireless networks
 
 	  http://www.aircrack-ng.org/
 
-comment "aircrack-ng needs a toolchain with largefile support"
-	depends on !BR2_LARGEFILE
+comment "aircrack-ng needs a toolchain with largefile and threads support"
+	depends on !BR2_LARGEFILE || !BR2_TOOLCHAIN_HAS_THREADS