From patchwork Thu Apr 4 18:17:58 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jakub Jelinek X-Patchwork-Id: 233893 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "localhost", Issuer "www.qmailtoaster.com" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 67B5D2C007E for ; Fri, 5 Apr 2013 05:18:17 +1100 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:reply-to:mime-version :content-type; q=dns; s=default; b=TupRRtScSJtudOTYh7NGi0EBAtbtI BzDglXO1mu2vjdsveMORpcTYyUP+yfQU2hH6dkUnLoARDIdTM3YfZ8cf1GlB/pLs 1fq2t4N5JEu9ZFBVUFrqF3nZUY+YOG9Jk1tuyN+nflrvjv/sT3iX3vXtsM2dF9vo S+526WF0G0M3as= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:reply-to:mime-version :content-type; s=default; bh=u3eN9A/oHIOUATnIn5UeZPvh5q0=; b=xz5 XAKFYrr25wlT+fl7Tczot6ngrQ5fUcl1GJzR2e2Cowqa+a+SU6+utMnAsGDjm563 QvMHr6lVU4eM0jygZ/LumrV/lgljNIErRzvpX+yE6GgdVDailTi3gYacDkkMawcb YRVkq5dqbCGXYQhdteAfKDO9vJuEl8HVD2CDSLF4= Received: (qmail 1208 invoked by alias); 4 Apr 2013 18:18:08 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 1192 invoked by uid 89); 4 Apr 2013 18:18:08 -0000 X-Spam-SWARE-Status: No, score=-7.6 required=5.0 tests=AWL, BAYES_00, KHOP_RCVD_UNTRUST, RCVD_IN_DNSWL_HI, RCVD_IN_HOSTKARMA_W, RP_MATCHES_RCVD, SPF_HELO_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 04 Apr 2013 18:18:05 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r34II4ID026014 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 4 Apr 2013 14:18:04 -0400 Received: from zalov.cz (vpn1-5-203.ams2.redhat.com [10.36.5.203]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r34II2lU016070 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 4 Apr 2013 14:18:03 -0400 Received: from zalov.cz (localhost [127.0.0.1]) by zalov.cz (8.14.5/8.14.5) with ESMTP id r34II0ie017790; Thu, 4 Apr 2013 20:18:01 +0200 Received: (from jakub@localhost) by zalov.cz (8.14.5/8.14.5/Submit) id r34IHxoF017789; Thu, 4 Apr 2013 20:17:59 +0200 Date: Thu, 4 Apr 2013 20:17:58 +0200 From: Jakub Jelinek To: Richard Biener Cc: gcc-patches@gcc.gnu.org Subject: [PATCH] Loop distribution improvements Message-ID: <20130404181758.GV4201@tucnak.redhat.com> Reply-To: Jakub Jelinek MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Hi! As discussed on IRC, this patch allows as to recognize more patterns as memset, see the testcase for what it can do. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2013-04-04 Jakub Jelinek * tree-loop-distribution.c (generate_memset_builtin): Only handle integer_all_onesp as -1 val if TYPE_PRECISION is equal to mode bitsize. Use native_encode_expr if possible to compute val. (classify_partition): Verify CONSTRUCTOR doesn't have any elts. For QImode integers don't require anything about precision. Use native_encode_expr to find out if the constant doesn't have repeated bytes in it. * gcc.dg/pr56837.c: New test. Jakub --- gcc/tree-loop-distribution.c.jj 2013-04-04 15:03:28.000000000 +0200 +++ gcc/tree-loop-distribution.c 2013-04-04 16:52:40.139875453 +0200 @@ -331,11 +331,21 @@ generate_memset_builtin (struct loop *lo || real_zerop (val) || TREE_CODE (val) == CONSTRUCTOR) val = integer_zero_node; - else if (integer_all_onesp (val)) + else if (integer_all_onesp (val) + && (TYPE_PRECISION (TREE_TYPE (val)) + == GET_MODE_BITSIZE (TYPE_MODE (TREE_TYPE (val))))) val = build_int_cst (integer_type_node, -1); else { - if (TREE_CODE (val) == INTEGER_CST) + /* Handle constants like 0x15151515 and similarly + floating point constants etc. where all bytes are the same. */ + unsigned char buf[64]; + int len; + if (CHAR_BIT == 8 + && BITS_PER_UNIT == 8 + && (len = native_encode_expr (val, buf, sizeof (buf))) != 0) + val = build_int_cst (integer_type_node, buf[0]); + else if (TREE_CODE (val) == INTEGER_CST) val = fold_convert (integer_type_node, val); else if (!useless_type_conversion_p (integer_type_node, TREE_TYPE (val))) { @@ -944,16 +954,28 @@ classify_partition (loop_p loop, struct if (!(integer_zerop (rhs) || real_zerop (rhs) || (TREE_CODE (rhs) == CONSTRUCTOR - && !TREE_CLOBBER_P (rhs)) - || ((integer_all_onesp (rhs) - || (INTEGRAL_TYPE_P (TREE_TYPE (rhs)) - && (TYPE_MODE (TREE_TYPE (rhs)) - == TYPE_MODE (unsigned_char_type_node)))) - /* For stores of a non-zero value require that the precision - of the value matches its actual size. */ + && !TREE_CLOBBER_P (rhs) + && CONSTRUCTOR_NELTS (rhs) == 0) + || (integer_all_onesp (rhs) && (TYPE_PRECISION (TREE_TYPE (rhs)) - == GET_MODE_BITSIZE (TYPE_MODE (TREE_TYPE (rhs))))))) - return; + == GET_MODE_BITSIZE (TYPE_MODE (TREE_TYPE (rhs))))) + || (INTEGRAL_TYPE_P (TREE_TYPE (rhs)) + && (TYPE_MODE (TREE_TYPE (rhs)) + == TYPE_MODE (unsigned_char_type_node))))) + { + /* Handle constants like 0x15151515 and similarly + floating point constants etc. where all bytes are the same. */ + unsigned char buf[64]; + int i, len; + if (CHAR_BIT != 8 || BITS_PER_UNIT != 8) + return; + len = native_encode_expr (rhs, buf, sizeof (buf)); + if (len == 0) + return; + for (i = 1; i < len; i++) + if (buf[i] != buf[0]) + return; + } if (TREE_CODE (rhs) == SSA_NAME && !SSA_NAME_IS_DEFAULT_DEF (rhs) && flow_bb_inside_loop_p (loop, gimple_bb (SSA_NAME_DEF_STMT (rhs)))) --- gcc/testsuite/gcc.dg/pr56837.c.jj 2013-04-04 17:37:58.458675152 +0200 +++ gcc/testsuite/gcc.dg/pr56837.c 2013-04-04 17:36:40.000000000 +0200 @@ -0,0 +1,67 @@ +/* Limit this test to selected targets with IEEE double, 8-byte long long, + supported 4x int vectors, 4-byte int. */ +/* { dg-do compile { target { i?86-*-* x86_64-*-* powerpc*-*-* } } } */ +/* { dg-options "-O3 -fdump-tree-optimized" } */ +/* { dg-additional-options "-msse2" { target ia32 } } */ +/* { dg-additional-options "-mvsx -maltivec" { target powerpc*-*-* } } */ + +typedef int V __attribute__((__vector_size__ (16))); +#define N 1024 +double d[N]; +long long int l[N]; +_Bool b[N]; +_Complex double c[N]; +V v[N]; + +void +fd (void) +{ + int i; + for (i = 0; i < N; i++) + d[i] = 747708026454360457216.0; +} + +void +fl (void) +{ + int i; + for (i = 0; i < N; i++) + l[i] = 0x7c7c7c7c7c7c7c7cULL; +} + +void +fb (void) +{ + int i; + for (i = 0; i < N; i++) + b[i] = 1; +} + +void +fc (void) +{ + int i; + for (i = 0; i < N; i++) + c[i] = 747708026454360457216.0 + 747708026454360457216.0i; +} + +void +fv (void) +{ + int i; + for (i = 0; i < N; i++) + v[i] = (V) { 0x12121212, 0x12121212, 0x12121212, 0x12121212 }; +} + +/* Look for + __builtin_memset (&d, 68, 8192); + __builtin_memset (&l, 124, 8192); + __builtin_memset (&b, 1, 1024); + __builtin_memset (&c, 68, 16384); + __builtin_memset (&v, 18, 16384); */ +/* { dg-final { scan-tree-dump-times "memset ..d, 68, 8192.;" 1 "optimized" } } */ +/* { dg-final { scan-tree-dump-times "memset ..l, 124, 8192.;" 1 "optimized" } } */ +/* { dg-final { scan-tree-dump-times "memset ..b, 1, 1024.;" 1 "optimized" } } */ +/* { dg-final { scan-tree-dump-times "memset ..c, 68, 16384.;" 1 "optimized" } } */ +/* { dg-final { scan-tree-dump-times "memset ..v, 18, 16384.;" 1 "optimized" } } */ +/* { dg-final { cleanup-tree-dump "optimized" } } */