Patchwork [U-Boot,v2] OMAP4: Add ID for OMAP4470_ES1_0

login
register
mail settings
Submitter Lubomir Popov
Date April 4, 2013, 3:57 p.m.
Message ID <515DA2FF.6090603@mm-sol.com>
Download mbox | patch
Permalink /patch/233871/
State New
Delegated to: Tom Rini
Headers show

Comments

Lubomir Popov - April 4, 2013, 3:57 p.m.
V2 fixes garbled subject.

Signed-off-by: Lubomir Popov <lpopov@mm-sol.com>

---
 arch/arm/include/asm/omap_common.h   |    1 +
 1 file changed, 1 insertion(+)
Nishanth Menon - April 4, 2013, 4 p.m.
On 18:57-20130404, Lubomir Popov wrote:
> V2 fixes garbled subject.
move this to diffstat section - here and in the rest of the patches.
> 
> Signed-off-by: Lubomir Popov <lpopov@mm-sol.com>
> 
> ---
>  arch/arm/include/asm/omap_common.h   |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/include/asm/omap_common.h b/arch/arm/include/asm/omap_common.h
> index 091ddb5..f042c10 100644
> --- a/arch/arm/include/asm/omap_common.h
> +++ b/arch/arm/include/asm/omap_common.h
> @@ -573,6 +573,7 @@ static inline u32 omap_revision(void)
>  #define OMAP4430_ES2_3	0x44300230
>  #define OMAP4460_ES1_0	0x44600100
>  #define OMAP4460_ES1_1	0x44600110
> +#define OMAP4470_ES1_0	0x44700100
and used where? we do not support 4470 in u-boot today, and to my
knowledge, there is no plans to do it either.
>  
>  /* omap5 */
>  #define OMAP5430_SILICON_ID_INVALID	0
> -- 
> 1.7.9.5
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
Lubomir Popov - April 4, 2013, 4:14 p.m.
Hello,

On 04/04/13 19:00, Nishanth Menon wrote:
> On 18:57-20130404, Lubomir Popov wrote:
>> V2 fixes garbled subject.
> move this to diffstat section - here and in the rest of the patches.
>>
>> Signed-off-by: Lubomir Popov <lpopov@mm-sol.com>
>>
>> ---
>>  arch/arm/include/asm/omap_common.h   |    1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/include/asm/omap_common.h b/arch/arm/include/asm/omap_common.h
>> index 091ddb5..f042c10 100644
>> --- a/arch/arm/include/asm/omap_common.h
>> +++ b/arch/arm/include/asm/omap_common.h
>> @@ -573,6 +573,7 @@ static inline u32 omap_revision(void)
>>  #define OMAP4430_ES2_3	0x44300230
>>  #define OMAP4460_ES1_0	0x44600100
>>  #define OMAP4460_ES1_1	0x44600110
>> +#define OMAP4470_ES1_0	0x44700100
> and used where? we do not support 4470 in u-boot today, and to my
> knowledge, there is no plans to do it either.

Used on a custom MMS board that I'm working upon; it is up and running U-Boot
with a TI 750-2173 processor card, including USB EHCI (including HSIC devices).
Please see patch 233501 on my (very initial) 4470/6032 support.

If interested, I can post the board files as well.

>>  
>>  /* omap5 */
>>  #define OMAP5430_SILICON_ID_INVALID	0
>> -- 
>> 1.7.9.5
>> _______________________________________________
>> U-Boot mailing list
>> U-Boot@lists.denx.de
>> http://lists.denx.de/mailman/listinfo/u-boot
> 

Regards,
Lubomir
Nishanth Menon - April 4, 2013, 4:44 p.m.
On 19:14-20130404, Lubomir Popov wrote:
> Hello,
> 
> On 04/04/13 19:00, Nishanth Menon wrote:
> > On 18:57-20130404, Lubomir Popov wrote:
> >> V2 fixes garbled subject.
> > move this to diffstat section - here and in the rest of the patches.
> >>
> >> Signed-off-by: Lubomir Popov <lpopov@mm-sol.com>
> >>
> >> ---
> >>  arch/arm/include/asm/omap_common.h   |    1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >> diff --git a/arch/arm/include/asm/omap_common.h b/arch/arm/include/asm/omap_common.h
> >> index 091ddb5..f042c10 100644
> >> --- a/arch/arm/include/asm/omap_common.h
> >> +++ b/arch/arm/include/asm/omap_common.h
> >> @@ -573,6 +573,7 @@ static inline u32 omap_revision(void)
> >>  #define OMAP4430_ES2_3	0x44300230
> >>  #define OMAP4460_ES1_0	0x44600100
> >>  #define OMAP4460_ES1_1	0x44600110
> >> +#define OMAP4470_ES1_0	0x44700100
> > and used where? we do not support 4470 in u-boot today, and to my
> > knowledge, there is no plans to do it either.
> 
> Used on a custom MMS board that I'm working upon; it is up and running U-Boot
> with a TI 750-2173 processor card, including USB EHCI (including HSIC devices).
> Please see patch 233501 on my (very initial) 4470/6032 support.
> 
> If interested, I can post the board files as well.
there is no u-boot support for 4470
$ git branch -v
  * master         c814263 Prepare v2013.04-rc2
$ git grep 4470 .|grep OMAP
$

What is the point in having board files for an SoC that is not supported
in upstream?? My suggestion is that you either provide and maintain support for
the SoC upstream (considering that inside TI, there seems be to no known
motivation to do so) and introduce your board file, OR maintain this patch in
the u-boot fork for the vendor board.
Tom Rini - April 4, 2013, 4:54 p.m.
On Thu, Apr 04, 2013 at 11:44:14AM -0500, Nishanth Menon wrote:
> On 19:14-20130404, Lubomir Popov wrote:
> > Hello,
> > 
> > On 04/04/13 19:00, Nishanth Menon wrote:
> > > On 18:57-20130404, Lubomir Popov wrote:
> > >> V2 fixes garbled subject.
> > > move this to diffstat section - here and in the rest of the patches.
> > >>
> > >> Signed-off-by: Lubomir Popov <lpopov@mm-sol.com>
> > >>
> > >> ---
> > >>  arch/arm/include/asm/omap_common.h   |    1 +
> > >>  1 file changed, 1 insertion(+)
> > >>
> > >> diff --git a/arch/arm/include/asm/omap_common.h b/arch/arm/include/asm/omap_common.h
> > >> index 091ddb5..f042c10 100644
> > >> --- a/arch/arm/include/asm/omap_common.h
> > >> +++ b/arch/arm/include/asm/omap_common.h
> > >> @@ -573,6 +573,7 @@ static inline u32 omap_revision(void)
> > >>  #define OMAP4430_ES2_3	0x44300230
> > >>  #define OMAP4460_ES1_0	0x44600100
> > >>  #define OMAP4460_ES1_1	0x44600110
> > >> +#define OMAP4470_ES1_0	0x44700100
> > > and used where? we do not support 4470 in u-boot today, and to my
> > > knowledge, there is no plans to do it either.
> > 
> > Used on a custom MMS board that I'm working upon; it is up and running U-Boot
> > with a TI 750-2173 processor card, including USB EHCI (including HSIC devices).
> > Please see patch 233501 on my (very initial) 4470/6032 support.
> > 
> > If interested, I can post the board files as well.
> there is no u-boot support for 4470
> $ git branch -v
>   * master         c814263 Prepare v2013.04-rc2
> $ git grep 4470 .|grep OMAP
> $
> 
> What is the point in having board files for an SoC that is not supported
> in upstream?? My suggestion is that you either provide and maintain support for
> the SoC upstream (considering that inside TI, there seems be to no known
> motivation to do so) and introduce your board file, OR maintain this patch in
> the u-boot fork for the vendor board.

Those were patchwork numbers, not git hashes :)  He's posted a v1 of
board support for his platform already.
Nishanth Menon - April 4, 2013, 5:58 p.m.
On 12:54-20130404, Tom Rini wrote:
> On Thu, Apr 04, 2013 at 11:44:14AM -0500, Nishanth Menon wrote:
> > On 19:14-20130404, Lubomir Popov wrote:
> > > Hello,
> > > 
> > > On 04/04/13 19:00, Nishanth Menon wrote:
> > > > On 18:57-20130404, Lubomir Popov wrote:
> > > >> V2 fixes garbled subject.
> > > > move this to diffstat section - here and in the rest of the patches.
> > > >>
> > > >> Signed-off-by: Lubomir Popov <lpopov@mm-sol.com>
> > > >>
> > > >> ---
> > > >>  arch/arm/include/asm/omap_common.h   |    1 +
> > > >>  1 file changed, 1 insertion(+)
> > > >>
> > > >> diff --git a/arch/arm/include/asm/omap_common.h b/arch/arm/include/asm/omap_common.h
> > > >> index 091ddb5..f042c10 100644
> > > >> --- a/arch/arm/include/asm/omap_common.h
> > > >> +++ b/arch/arm/include/asm/omap_common.h
> > > >> @@ -573,6 +573,7 @@ static inline u32 omap_revision(void)
> > > >>  #define OMAP4430_ES2_3	0x44300230
> > > >>  #define OMAP4460_ES1_0	0x44600100
> > > >>  #define OMAP4460_ES1_1	0x44600110
> > > >> +#define OMAP4470_ES1_0	0x44700100
> > > > and used where? we do not support 4470 in u-boot today, and to my
> > > > knowledge, there is no plans to do it either.
> > > 
> > > Used on a custom MMS board that I'm working upon; it is up and running U-Boot
> > > with a TI 750-2173 processor card, including USB EHCI (including HSIC devices).
> > > Please see patch 233501 on my (very initial) 4470/6032 support.
> > > 
> > > If interested, I can post the board files as well.
> > there is no u-boot support for 4470
> > $ git branch -v
> >   * master         c814263 Prepare v2013.04-rc2
> > $ git grep 4470 .|grep OMAP
> > $
> > 
> > What is the point in having board files for an SoC that is not supported
> > in upstream?? My suggestion is that you either provide and maintain support for
> > the SoC upstream (considering that inside TI, there seems be to no known
> > motivation to do so) and introduce your board file, OR maintain this patch in
> > the u-boot fork for the vendor board.
> 
> Those were patchwork numbers, not git hashes :)  He's posted a v1 of
> board support for his platform already.
Aaah.. Thanks for the pointer. http://patchwork.ozlabs.org/patch/233501/
this patch does belong to that series. unfortunately, it is a bit hard
to review the pedigree of an patch when it is not properly sequenced :(.

Patch

diff --git a/arch/arm/include/asm/omap_common.h b/arch/arm/include/asm/omap_common.h
index 091ddb5..f042c10 100644
--- a/arch/arm/include/asm/omap_common.h
+++ b/arch/arm/include/asm/omap_common.h
@@ -573,6 +573,7 @@  static inline u32 omap_revision(void)
 #define OMAP4430_ES2_3	0x44300230
 #define OMAP4460_ES1_0	0x44600100
 #define OMAP4460_ES1_1	0x44600110
+#define OMAP4470_ES1_0	0x44700100
 
 /* omap5 */
 #define OMAP5430_SILICON_ID_INVALID	0