[U-Boot,v2] OMAP5: I2C: Add I2C4 and I2C5 bases

Submitted by Lubomir Popov on April 4, 2013, 3:52 p.m.

Details

Message ID 515DA1AE.1010209@mm-sol.com
State Superseded
Delegated to: Tom Rini
Headers show

Commit Message

Lubomir Popov April 4, 2013, 3:52 p.m.
V2 fixes line wrap issue of the patch itself.

Need to add these base addresses in order to use I2C4 and I2C5.

Signed-off-by: Lubomir Popov <lpopov@mm-sol.com>

---
 arch/arm/include/asm/arch-omap5/cpu.h |    2 ++
 1 file changed, 2 insertions(+)

Comments

Nishanth Menon April 4, 2013, 4:03 p.m.
On 18:52-20130404, Lubomir Popov wrote:
> V2 fixes line wrap issue of the patch itself.
> 
> Need to add these base addresses in order to use I2C4 and I2C5.
> 
> Signed-off-by: Lubomir Popov <lpopov@mm-sol.com>
> 
> ---
>  arch/arm/include/asm/arch-omap5/cpu.h |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/include/asm/arch-omap5/cpu.h b/arch/arm/include/asm/arch-omap5/cpu.h
> index 5e62013..044ab55 100644
> --- a/arch/arm/include/asm/arch-omap5/cpu.h
> +++ b/arch/arm/include/asm/arch-omap5/cpu.h
> @@ -142,6 +142,8 @@ struct watchdog {
>  #define I2C_BASE1		(OMAP54XX_L4_PER_BASE + 0x70000)
>  #define I2C_BASE2		(OMAP54XX_L4_PER_BASE + 0x72000)
>  #define I2C_BASE3		(OMAP54XX_L4_PER_BASE + 0x60000)
> +#define I2C_BASE4		(OMAP54XX_L4_PER_BASE + 0x7A000)
> +#define I2C_BASE5		(OMAP54XX_L4_PER_BASE + 0x7C000)
and used where.

Also could you repost the patches generated with
git format-patch -M -o someplace --cover-letter master..
so that the patches are numbered in the order that needs to be reviewed.

in general, if you introduce an macro, you need to use the macro in the
same patch. So, it seems to me that a few of your patches are supposed
to be squashed into a single one which enables i2c5 for omap5 as an
single patch.
>  
>  /* MUSB base */
>  #define MUSB_BASE		(OMAP54XX_L4_CORE_BASE + 0xAB000)
> -- 
> 1.7.9.5
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot

Patch hide | download patch | download mbox

diff --git a/arch/arm/include/asm/arch-omap5/cpu.h b/arch/arm/include/asm/arch-omap5/cpu.h
index 5e62013..044ab55 100644
--- a/arch/arm/include/asm/arch-omap5/cpu.h
+++ b/arch/arm/include/asm/arch-omap5/cpu.h
@@ -142,6 +142,8 @@  struct watchdog {
 #define I2C_BASE1		(OMAP54XX_L4_PER_BASE + 0x70000)
 #define I2C_BASE2		(OMAP54XX_L4_PER_BASE + 0x72000)
 #define I2C_BASE3		(OMAP54XX_L4_PER_BASE + 0x60000)
+#define I2C_BASE4		(OMAP54XX_L4_PER_BASE + 0x7A000)
+#define I2C_BASE5		(OMAP54XX_L4_PER_BASE + 0x7C000)
 
 /* MUSB base */
 #define MUSB_BASE		(OMAP54XX_L4_CORE_BASE + 0xAB000)