Patchwork [U-Boot,1/2] dfu:ext4:fix: Change ext4write command order of parameters

login
register
mail settings
Submitter Łukasz Majewski
Date April 4, 2013, 2:32 p.m.
Message ID <1365085978-22947-1-git-send-email-l.majewski@samsung.com>
Download mbox | patch
Permalink /patch/233855/
State Accepted
Delegated to: Tom Rini
Headers show

Comments

Łukasz Majewski - April 4, 2013, 2:32 p.m.
Following commit:
"cmd_ext4: BREAK and correct ext4write parameter order"
SHA1:0171d52c410cbaa9290b1b214e695697c835bfe5

introduced cleanup of ext4write semantics to be consistent with other
filesystem's writing commands (e.g. fatwrite).
This commit provides correct ext4write command generation at DFU eMMC
code.

Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
 drivers/dfu/dfu_mmc.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Tom Rini - April 8, 2013, 4:28 p.m.
On Thu, Apr 04, 2013 at 04:32:57PM +0200, Lukasz Majewski wrote:

> Following commit:
> "cmd_ext4: BREAK and correct ext4write parameter order"
> SHA1:0171d52c410cbaa9290b1b214e695697c835bfe5
> 
> introduced cleanup of ext4write semantics to be consistent with other
> filesystem's writing commands (e.g. fatwrite).
> This commit provides correct ext4write command generation at DFU eMMC
> code.
> 
> Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>

This along with 2/2 have been applied to u-boot/master, thanks!

Patch

diff --git a/drivers/dfu/dfu_mmc.c b/drivers/dfu/dfu_mmc.c
index 083d745..afd3506 100644
--- a/drivers/dfu/dfu_mmc.c
+++ b/drivers/dfu/dfu_mmc.c
@@ -72,10 +72,10 @@  static int mmc_file_op(enum dfu_mmc_op op, struct dfu_entity *dfu,
 			(unsigned int) buf, dfu->name, *len);
 		break;
 	case DFU_FS_EXT4:
-		sprintf(cmd_buf, "ext4%s mmc %d:%d /%s 0x%x %ld",
+		sprintf(cmd_buf, "ext4%s mmc %d:%d 0x%x /%s %ld",
 			op == DFU_OP_READ ? "load" : "write",
 			dfu->data.mmc.dev, dfu->data.mmc.part,
-			dfu->name, (unsigned int) buf, *len);
+			(unsigned int) buf, dfu->name, *len);
 		break;
 	default:
 		printf("%s: Layout (%s) not (yet) supported!\n", __func__,