Patchwork [U-Boot] video: exynos_fb: Add the missing #else clause

login
register
mail settings
Submitter Ajay Kumar
Date April 4, 2013, 2:25 p.m.
Message ID <1365085519-8203-1-git-send-email-ajaykumar.rs@samsung.com>
Download mbox | patch
Permalink /patch/233837/
State Accepted
Delegated to: Minkyu Kang
Headers show

Comments

Ajay Kumar - April 4, 2013, 2:25 p.m.
This patch fixes a bug introduced while adding DT support
to Exynos FIMD driver:

	commit c23f3157d69bbb6c044256870f745f195b12431e
	Author: Ajay Kumar <ajaykumar.rs@samsung.com>
	Date:   Thu Feb 21 23:53:01 2013 +0000

	    video: exynos_fb: add DT support for FIMD driver

Even though this part of code was missing, things were working
fine on Exynos5250 because, samsung_get_base_fimd() used
to give the correct base address for Exynos5250 FIMD.

Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com>
---
 drivers/video/exynos_fimd.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Ajay kumar - April 21, 2013, 5:03 p.m.
ping.


On Thu, Apr 4, 2013 at 7:55 PM, Ajay Kumar <ajaykumar.rs@samsung.com> wrote:

> This patch fixes a bug introduced while adding DT support
> to Exynos FIMD driver:
>
>         commit c23f3157d69bbb6c044256870f745f195b12431e
>         Author: Ajay Kumar <ajaykumar.rs@samsung.com>
>         Date:   Thu Feb 21 23:53:01 2013 +0000
>
>             video: exynos_fb: add DT support for FIMD driver
>
> Even though this part of code was missing, things were working
> fine on Exynos5250 because, samsung_get_base_fimd() used
> to give the correct base address for Exynos5250 FIMD.
>
> Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com>
> ---
>  drivers/video/exynos_fimd.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/video/exynos_fimd.c b/drivers/video/exynos_fimd.c
> index 3359949..7243ea3 100644
> --- a/drivers/video/exynos_fimd.c
> +++ b/drivers/video/exynos_fimd.c
> @@ -280,8 +280,9 @@ void exynos_fimd_lcd_init(vidinfo_t *vid)
>                                                                 node,
> "reg");
>         if (fimd_ctrl == NULL)
>                 debug("Can't get the FIMD base address\n");
> -#endif
> +#else
>         fimd_ctrl = (struct exynos_fb *)samsung_get_base_fimd();
> +#endif
>
>         offset = exynos_fimd_get_base_offset();
>
> --
> 1.8.0
>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>
Donghwa Lee - April 22, 2013, 1 a.m.
It looks good to me.

Acked-by: Donghwa Lee <dh09.lee@samsung.com>

Thank you,
Donghwa Lee


On Mon, Apr 22, 2013 at 02:03, Ajay kumar wrote:
> ping.
>
>
> On Thu, Apr 4, 2013 at 7:55 PM, Ajay Kumar <ajaykumar.rs@samsung.com 
> <mailto:ajaykumar.rs@samsung.com>> wrote:
>
>     This patch fixes a bug introduced while adding DT support
>     to Exynos FIMD driver:
>
>             commit c23f3157d69bbb6c044256870f745f195b12431e
>             Author: Ajay Kumar <ajaykumar.rs@samsung.com
>     <mailto:ajaykumar.rs@samsung.com>>
>             Date:   Thu Feb 21 23:53:01 2013 +0000
>
>                 video: exynos_fb: add DT support for FIMD driver
>
>     Even though this part of code was missing, things were working
>     fine on Exynos5250 because, samsung_get_base_fimd() used
>     to give the correct base address for Exynos5250 FIMD.
>
>     Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com
>     <mailto:ajaykumar.rs@samsung.com>>
>     ---
>      drivers/video/exynos_fimd.c | 3 ++-
>      1 file changed, 2 insertions(+), 1 deletion(-)
>
>     diff --git a/drivers/video/exynos_fimd.c b/drivers/video/exynos_fimd.c
>     index 3359949..7243ea3 100644
>     --- a/drivers/video/exynos_fimd.c
>     +++ b/drivers/video/exynos_fimd.c
>     @@ -280,8 +280,9 @@ void exynos_fimd_lcd_init(vidinfo_t *vid)
>         node, "reg");
>             if (fimd_ctrl == NULL)
>                     debug("Can't get the FIMD base address\n");
>     -#endif
>     +#else
>             fimd_ctrl = (struct exynos_fb *)samsung_get_base_fimd();
>     +#endif
>
>             offset = exynos_fimd_get_base_offset();
>
>     --
>     1.8.0
>
>     _______________________________________________
>     U-Boot mailing list
>     U-Boot@lists.denx.de <mailto:U-Boot@lists.denx.de>
>     http://lists.denx.de/mailman/listinfo/u-boot
>
>
Minkyu Kang - June 21, 2013, 12:15 a.m.
On 22/04/13 10:00, Donghwa Lee wrote:
> It looks good to me.
> 
> Acked-by: Donghwa Lee <dh09.lee@samsung.com>
> 
> Thank you,
> Donghwa Lee
> 
> 
> On Mon, Apr 22, 2013 at 02:03, Ajay kumar wrote:
>> ping.
>>
>>
>> On Thu, Apr 4, 2013 at 7:55 PM, Ajay Kumar <ajaykumar.rs@samsung.com <mailto:ajaykumar.rs@samsung.com>> wrote:
>>
>>     This patch fixes a bug introduced while adding DT support
>>     to Exynos FIMD driver:
>>
>>             commit c23f3157d69bbb6c044256870f745f195b12431e
>>             Author: Ajay Kumar <ajaykumar.rs@samsung.com <mailto:ajaykumar.rs@samsung.com>>
>>             Date:   Thu Feb 21 23:53:01 2013 +0000
>>
>>                 video: exynos_fb: add DT support for FIMD driver
>>
>>     Even though this part of code was missing, things were working
>>     fine on Exynos5250 because, samsung_get_base_fimd() used
>>     to give the correct base address for Exynos5250 FIMD.
>>
>>     Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com <mailto:ajaykumar.rs@samsung.com>>
>>     ---
>>      drivers/video/exynos_fimd.c | 3 ++-
>>      1 file changed, 2 insertions(+), 1 deletion(-)
>>
>>     diff --git a/drivers/video/exynos_fimd.c b/drivers/video/exynos_fimd.c
>>     index 3359949..7243ea3 100644
>>     --- a/drivers/video/exynos_fimd.c
>>     +++ b/drivers/video/exynos_fimd.c
>>     @@ -280,8 +280,9 @@ void exynos_fimd_lcd_init(vidinfo_t *vid)
>>                                                                     node, "reg");
>>             if (fimd_ctrl == NULL)
>>                     debug("Can't get the FIMD base address\n");
>>     -#endif
>>     +#else
>>             fimd_ctrl = (struct exynos_fb *)samsung_get_base_fimd();
>>     +#endif
>>
>>             offset = exynos_fimd_get_base_offset();
>>
>>     --
>>     1.8.0
>>
>>     _______________________________________________
>>     U-Boot mailing list
>>     U-Boot@lists.denx.de <mailto:U-Boot@lists.denx.de>
>>     http://lists.denx.de/mailman/listinfo/u-boot
>>
>>
> 

applied to u-boot-samsung.

thanks,
Minkyu Kang.

Patch

diff --git a/drivers/video/exynos_fimd.c b/drivers/video/exynos_fimd.c
index 3359949..7243ea3 100644
--- a/drivers/video/exynos_fimd.c
+++ b/drivers/video/exynos_fimd.c
@@ -280,8 +280,9 @@  void exynos_fimd_lcd_init(vidinfo_t *vid)
 								node, "reg");
 	if (fimd_ctrl == NULL)
 		debug("Can't get the FIMD base address\n");
-#endif
+#else
 	fimd_ctrl = (struct exynos_fb *)samsung_get_base_fimd();
+#endif
 
 	offset = exynos_fimd_get_base_offset();