From patchwork Thu Apr 4 14:01:09 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Polacek X-Patchwork-Id: 233831 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "localhost", Issuer "www.qmailtoaster.com" (not verified)) by ozlabs.org (Postfix) with ESMTPS id B67922C009C for ; Fri, 5 Apr 2013 01:01:37 +1100 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:subject:message-id:mime-version:content-type; q=dns; s= default; b=aF35wiDatXzbwYqkoHZn47SreDN+8wE6tfrVhs0i3kMIRyCUIpXR7 LMUZXdDsBdkTxvnhl8V0N6ijI1aLLTUq875uC5ok3N6rOzjL3fp8H2qtb0HAQiCn b/UIOpsiHj7tVf862+oqFTIOTh4NDUyBg3NoQ12z4R0F1Yteu7WnSU= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:subject:message-id:mime-version:content-type; s= default; bh=1fgV1cjtVSdSUoatVIFfUHi0g40=; b=kq2GHEowBsBm2mxto2HI rAXJwELC/sR2gRGhLiSevdhJclIwbY5DNVbIPm1hnO59sjYcYadjhSV20a88pOEF nVYB/yqyj3XRW84Poa5XV8rb0kw0Lrjp2MVz873zbUEa/Rh9eSd1VOPK+0LH25ph ybC43+smv4MRJutQbYb2Jc0= Received: (qmail 28064 invoked by alias); 4 Apr 2013 14:01:16 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 28043 invoked by uid 89); 4 Apr 2013 14:01:16 -0000 X-Spam-SWARE-Status: No, score=-7.7 required=5.0 tests=AWL, BAYES_00, KHOP_RCVD_UNTRUST, RCVD_IN_DNSWL_HI, RCVD_IN_HOSTKARMA_W, RP_MATCHES_RCVD, SPF_HELO_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 04 Apr 2013 14:01:13 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r34E1C14006003 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 4 Apr 2013 10:01:12 -0400 Received: from redhat.com (ovpn-116-29.ams2.redhat.com [10.36.116.29]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r34E19IV015110 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO) for ; Thu, 4 Apr 2013 10:01:11 -0400 Date: Thu, 4 Apr 2013 16:01:09 +0200 From: Marek Polacek To: GCC Patches Subject: [PATCH] Fix PR48184 Message-ID: <20130404140108.GD24873@redhat.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.20 (2009-06-14) This fixes an ICE in case we use weirdo --param value for PARAM_ALIGN_THRESHOLD. The patch is by Andrew; I added CL, testcase and tested. Bootstrapped/regtested on x86_64-linux, ok for trunk? And what about other branches? 2013-04-04 Marek Polacek Andrew Pinski PR tree-optimization/48184 * final.c (compute_alignments): Set threshold to 0 if PARAM_ALIGN_THRESHOLD is 0. * gcc.dg/pr48184.c: New test. Marek --- gcc/final.c.mp 2013-04-04 14:09:04.626020852 +0200 +++ gcc/final.c 2013-04-04 14:09:05.672024174 +0200 @@ -701,7 +701,10 @@ compute_alignments (void) FOR_EACH_BB (bb) if (bb->frequency > freq_max) freq_max = bb->frequency; - freq_threshold = freq_max / PARAM_VALUE (PARAM_ALIGN_THRESHOLD); + if (PARAM_VALUE (PARAM_ALIGN_THRESHOLD) == 0) + freq_threshold = 0; + else + freq_threshold = freq_max / PARAM_VALUE (PARAM_ALIGN_THRESHOLD); if (dump_file) fprintf(dump_file, "freq_max: %i\n",freq_max); --- gcc/testsuite/gcc.dg/pr48184.c.mp 2013-04-04 13:23:15.356769534 +0200 +++ gcc/testsuite/gcc.dg/pr48184.c 2013-04-04 14:05:05.506241464 +0200 @@ -0,0 +1,5 @@ +/* PR tree-optimization/48184 */ +/* { dg-do compile } */ +/* { dg-options "-O --param align-threshold=0" } */ + +void foo (void) { }