Patchwork [1/1] libata: sata_rcar: Convert to devm_ioremap_resource()

login
register
mail settings
Submitter Sachin Kamat
Date April 4, 2013, 9:26 a.m.
Message ID <1365067596-8868-1-git-send-email-sachin.kamat@linaro.org>
Download mbox | patch
Permalink /patch/233697/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Sachin Kamat - April 4, 2013, 9:26 a.m.
Use the newly introduced devm_ioremap_resource() instead of
devm_request_and_ioremap() which provides more consistent error handling.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 drivers/ata/sata_rcar.c |    7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
Sergei Shtylyov - April 4, 2013, 2:43 p.m.
Hello.

On 04-04-2013 13:26, Sachin Kamat wrote:

> Use the newly introduced devm_ioremap_resource() instead of
> devm_request_and_ioremap() which provides more consistent error handling.

> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>

Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jeff Garzik - April 11, 2013, 11:35 p.m.
On 04/04/2013 05:26 AM, Sachin Kamat wrote:
> Use the newly introduced devm_ioremap_resource() instead of
> devm_request_and_ioremap() which provides more consistent error handling.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
>   drivers/ata/sata_rcar.c |    7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)

applied



--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/ata/sata_rcar.c b/drivers/ata/sata_rcar.c
index caf33f6..4799868 100644
--- a/drivers/ata/sata_rcar.c
+++ b/drivers/ata/sata_rcar.c
@@ -17,6 +17,7 @@ 
 #include <linux/libata.h>
 #include <linux/platform_device.h>
 #include <linux/clk.h>
+#include <linux/err.h>
 
 #define DRV_NAME "sata_rcar"
 
@@ -799,9 +800,9 @@  static int sata_rcar_probe(struct platform_device *pdev)
 
 	host->private_data = priv;
 
-	priv->base = devm_request_and_ioremap(&pdev->dev, mem);
-	if (!priv->base) {
-		ret = -EADDRNOTAVAIL;
+	priv->base = devm_ioremap_resource(&pdev->dev, mem);
+	if (IS_ERR(priv->base)) {
+		ret = PTR_ERR(priv->base);
 		goto cleanup;
 	}