Patchwork [RFC,4/6] audio: remove CONFIG_* symbols

login
register
mail settings
Submitter Paolo Bonzini
Date April 2, 2013, 2:50 p.m.
Message ID <1364914261-4237-5-git-send-email-pbonzini@redhat.com>
Download mbox | patch
Permalink /patch/233027/
State New
Headers show

Comments

Paolo Bonzini - April 2, 2013, 2:50 p.m.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 configure | 9 ---------
 1 file changed, 9 deletions(-)
Andreas Färber - April 10, 2013, 5:45 p.m.
Am 02.04.2013 16:50, schrieb Paolo Bonzini:
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Could this patch be squashed into 2/6? Or does it depend on anything
else - commit message doesn't indicate.

Andreas

> ---
>  configure | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/configure b/configure
> index 16380f6..1b2dc53 100755
> --- a/configure
> +++ b/configure
> @@ -3557,10 +3557,6 @@ fi
>  if test "$cap_ng" = "yes" ; then
>    echo "CONFIG_LIBCAP=y" >> $config_host_mak
>  fi
> -for card in $audio_card_list; do
> -    def=CONFIG_`echo $card | LC_ALL=C tr '[a-z]' '[A-Z]'`
> -    echo "$def=y" >> $config_host_mak
> -done
>  echo "CONFIG_AUDIO_DRIVERS=$audio_drv_list" >> $config_host_mak
>  for drv in $audio_drv_list; do
>      def=CONFIG_`echo $drv | LC_ALL=C tr '[a-z]' '[A-Z]'`
> @@ -4226,11 +4222,6 @@ if test "$target_bsd_user" = "yes" ; then
>    echo "CONFIG_BSD_USER=y" >> $config_target_mak
>  fi
>  
> -# the static way of configuring available audio cards requires this workaround
> -if test "$target_user_only" != "yes" && grep -q CONFIG_PCSPK $source_path/default-configs/$target.mak; then
> -  echo "CONFIG_PCSPK=y" >> $config_target_mak
> -fi
> -
>  # generate QEMU_CFLAGS/LDFLAGS for targets
>  
>  cflags=""
>
Paolo Bonzini - April 11, 2013, 6:30 a.m.
Il 10/04/2013 19:45, Andreas Färber ha scritto:
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> Could this patch be squashed into 2/6? Or does it depend on anything
> else - commit message doesn't indicate.

I prefer to keep separate things separate, 2/6 is already quite large.

Paolo

Patch

diff --git a/configure b/configure
index 16380f6..1b2dc53 100755
--- a/configure
+++ b/configure
@@ -3557,10 +3557,6 @@  fi
 if test "$cap_ng" = "yes" ; then
   echo "CONFIG_LIBCAP=y" >> $config_host_mak
 fi
-for card in $audio_card_list; do
-    def=CONFIG_`echo $card | LC_ALL=C tr '[a-z]' '[A-Z]'`
-    echo "$def=y" >> $config_host_mak
-done
 echo "CONFIG_AUDIO_DRIVERS=$audio_drv_list" >> $config_host_mak
 for drv in $audio_drv_list; do
     def=CONFIG_`echo $drv | LC_ALL=C tr '[a-z]' '[A-Z]'`
@@ -4226,11 +4222,6 @@  if test "$target_bsd_user" = "yes" ; then
   echo "CONFIG_BSD_USER=y" >> $config_target_mak
 fi
 
-# the static way of configuring available audio cards requires this workaround
-if test "$target_user_only" != "yes" && grep -q CONFIG_PCSPK $source_path/default-configs/$target.mak; then
-  echo "CONFIG_PCSPK=y" >> $config_target_mak
-fi
-
 # generate QEMU_CFLAGS/LDFLAGS for targets
 
 cflags=""