From patchwork Tue Apr 2 14:24:06 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Ivchenko X-Patchwork-Id: 233015 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "localhost", Issuer "www.qmailtoaster.com" (not verified)) by ozlabs.org (Postfix) with ESMTPS id DAEB72C012C for ; Wed, 3 Apr 2013 01:24:28 +1100 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; q=dns; s=default; b=R3BDw4r9H1yMJ+bync AHhhkNCnYxJRBGC7a0COwggCKDlUvILhn1JMr3byEEUeNAmKNU84pnjYCx1OTvRW P5fuLgT4BRYxy9T2ehu2+1V3MKXxT2ffYfLwitd89nLmIniGHnuJJHHH3VWCehkX evVS22nekdJ61PKk4XzTL4H00= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; s=default; bh=Ui+32jDg0akLkPVSG6Tg/R4C 2oo=; b=C3A/WGJGRav9Cj2Mmj7Qe1yNPiQTTohxxfCVGA2zJJBsdXrlWLVXytJt vdnTlJJ8pkBF+5sJVTQkZOgg2taF6gv1fdftWChBWzK/pKspG5NGZL/G4MgPqgG9 2rGbrLxbEfqjSAiRLTrahFrBc1/4G/VKMgh0e2tvnBINZvEgG9Y= Received: (qmail 21612 invoked by alias); 2 Apr 2013 14:24:18 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 21576 invoked by uid 89); 2 Apr 2013 14:24:11 -0000 X-Spam-SWARE-Status: No, score=-5.1 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, KHOP_RCVD_TRUST, KHOP_THREADED, RCVD_IN_DNSWL_LOW, RCVD_IN_HOSTKARMA_YE autolearn=ham version=3.3.1 Received: from mail-pa0-f48.google.com (HELO mail-pa0-f48.google.com) (209.85.220.48) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 02 Apr 2013 14:24:08 +0000 Received: by mail-pa0-f48.google.com with SMTP id lj1so320958pab.7 for ; Tue, 02 Apr 2013 07:24:06 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.66.144.103 with SMTP id sl7mr25331023pab.55.1364912646551; Tue, 02 Apr 2013 07:24:06 -0700 (PDT) Received: by 10.68.229.137 with HTTP; Tue, 2 Apr 2013 07:24:06 -0700 (PDT) In-Reply-To: <20130402132434.GN20616@tucnak.redhat.com> References: <28659BFC-706C-4478-BAFA-142383271369@codesourcery.com> <96A7A77D-8593-447D-97CC-BD0D56CD8AE9@gmail.com> <3818B8BE-E9E4-42A9-A23E-D0B70118978E@gmail.com> <0ED475A3-66CD-4D15-B0AA-A2D37FAB2F6C@kugelworks.com> <20130402132434.GN20616@tucnak.redhat.com> Date: Tue, 2 Apr 2013 18:24:06 +0400 Message-ID: Subject: Re: [RFC PATCH] Implementing ifunc target hook From: Alexander Ivchenko To: Jakub Jelinek Cc: Kirill Yukhin , Maxim Kuvyrkov , GCC Patches Yep.. we missed that: t-linux-android was added here: # Add Android userspace support to Linux targets. case $target in *linux*) tm_p_file="${tm_p_file} linux-protos.h" tmake_file="${tmake_file} t-linux-android" tm_file="$tm_file linux-android.h" extra_options="$extra_options linux-android.opt" extra_objs="$extra_objs linux-android.o" ;; esac and here: arm*-*-linux-*) # ARM GNU/Linux with ELF tm_file="dbxelf.h elfos.h gnu-user.h linux.h linux-android.h glibc-stdint.h arm/elf.h arm/linux-gas.h arm/linux-elf.h" case $target in arm*b-*-linux*) tm_defines="${tm_defines} TARGET_BIG_ENDIAN_DEFAULT=1" ;; esac tmake_file="${tmake_file} arm/t-arm arm/t-arm-elf arm/t-bpabi arm/t-linux-eabi t-linux-android" tm_file="$tm_file arm/bpabi.h arm/linux-eabi.h arm/aout.h arm/arm.h" extra_objs="$extra_objs linux-android.o" # Define multilib configuration for arm-linux-androideabi. case ${target} in *-androideabi) tmake_file="$tmake_file arm/t-linux-androideabi" ;; esac I deleted the second encounter: extra_objs="$extra_objs linux-android.o" # Define multilib configuration for arm-linux-androideabi. is it ok? thanks, Alexander 2013/4/2 Jakub Jelinek : > On Wed, Mar 27, 2013 at 01:56:48PM +0400, Kirill Yukhin wrote: >> > >> > Otherwise OK. >> > >> > Thanks, >> >> Hi, chacked into trunk: http://gcc.gnu.org/ml/gcc-cvs/2013-03/msg00785.html > > This leads to: > ../../gcc/config/t-linux-android:22: warning: overriding recipe for target `linux-android.o' > ../../gcc/config/t-linux-android:22: warning: ignoring old recipe for target `linux-android.o' > for arm*-linux* target (cross in my case). t-linux-android is listed twice. > > Jakub diff --git a/gcc/ChangeLog b/gcc/ChangeLog index d18c6e9..0e1d5e4 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,7 @@ +2013-04-02 Alexander Ivchenko + + * config.gcc (arm*-*-linux-*): Remove duplicate t-linux-android. + 2013-04-02 Richard Biener PR tree-optimization/56778 diff --git a/gcc/config.gcc b/gcc/config.gcc index e51db91..44ed190 100644 --- a/gcc/config.gcc +++ b/gcc/config.gcc @@ -878,7 +878,7 @@ arm*-*-linux-*) # ARM GNU/Linux with ELF tm_defines="${tm_defines} TARGET_BIG_ENDIAN_DEFAULT=1" ;; esac - tmake_file="${tmake_file} arm/t-arm arm/t-arm-elf arm/t-bpabi arm/t-linux-eabi t-linux-android" + tmake_file="${tmake_file} arm/t-arm arm/t-arm-elf arm/t-bpabi arm/t-linux-eabi" tm_file="$tm_file arm/bpabi.h arm/linux-eabi.h arm/aout.h arm/arm.h"