Patchwork uefirtvariable: add some information for the GetNextVariableName sub-tests

login
register
mail settings
Submitter Ivan Hu
Date April 2, 2013, 5:40 a.m.
Message ID <1364881257-4912-1-git-send-email-ivan.hu@canonical.com>
Download mbox | patch
Permalink /patch/232887/
State Rejected
Headers show

Comments

Ivan Hu - April 2, 2013, 5:40 a.m.
Add more information for testing the GetNextVarialbeName sub-tests.

Signed-off-by: Ivan Hu <ivan.hu@canonical.com>
---
 src/uefi/uefirtvariable/uefirtvariable.c |    9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
Colin King - April 3, 2013, 9:55 a.m.
On 02/04/13 06:40, Ivan Hu wrote:
> Add more information for testing the GetNextVarialbeName sub-tests.
> 
> Signed-off-by: Ivan Hu <ivan.hu@canonical.com>
> ---
>  src/uefi/uefirtvariable/uefirtvariable.c |    9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/src/uefi/uefirtvariable/uefirtvariable.c b/src/uefi/uefirtvariable/uefirtvariable.c
> index 7242afd..3fcf845 100644
> --- a/src/uefi/uefirtvariable/uefirtvariable.c
> +++ b/src/uefi/uefirtvariable/uefirtvariable.c
> @@ -1163,23 +1163,30 @@ static int uefirtvariable_test2(fwts_framework *fw)
>  {
>  	int ret;
>  
> +	fwts_log_info(fw, "The runtime service GetNextVariableName interface function test.");
>  	ret = getnextvariable_test1(fw);
>  	if (ret != FWTS_OK)
>  		return ret;
> +	fwts_passed(fw, "The runtime service GetNextVariableName interface function test passed.");
>  
> +	fwts_log_info(fw, "Check the GetNextVariableName returned value of VariableNameSize is equal to the length of VariableName.");
>  	ret = getnextvariable_test2(fw);
>  	if (ret != FWTS_OK)
>  		return ret;
> +	fwts_passed(fw, "Check the GetNextVariableName the returned value of VariableNameSize is equal to the length of VariableName passed.");

I think this should be:

	fwts_passed(fw, "Check the GetNextVariableName returned value of
VariableNameSize is equal to the length of VariableName passed.");


>  
> +	fwts_log_info(fw, "Test GetNextVariableName interface returns unique variables.");
>  	ret = getnextvariable_test3(fw);
>  	if (ret != FWTS_OK)
>  		return ret;
> +	fwts_passed(fw, "Test GetNextVariableName interface returns unique variables passed.");
>  
> +	fwts_log_info(fw, "The GetNextVariableName interface conformance tests.");
>  	ret = getnextvariable_test4(fw);
>  	if (ret != FWTS_OK)
>  		return ret;
> +	fwts_passed(fw, "The runtime service GetNextVariableName interface conformance tests passed.");
>  
> -	fwts_passed(fw, "UEFI runtime service GetNextVariableName interface test passed.");
>  
>  	return FWTS_OK;
>  }
>

Patch

diff --git a/src/uefi/uefirtvariable/uefirtvariable.c b/src/uefi/uefirtvariable/uefirtvariable.c
index 7242afd..3fcf845 100644
--- a/src/uefi/uefirtvariable/uefirtvariable.c
+++ b/src/uefi/uefirtvariable/uefirtvariable.c
@@ -1163,23 +1163,30 @@  static int uefirtvariable_test2(fwts_framework *fw)
 {
 	int ret;
 
+	fwts_log_info(fw, "The runtime service GetNextVariableName interface function test.");
 	ret = getnextvariable_test1(fw);
 	if (ret != FWTS_OK)
 		return ret;
+	fwts_passed(fw, "The runtime service GetNextVariableName interface function test passed.");
 
+	fwts_log_info(fw, "Check the GetNextVariableName returned value of VariableNameSize is equal to the length of VariableName.");
 	ret = getnextvariable_test2(fw);
 	if (ret != FWTS_OK)
 		return ret;
+	fwts_passed(fw, "Check the GetNextVariableName the returned value of VariableNameSize is equal to the length of VariableName passed.");
 
+	fwts_log_info(fw, "Test GetNextVariableName interface returns unique variables.");
 	ret = getnextvariable_test3(fw);
 	if (ret != FWTS_OK)
 		return ret;
+	fwts_passed(fw, "Test GetNextVariableName interface returns unique variables passed.");
 
+	fwts_log_info(fw, "The GetNextVariableName interface conformance tests.");
 	ret = getnextvariable_test4(fw);
 	if (ret != FWTS_OK)
 		return ret;
+	fwts_passed(fw, "The runtime service GetNextVariableName interface conformance tests passed.");
 
-	fwts_passed(fw, "UEFI runtime service GetNextVariableName interface test passed.");
 
 	return FWTS_OK;
 }