Patchwork target-ppc: Enable ISEL on POWER7

login
register
mail settings
Submitter Aurelien Jarno
Date April 1, 2013, 3:06 p.m.
Message ID <1364828783-23001-1-git-send-email-aurelien@aurel32.net>
Download mbox | patch
Permalink /patch/232768/
State New
Headers show

Comments

Aurelien Jarno - April 1, 2013, 3:06 p.m.
ISEL is a Power ISA 2.06 instruction and thus is available on POWER7.
Given this is trapped and emulated by the Linux kernel, I guess it went
unnoticed.

Cc: Alexander Graf <agraf@suse.de>
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
---
 target-ppc/translate_init.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Alexander Graf - April 2, 2013, 6:17 a.m.
On 01.04.2013, at 17:06, Aurelien Jarno wrote:

> ISEL is a Power ISA 2.06 instruction and thus is available on POWER7.
> Given this is trapped and emulated by the Linux kernel, I guess it went
> unnoticed.
> 
> Cc: Alexander Graf <agraf@suse.de>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>

Thanks, applied to ppc-next.

Alex

> ---
> target-ppc/translate_init.c |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
> index 781170f..aea7d27 100644
> --- a/target-ppc/translate_init.c
> +++ b/target-ppc/translate_init.c
> @@ -7004,7 +7004,7 @@ POWERPC_FAMILY(POWER7)(ObjectClass *oc, void *data)
>     dc->desc = "POWER7";
>     pcc->init_proc = init_proc_POWER7;
>     pcc->check_pow = check_pow_nocheck;
> -    pcc->insns_flags = PPC_INSNS_BASE | PPC_STRING | PPC_MFTB |
> +    pcc->insns_flags = PPC_INSNS_BASE | PPC_ISEL | PPC_STRING | PPC_MFTB |
>                        PPC_FLOAT | PPC_FLOAT_FSEL | PPC_FLOAT_FRES |
>                        PPC_FLOAT_FSQRT | PPC_FLOAT_FRSQRTE |
>                        PPC_FLOAT_STFIWX |
> -- 
> 1.7.10.4
>

Patch

diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
index 781170f..aea7d27 100644
--- a/target-ppc/translate_init.c
+++ b/target-ppc/translate_init.c
@@ -7004,7 +7004,7 @@  POWERPC_FAMILY(POWER7)(ObjectClass *oc, void *data)
     dc->desc = "POWER7";
     pcc->init_proc = init_proc_POWER7;
     pcc->check_pow = check_pow_nocheck;
-    pcc->insns_flags = PPC_INSNS_BASE | PPC_STRING | PPC_MFTB |
+    pcc->insns_flags = PPC_INSNS_BASE | PPC_ISEL | PPC_STRING | PPC_MFTB |
                        PPC_FLOAT | PPC_FLOAT_FSEL | PPC_FLOAT_FRES |
                        PPC_FLOAT_FSQRT | PPC_FLOAT_FRSQRTE |
                        PPC_FLOAT_STFIWX |