Patchwork mtd: cfi_cmdset_0002: print @adr when write timeout occurs

login
register
mail settings
Submitter Huang Shijie
Date April 1, 2013, 9:40 a.m.
Message ID <1364809218-28393-1-git-send-email-b32955@freescale.com>
Download mbox | patch
Permalink /patch/232711/
State New
Headers show

Comments

Huang Shijie - April 1, 2013, 9:40 a.m.
Print out the @adr when the write timeout occurs.
This is useful to check if the write timeouts occur at the
same address.

Signed-off-by: Huang Shijie <b32955@freescale.com>
---
 drivers/mtd/chips/cfi_cmdset_0002.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Artem Bityutskiy - May 10, 2013, 1:55 p.m.
On Mon, 2013-04-01 at 17:40 +0800, Huang Shijie wrote:
> Print out the @adr when the write timeout occurs.
> This is useful to check if the write timeouts occur at the
> same address.
> 
> Signed-off-by: Huang Shijie <b32955@freescale.com>

Pushed to l2-mtd.git, thanks!

Patch

diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c b/drivers/mtd/chips/cfi_cmdset_0002.c
index fff665d..89b9d68 100644
--- a/drivers/mtd/chips/cfi_cmdset_0002.c
+++ b/drivers/mtd/chips/cfi_cmdset_0002.c
@@ -1571,8 +1571,8 @@  static int __xipram do_write_buffer(struct map_info *map, struct flchip *chip,
 	xip_enable(map, chip, adr);
 	/* FIXME - should have reset delay before continuing */
 
-	printk(KERN_WARNING "MTD %s(): software timeout\n",
-	       __func__ );
+	printk(KERN_WARNING "MTD %s(): software timeout, address:0x%.8lx.\n",
+	       __func__, adr);
 
 	ret = -EIO;
  op_done: