From patchwork Tue Feb 17 10:16:46 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yang Li X-Patchwork-Id: 23246 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from ozlabs.org (localhost [127.0.0.1]) by ozlabs.org (Postfix) with ESMTP id 5F7FFDDF32 for ; Tue, 17 Feb 2009 21:17:25 +1100 (EST) X-Original-To: linuxppc-dev@ozlabs.org Delivered-To: linuxppc-dev@ozlabs.org Received: from az33egw02.freescale.net (az33egw02.freescale.net [192.88.158.103]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "az33egw02.freescale.net", Issuer "Thawte Premium Server CA" (verified OK)) by ozlabs.org (Postfix) with ESMTPS id 15313DDDA0 for ; Tue, 17 Feb 2009 21:16:55 +1100 (EST) Received: from az33smr01.freescale.net (az33smr01.freescale.net [10.64.34.199]) by az33egw02.freescale.net (8.14.3/az33egw02) with ESMTP id n1HAGoUn021608 for ; Tue, 17 Feb 2009 03:16:51 -0700 (MST) Received: from zch01exm26.fsl.freescale.net (zch01exm26.ap.freescale.net [10.192.129.221]) by az33smr01.freescale.net (8.13.1/8.13.0) with ESMTP id n1HAGnMg012945 for ; Tue, 17 Feb 2009 04:16:50 -0600 (CST) Content-class: urn:content-classes:message MIME-Version: 1.0 X-MimeOLE: Produced By Microsoft Exchange V6.5 Subject: RE: PROBLEM: incorrect interrupt ack lead to interrupt loss on freescale powerpc Date: Tue, 17 Feb 2009 18:16:46 +0800 Message-ID: <3A45394FD742FA419B760BB8D398F9ED246D03@zch01exm26.fsl.freescale.net> In-Reply-To: X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: PROBLEM: incorrect interrupt ack lead to interrupt loss on freescale powerpc Thread-Index: AcmQ2n06DcXf5Ar+T+SgI94lU1s0UQADMFlQ References: From: "Li Yang-R58472" To: , Cc: linuxppc-dev@ozlabs.org X-BeenThere: linuxppc-dev@ozlabs.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org > -----Original Message----- > From: dayu@datangmobile.cn [mailto:dayu@datangmobile.cn] > Sent: Tuesday, February 17, 2009 4:34 PM > To: linux-kernel@vger.kernel.org > Cc: Li Yang-R58472 > Subject: PROBLEM: incorrect interrupt ack lead to interrupt > loss on freescale powerpc > > > [1.] One line summary of the problem: incorrect interrupt ack > lead to interrupt loss Acked-by: Li Yang However, please resend the patch with a brief description and Signed-off-by at the top of the patch. You can read the Documentation/SubmittiongPatches for more information, or even a Chinese version under Documentation/zh_CN/. Here are some small comments about the patch itself, */ #include #include @@ -561,8 +562,7 @@ spin_lock_irqsave(&ipic_lock, flags); - temp = ipic_read(ipic->regs, ipic_info[src].pend); - temp |= (1 << (31 - ipic_info[src].bit)); + temp = (1 << (31 - ipic_info[src].bit)); Remove unneeded brackets. ipic_write(ipic->regs, ipic_info[src].pend, temp); spin_unlock_irqrestore(&ipic_lock, flags); @@ -581,8 +581,7 @@ temp &= ~(1 << (31 - ipic_info[src].bit)); ipic_write(ipic->regs, ipic_info[src].mask, temp); - temp = ipic_read(ipic->regs, ipic_info[src].pend); - temp |= (1 << (31 - ipic_info[src].bit)); + temp = (1 << (31 - ipic_info[src].bit)); Same as above. ipic_write(ipic->regs, ipic_info[src].pend, temp); spin_unlock_irqrestore(&ipic_lock, flags); --- a/arch/powerpc/sysdev/ipic.c 2009-02-17 15:10:18.000000000 +0800 +++ b/arch/powerpc/sysdev/ipic.c 2009-02-17 15:10:24.000000000 +0800 @@ -9,6 +9,7 @@ * under the terms of the GNU General Public License as published by the * Free Software Foundation; either version 2 of the License, or (at your * option) any later version. + * Da Yu fixed the interrupt loss problem on powerpc IPIC It's not recommended to add changelog in the source now. Please describe in the patch description area.