Message ID | OF95B2AB6A.BE754AB4-ON44257B3D.00544464-44257B3D.0054ECCB@gb.elster.com |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
From: Max.Nekludov@us.elster.com Date: Fri, 29 Mar 2013 19:27:36 +0400 > Denis, > here is patch with commit message: > > Subject: [PATCH] Fix bug in ks8851 driver > > According to the Datasheet (page 52): > 15-12 Reserved > 11-0 RXBC Receive Byte Count > This field indicates the present received frame byte size. > > The code has a bug: > rxh = ks8851_rdreg32(ks, KS_RXFHSR); > rxstat = rxh & 0xffff; > rxlen = rxh >> 16; // BUG!!! 0xFFF mask should be applied > > Signed-off-by: Max Nekludov <Max.Nekludov@us.elster.com> Applied and queued up for -stable, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ethernet/micrel/ks8851.c b/drivers/net/ethernet/micrel/ks8851.c index 33bcb63d56a2..8fb481252e2c 100644 --- a/drivers/net/ethernet/micrel/ks8851.c +++ b/drivers/net/ethernet/micrel/ks8851.c @@ -528,7 +528,7 @@ static void ks8851_rx_pkts(struct ks8851_net *ks) for (; rxfc != 0; rxfc--) { rxh = ks8851_rdreg32(ks, KS_RXFHSR); rxstat = rxh & 0xffff; - rxlen = rxh >> 16; + rxlen = (rxh >> 16) & 0xfff; netif_dbg(ks, rx_status, ks->netdev, "rx: stat 0x%04x, len 0x%04x\n", rxstat, rxlen);