From patchwork Fri Mar 29 15:13:21 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe Lyon X-Patchwork-Id: 232436 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 127972C00BF for ; Sat, 30 Mar 2013 02:13:51 +1100 (EST) Received: from localhost ([::1]:37553 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ULb01-0006xo-3E for incoming@patchwork.ozlabs.org; Fri, 29 Mar 2013 11:13:49 -0400 Received: from eggs.gnu.org ([208.118.235.92]:60643) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ULazb-0006py-Ms for qemu-devel@nongnu.org; Fri, 29 Mar 2013 11:13:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ULaza-0006BQ-9U for qemu-devel@nongnu.org; Fri, 29 Mar 2013 11:13:23 -0400 Received: from mail-ob0-x22b.google.com ([2607:f8b0:4003:c01::22b]:54469) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ULazZ-0006BK-Sj for qemu-devel@nongnu.org; Fri, 29 Mar 2013 11:13:22 -0400 Received: by mail-ob0-f171.google.com with SMTP id x4so469139obh.2 for ; Fri, 29 Mar 2013 08:13:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:x-gm-message-state; bh=FQOTpnyCiXzBAEdbYbTuNjYS05jlsga1vVXQU/fMeCU=; b=L9LBWMByuR+GNR6QL8cpvigB6588XbslzpG1qdOu5LKkOrPaG+MpoHe39HhM3BcHCd soouYmXOVUF74gd2sNzb0oqqa6t6skID4h2aAxLt8+TFeRV8Gk5AeXV4+GkSZOryu3Tr EqZx88npcQL4ZBTSp95/Oz/e8rF/EUfGo61zDpVgl8Eo4tihrVrWEtxGFk0HikRu4KFC 85CdKbnBxtpjzFv5Fe/Evjcu8Oe/rjLrnsRQ5RZ1WtTcANEWnmYtKFf9Tw+CUDExKtqm dVds3Cqdc5/+cVNbAQJ0JcKs4pkISPH5Z9TWRThWgV2QtQBySGHAfUFF3IDjiySHSghv EkRg== MIME-Version: 1.0 X-Received: by 10.60.98.209 with SMTP id ek17mr930640oeb.132.1364570001352; Fri, 29 Mar 2013 08:13:21 -0700 (PDT) Received: by 10.60.62.10 with HTTP; Fri, 29 Mar 2013 08:13:21 -0700 (PDT) In-Reply-To: References: Date: Fri, 29 Mar 2013 16:13:21 +0100 Message-ID: From: Christophe Lyon To: Peter Maydell X-Gm-Message-State: ALoCoQnYv+ZxahI7/GFmMzjFxJ5ud6Ua/6uyZrBqWJ80cJIkPnU9T8MpraRd1yPzPd3n9YqVVfVI X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:4003:c01::22b Cc: qemu-devel@nongnu.org Subject: Re: [Qemu-devel] [Patch] fix /proc/self/maps output X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Hi, Sorry I wasn't aware of such restrictions (I'm used to gcc/binutils conventions), and my thunderbird does display my patch as if it were inline :-) So.... trying a cut-and-paste approach in gmail, for this one character patch: /proc/self/maps: Add a space at end of line when there is no filename to print, to conform to linux kernel format. Signed-off-by: Christophe Lyon On 29 March 2013 15:44, Peter Maydell wrote: > On 29 March 2013 14:33, Christophe Lyon wrote: >> Hi, >> May I ping for this small patch? > > Hi Christophe; I'm afraid the patch can't be applied because it's > missing a signed-off by. (Also if it was sent inline in the usual > format rather than as an attachment it would be easier to review.) > > thanks > -- PMM diff --git a/linux-user/syscall.c b/linux-user/syscall.c index a148d9f..3b0ca86 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -5016,7 +5016,7 @@ static int open_self_maps(void *cpu_env, int fd) " %c%c%c%c %08" PRIx64 " %02x:%02x %d%s%s\n", h2g(min), h2g(max), flag_r, flag_w, flag_x, flag_p, offset, dev_maj, dev_min, inode, - path[0] ? " " : "", path); + path[0] ? " " : " ", path); } }