Patchwork fix /proc/self/maps output

login
register
mail settings
Submitter Christophe Lyon
Date March 29, 2013, 3:13 p.m.
Message ID <CAKdteOYy5J9oX3s6Z2GC2n5GQh4hDTBWw24kPTTe3i2P+qgmSA@mail.gmail.com>
Download mbox | patch
Permalink /patch/232436/
State New
Headers show

Comments

Christophe Lyon - March 29, 2013, 3:13 p.m.
Hi,

Sorry I wasn't aware of such restrictions (I'm used to gcc/binutils
conventions), and my thunderbird does display my patch as if it were
inline :-)
So.... trying a cut-and-paste approach in gmail, for this one character patch:


/proc/self/maps: Add a space at end of line when there is no filename
to print, to conform to linux kernel format.

Signed-off-by: Christophe Lyon <christophe.lyon@linaro.org>


On 29 March 2013 15:44, Peter Maydell <peter.maydell@linaro.org> wrote:
> On 29 March 2013 14:33, Christophe Lyon <christophe.lyon@linaro.org> wrote:
>> Hi,
>> May I ping for this small patch?
>
> Hi Christophe; I'm afraid the patch can't be applied because it's
> missing a signed-off by. (Also if it was sent inline in the usual
> format rather than as an attachment it would be easier to review.)
>
> thanks
> -- PMM
Eric Blake - March 29, 2013, 3:18 p.m.
On 03/29/2013 09:13 AM, Christophe Lyon wrote:
> Hi,
> 
> Sorry I wasn't aware of such restrictions (I'm used to gcc/binutils
> conventions), and my thunderbird does display my patch as if it were
> inline :-)
> So.... trying a cut-and-paste approach in gmail, for this one character patch:

Still not ideal.  The commentary above should not be part of the final
commit message, so you should move it...

> 
> 
> /proc/self/maps: Add a space at end of line when there is no filename
> to print, to conform to linux kernel format.
> 
> Signed-off-by: Christophe Lyon <christophe.lyon@linaro.org>

...here, after a --- line that tells 'git am' where to stop reading
commit message.  'git send-email' is your friend.  Then whether or not
you use 'git send-email', it is always wise to test if your patch is
usable by first sending it to yourself, and seeing if 'git am' will do
the right thing with it.

http://wiki.qemu.org/Contribute/SubmitAPatch has more hints.

Patch

diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index a148d9f..3b0ca86 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -5016,7 +5016,7 @@  static int open_self_maps(void *cpu_env, int fd)
                     " %c%c%c%c %08" PRIx64 " %02x:%02x %d%s%s\n",
                     h2g(min), h2g(max), flag_r, flag_w,
                     flag_x, flag_p, offset, dev_maj, dev_min, inode,
-                    path[0] ? "          " : "", path);
+                    path[0] ? "          " : " ", path);
         }
     }