Patchwork [iptables] nfnl_osf: use the right nfnetlink lib

login
register
mail settings
Submitter Nicolas Dichtel
Date March 29, 2013, 2:21 p.m.
Message ID <1364566870-7320-1-git-send-email-nicolas.dichtel@6wind.com>
Download mbox | patch
Permalink /patch/232433/
State Superseded
Headers show

Comments

Nicolas Dichtel - March 29, 2013, 2:21 p.m.
If the user specify libnfnetlink_LIBS during the configure, we must use it.

Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
---
 utils/Makefile.am | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Jan Engelhardt - March 29, 2013, 3:20 p.m.
On Friday 2013-03-29 15:21, Nicolas Dichtel wrote:

>If the user specify libnfnetlink_LIBS during the configure, we must use it.
>
>Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
>---
> utils/Makefile.am | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/utils/Makefile.am b/utils/Makefile.am
>index f1bbfc5..8a85396 100644
>--- a/utils/Makefile.am
>+++ b/utils/Makefile.am
>@@ -7,4 +7,4 @@ AM_CPPFLAGS = ${regular_CPPFLAGS} -I${top_builddir}/include \
> sbin_PROGRAMS = nfnl_osf
> pkgdata_DATA = pf.os
> 
>-nfnl_osf_LDADD = -lnfnetlink
>+nfnl_osf_LDADD = ${libnfnetlink_LIBS} -lnfnetlink

You really should remove -lnfnetlink :)
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Nicolas Dichtel - April 2, 2013, 2:38 p.m.
Le 29/03/2013 16:20, Jan Engelhardt a écrit :
> On Friday 2013-03-29 15:21, Nicolas Dichtel wrote:
>
>> If the user specify libnfnetlink_LIBS during the configure, we must use it.
>>
>> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
>> ---
>> utils/Makefile.am | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/utils/Makefile.am b/utils/Makefile.am
>> index f1bbfc5..8a85396 100644
>> --- a/utils/Makefile.am
>> +++ b/utils/Makefile.am
>> @@ -7,4 +7,4 @@ AM_CPPFLAGS = ${regular_CPPFLAGS} -I${top_builddir}/include \
>> sbin_PROGRAMS = nfnl_osf
>> pkgdata_DATA = pf.os
>>
>> -nfnl_osf_LDADD = -lnfnetlink
>> +nfnl_osf_LDADD = ${libnfnetlink_LIBS} -lnfnetlink
>
> You really should remove -lnfnetlink :)
>
Not sure to understand your comment. ${libnfnetlink_LIBS} contains only 
something like '-L/path/to/my/lib'.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jan Engelhardt - April 3, 2013, 2:17 a.m.
On Tuesday 2013-04-02 16:38, Nicolas Dichtel wrote:

>>> @@ -7,4 +7,4 @@ AM_CPPFLAGS = ${regular_CPPFLAGS} -I${top_builddir}/include \
>>> sbin_PROGRAMS = nfnl_osf
>>> pkgdata_DATA = pf.os
>>>
>>> -nfnl_osf_LDADD = -lnfnetlink
>>> +nfnl_osf_LDADD = ${libnfnetlink_LIBS} -lnfnetlink
>>
>> You really should remove -lnfnetlink :)
>>
> Not sure to understand your comment. ${libnfnetlink_LIBS} contains only
> something like '-L/path/to/my/lib'.


	pkg-config libnfnetlink --libs

should definitely return at least an -l argument. If not, the .pc file 
is buggy.
This is what the Libs line should look like:


# libnfnetlink pkg-config file

prefix=/usr
exec_prefix=/usr
libdir=/usr/lib64
includedir=/usr/include/libnfnetlink-1.0.1

Name: libnfnetlink
Description: Low-level netfilter netlink communication library
URL: http://netfilter.org/projects/libnfnetlink/
Version: 1.0.1
Requires:
Conflicts:
Libs: -L${libdir} -lnfnetlink
Cflags: -I${includedir}
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/utils/Makefile.am b/utils/Makefile.am
index f1bbfc5..8a85396 100644
--- a/utils/Makefile.am
+++ b/utils/Makefile.am
@@ -7,4 +7,4 @@  AM_CPPFLAGS = ${regular_CPPFLAGS} -I${top_builddir}/include \
 sbin_PROGRAMS = nfnl_osf
 pkgdata_DATA = pf.os
 
-nfnl_osf_LDADD = -lnfnetlink
+nfnl_osf_LDADD = ${libnfnetlink_LIBS} -lnfnetlink