From patchwork Mon Feb 16 14:02:04 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: roel kluin X-Patchwork-Id: 23220 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 9DD9CDDDF3 for ; Tue, 17 Feb 2009 01:02:15 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756320AbZBPOCK (ORCPT ); Mon, 16 Feb 2009 09:02:10 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755535AbZBPOCI (ORCPT ); Mon, 16 Feb 2009 09:02:08 -0500 Received: from mail-fx0-f20.google.com ([209.85.220.20]:44743 "EHLO mail-fx0-f20.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755087AbZBPOCH (ORCPT ); Mon, 16 Feb 2009 09:02:07 -0500 Received: by fxm13 with SMTP id 13so5842857fxm.13 for ; Mon, 16 Feb 2009 06:02:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:cc:subject:content-type :content-transfer-encoding; bh=n7DydAVLxi4EbxslTMTrev9iBcBm6IFddccUMO26WmI=; b=TXMTdT/zLZD7NZrm92k9I0hsv/XBn0xS6sAimpjQXs8SD5paFCVDrdC3Ziqi6bZ6fk J2epimxUcxxAxQFIFLzJ3QEvXcMsWyzisU8jIavmZExRCS9D18oM3/nsvTyIu3/HVivP Rbnm4i6gK/kWF5YCdvjQOPIcocrOwJETF5dws= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :content-type:content-transfer-encoding; b=Ir9uPdV+D7tBCqCEMyfJkwDktyQDNE4A0VmuxckkI61ZKKX24BiwhXl895ROvaQdC7 xnMe/zhRJIPF8jt53EqRQ3z1IGnA3pV2zGgXX61fBJ6ps1WllfLuWZASDUrIN7jVeig8 MHPVIuEc7/sTw3rF1IR6UIGR/ORUBa44uusOo= Received: by 10.223.117.1 with SMTP id o1mr1466819faq.96.1234792925204; Mon, 16 Feb 2009 06:02:05 -0800 (PST) Received: from ?192.168.1.115? (d133062.upc-d.chello.nl [213.46.133.62]) by mx.google.com with ESMTPS id h6sm3209974nfh.15.2009.02.16.06.02.04 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 16 Feb 2009 06:02:04 -0800 (PST) Message-ID: <499971DC.4070406@gmail.com> Date: Mon, 16 Feb 2009 15:02:04 +0100 From: Roel Kluin User-Agent: Thunderbird 2.0.0.18 (X11/20081105) MIME-Version: 1.0 To: "David S. Miller" CC: Daniel Walker , netdev@vger.kernel.org, Andrew Morton Subject: [PATCH] sungem: another error printed one too early Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Another error was printed one too early. Signed-off-by: Roel Kluin --- -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/sungem.c b/drivers/net/sungem.c index 4918763..8d64b1d 100644 --- a/drivers/net/sungem.c +++ b/drivers/net/sungem.c @@ -1157,7 +1157,7 @@ static void gem_pcs_reset(struct gem *gp) if (limit-- <= 0) break; } - if (limit <= 0) + if (limit < 0) printk(KERN_WARNING "%s: PCS reset bit would not clear.\n", gp->dev->name); }