Patchwork [04/23] qcow2: Remove bogus unlock of s->lock

login
register
mail settings
Submitter Stefan Hajnoczi
Date March 28, 2013, 4:40 p.m.
Message ID <1364488837-15916-5-git-send-email-stefanha@redhat.com>
Download mbox | patch
Permalink /patch/232108/
State New
Headers show

Comments

Stefan Hajnoczi - March 28, 2013, 4:40 p.m.
From: Kevin Wolf <kwolf@redhat.com>

The unlock wakes up the next coroutine, but the currently running
coroutine will lock it again before it yields, so this doesn't make a
lot of sense.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 block/qcow2.c | 2 --
 1 file changed, 2 deletions(-)

Patch

diff --git a/block/qcow2.c b/block/qcow2.c
index 8ea696a..3f7edf5 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -869,9 +869,7 @@  static coroutine_fn int qcow2_co_writev(BlockDriverState *bs,
                 QLIST_REMOVE(l2meta, next_in_flight);
             }
 
-            qemu_co_mutex_unlock(&s->lock);
             qemu_co_queue_restart_all(&l2meta->dependent_requests);
-            qemu_co_mutex_lock(&s->lock);
 
             g_free(l2meta);
             l2meta = NULL;