From patchwork Sun Feb 15 16:07:12 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: roel kluin X-Patchwork-Id: 23197 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id DF6EBDDDA2 for ; Mon, 16 Feb 2009 03:07:21 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752717AbZBOQHR (ORCPT ); Sun, 15 Feb 2009 11:07:17 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752694AbZBOQHQ (ORCPT ); Sun, 15 Feb 2009 11:07:16 -0500 Received: from nf-out-0910.google.com ([64.233.182.184]:44697 "EHLO nf-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752654AbZBOQHO (ORCPT ); Sun, 15 Feb 2009 11:07:14 -0500 Received: by nf-out-0910.google.com with SMTP id d21so174495nfb.21 for ; Sun, 15 Feb 2009 08:07:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:cc:subject:content-type :content-transfer-encoding; bh=+FFEuaem6uLm86K2tTkITeZlOVh4BMeuW5rG+Flp0Nc=; b=xm0jWMmOIyuUuNxKM+i6DrpViFhxvhzv3YoWidkiACH58LYf8QKb+fzRUJZxjkpUIG 6wdtQyoRObm5WEfhk6kh9l83LWKQJNTgoSlrHKu8O6u6WKH2O/wtouIqotqzr6rB3Wzp QjgpPv6QL1kS/0GCXMwCgkLoIDFnN8IZuGWUs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :content-type:content-transfer-encoding; b=S0vsjdcyQ3muXgITyKMjTZt63E1Z5CC5lyosygdPrVCSVDtMSc1aakD8z9oc+yzDTF eGLIHF7bGjirjxZBYSusYntYOCLSm9FjX4Xc7RV3pIuerk/6pX4JnhYhIsGf/aQ/GhJw 3ptPAdX5zRy62vTvpMfEnWKQbRVbyEy8qFMtg= Received: by 10.210.59.3 with SMTP id h3mr1851099eba.106.1234714033195; Sun, 15 Feb 2009 08:07:13 -0800 (PST) Received: from ?192.168.1.115? (d133062.upc-d.chello.nl [213.46.133.62]) by mx.google.com with ESMTPS id 7sm11156071eyg.47.2009.02.15.08.07.12 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sun, 15 Feb 2009 08:07:12 -0800 (PST) Message-ID: <49983DB0.6040008@gmail.com> Date: Sun, 15 Feb 2009 17:07:12 +0100 From: Roel Kluin User-Agent: Thunderbird 2.0.0.18 (X11/20081105) MIME-Version: 1.0 To: chas@cmf.nrl.navy.mil CC: netdev@vger.kernel.org, Andrew Morton Subject: [PATCH] ATM: misplaced parentheses? Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org I think below is what was intended? otherwise we could as well have written: tmp = (lanai->conf1 & ~CONFIG1_PROMDATA) || (data & i) ? CONFIG1_PROMDATA : 0; Does this fix the parsing of the EEPROM? please review. -------------------------->8------------------8<--------------------------- Fix misplaced parentheses Signed-off-by: Roel Kluin --- -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/atm/lanai.c b/drivers/atm/lanai.c index 144a49f..317fb5a 100644 --- a/drivers/atm/lanai.c +++ b/drivers/atm/lanai.c @@ -901,7 +901,7 @@ static int __devinit eeprom_read(struct lanai_dev *lanai) clock_l(); udelay(5); for (i = 128; i != 0; i >>= 1) { /* write command out */ tmp = (lanai->conf1 & ~CONFIG1_PROMDATA) | - (data & i) ? CONFIG1_PROMDATA : 0; + (data & i ? CONFIG1_PROMDATA : 0); if (lanai->conf1 != tmp) { set_config1(tmp); udelay(5); /* Let new data settle */