From patchwork Thu Mar 28 08:39:08 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 231933 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-pb0-f55.google.com (mail-pb0-f55.google.com [209.85.160.55]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id EB94D2C00B0 for ; Thu, 28 Mar 2013 19:39:12 +1100 (EST) Received: by mail-pb0-f55.google.com with SMTP id uo1sf1058302pbc.20 for ; Thu, 28 Mar 2013 01:39:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:received-spf:x-auditid:from:to:cc :references:in-reply-to:subject:date:message-id:mime-version :x-mailer:thread-index:x-brightmail-tracker:x-brightmail-tracker :dlp-filter:x-mtr:x-cfilter-loop:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:x-google-group-id:list-post:list-help:list-archive:sender :list-subscribe:list-unsubscribe:content-type:content-language; bh=vzoymOByBQZ0j81gh3ce7hSj9K/kumVP2CY8tm0mPMo=; b=LS9BzbBXpL/1SI/CYmVMK0pZEeNkKGm1oi6sUMdXNLPtzgXHcDm6ReQmvAhNi3wLgr r99MjMIFw4Ms7sM8VNLakNj0GUwsNxu3ZeQ6s1ZRsR/7/QCeBcGMKE1abA0r27X9D8Yo oY0KH9QjrX14Nf0IUBw5yBulPHtZ1LYirtbCuBfCyuRaAxMNDqqBmuFAaly9grTJPyPF 44sGQMLbT/RYtGtrPa50k4JJaJl8xYm2rVcm4wE/X75gN4fbWnq6N8zcqke+i6CzHF7B ZFlK6Bh1QYBc7K5doFUqVOHFJ3m3+cc7gViNLPob5pNsEW3b+n5vFrDqhTsYFlcQJF6O G7AQ== X-Received: by 10.50.135.10 with SMTP id po10mr1806478igb.4.1364459950621; Thu, 28 Mar 2013 01:39:10 -0700 (PDT) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.6.163 with SMTP id c3ls1440922iga.37.canary; Thu, 28 Mar 2013 01:39:10 -0700 (PDT) X-Received: by 10.68.136.104 with SMTP id pz8mr3185536pbb.3.1364459950337; Thu, 28 Mar 2013 01:39:10 -0700 (PDT) Received: from mailout3.samsung.com (mailout3.samsung.com. [203.254.224.33]) by gmr-mx.google.com with ESMTP id cu1si3937185pbc.1.2013.03.28.01.39.10; Thu, 28 Mar 2013 01:39:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.33 as permitted sender) client-ip=203.254.224.33; Received: from epcpsbgr1.samsung.com (u141.gpu120.samsung.co.kr [203.254.230.141]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MKD00G5U40W4J30@mailout3.samsung.com> for rtc-linux@googlegroups.com; Thu, 28 Mar 2013 17:39:09 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.50]) by epcpsbgr1.samsung.com (EPCPMTA) with SMTP id 39.77.20872.DA104515; Thu, 28 Mar 2013 17:39:09 +0900 (KST) X-AuditID: cbfee68d-b7f786d000005188-dd-515401adafee Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id C3.13.17838.DA104515; Thu, 28 Mar 2013 17:39:09 +0900 (KST) Received: from DOJG1HAN02 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MKD007DS418RS40@mmp2.samsung.com>; Thu, 28 Mar 2013 17:39:08 +0900 (KST) From: Jingoo Han To: 'Andrew Morton' Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' , rtc-linux@googlegroups.com, 'Jingoo Han' References: <001001ce2b8f$61824c90$2486e5b0$%han@samsung.com> In-reply-to: <001001ce2b8f$61824c90$2486e5b0$%han@samsung.com> Subject: [rtc-linux] [PATCH 6/8] rtc: rtc-spear: convert spear_rtc_driver to dev_pm_ops Date: Thu, 28 Mar 2013 17:39:08 +0900 Message-id: <001501ce2b8f$b6e39950$24aacbf0$%han@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac4rj2FhCGvCEF7CQ36UwoHUUgpQOwAAEY4A X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrGIsWRmVeSWpSXmKPExsVy+t8zI921jCGBBps/CFosuXiV3WLO+jVs FpcXXmK1uLxrDpvF/s4ORgdWjz0TT7J5nJjxm8Wjb8sqRo/p834yeXzeJBfAGsVlk5Kak1mW WqRvl8CVMWnWMaaCJQIV957ENTBe4O1i5OSQEDCReLzvMguELSZx4d56ti5GLg4hgWWMEjsb zrLBFM37sY4dIjGdUWLXgvXMIAkhgV+MEi2d+iA2m4CaxJcvh4GKODhEBPQl2lo0QOqZBXoZ Jc707maHqLeVOHf4Klgvp4CdRPuarWCbhQW8JQ69esQKYrMIqEp8e34fLM4LVL/8ax87hC0o 8WPyPbA4s4CWxPqdx5kgbHmJzWveMoPslRBQl3j0VxckLCJgJPHl7jc2iBIRiX0v3jGC3CMh cI9d4lbzFyaIXQIS3yYfYoHolZXYdIAZ4l9JiYMrbrBMYJSYhWTzLCSbZyHZPAvJigWMLKsY RVMLkguKk9KLDPWKE3OLS/PS9ZLzczcxQuK0dwfj7QPWhxiTgdZPZJYSTc4HxnleSbyhsZmR hamJqbGRuaUZacJK4rxqLdaBQgLpiSWp2ampBalF8UWlOanFhxiZODilGhgPFrBFGVSsm8tR MnN964WOWsE2J6OL17NtjlSte9K3ava9lJLpZXIcWb8rrjon3Xq38Oy9F7Lf4hpeMHe9Cjq/ +aekW4+gzN7KHWeOheRNsGcyvy19NjtpzrLdi7nVr4QpTH5eU6B6nt9heuf7cwsuaVzxamic HC159FTXJ+YdZ0P6utR4JnApsRRnJBpqMRcVJwIA9bGMSekCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrMKsWRmVeSWpSXmKPExsVy+t9jQd21jCGBBovP8losuXiV3WLO+jVs FpcXXmK1uLxrDpvF/s4ORgdWjz0TT7J5nJjxm8Wjb8sqRo/p834yeXzeJBfAGtXAaJORmpiS WqSQmpecn5KZl26r5B0c7xxvamZgqGtoaWGupJCXmJtqq+TiE6DrlpkDtF1JoSwxpxQoFJBY XKykb4dpQmiIm64FTGOErm9IEFyPkQEaSFjHmDFp1jGmgiUCFfeexDUwXuDtYuTkkBAwkZj3 Yx07hC0mceHeerYuRi4OIYHpjBK7FqxnBkkICfxilGjp1Aex2QTUJL58OQzUwMEhIqAv0dai AVLPLNDLKHGmdzc7RL2txLnDV8F6OQXsJNrXbGUBsYUFvCUOvXrECmKzCKhKfHt+HyzOC1S/ /GsfO4QtKPFj8j2wOLOAlsT6nceZIGx5ic1r3jKD7JUQUJd49FcXJCwiYCTx5e43NogSEYl9 L94xTmAUmoVk0iwkk2YhmTQLScsCRpZVjKKpBckFxUnpuYZ6xYm5xaV56XrJ+bmbGMFJ4JnU DsaVDRaHGAU4GJV4eCsEggOFWBPLiitzDzFKcDArifAe6gQK8aYkVlalFuXHF5XmpBYfYkwG enQis5Rocj4wQeWVxBsam5gZWRqZWRiZmJuTJqwkznug1TpQSCA9sSQ1OzW1ILUIZgsTB6dU A+Pue5ss17Pe5ppi+ZtLraxhafg8F/bbT84vZqoTvVuo/Sa1/0Gz9+u1fh9aDvF+ETEQaHep zHrd67Ap+PmtbbuPC+3P380jWvjKS13pzatJDFM7lr3bJDYpxtba8exV6enTzuyyP3kg7ccx h+bcJ+I2ITPVfLbrxdi3LozbWlzeZuuUsbhrxSQlluKMREMt5qLiRAC1FBl6RgMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.33 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-type: text/plain; charset=ISO-8859-1 Content-language: ko Instead of using legacy suspend/resume methods, using newer dev_pm_ops structure allows better control over power management. Signed-off-by: Jingoo Han Acked-by: Viresh Kumar --- drivers/rtc/rtc-spear.c | 18 ++++++++---------- 1 files changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers/rtc/rtc-spear.c b/drivers/rtc/rtc-spear.c index db3ef61..574359c 100644 --- a/drivers/rtc/rtc-spear.c +++ b/drivers/rtc/rtc-spear.c @@ -434,10 +434,10 @@ static int spear_rtc_remove(struct platform_device *pdev) return 0; } -#ifdef CONFIG_PM - -static int spear_rtc_suspend(struct platform_device *pdev, pm_message_t state) +#ifdef CONFIG_PM_SLEEP +static int spear_rtc_suspend(struct device *dev) { + struct platform_device *pdev = to_platform_device(dev); struct spear_rtc_config *config = platform_get_drvdata(pdev); int irq; @@ -453,8 +453,9 @@ static int spear_rtc_suspend(struct platform_device *pdev, pm_message_t state) return 0; } -static int spear_rtc_resume(struct platform_device *pdev) +static int spear_rtc_resume(struct device *dev) { + struct platform_device *pdev = to_platform_device(dev); struct spear_rtc_config *config = platform_get_drvdata(pdev); int irq; @@ -472,12 +473,10 @@ static int spear_rtc_resume(struct platform_device *pdev) return 0; } - -#else -#define spear_rtc_suspend NULL -#define spear_rtc_resume NULL #endif +static SIMPLE_DEV_PM_OPS(spear_rtc_pm_ops, spear_rtc_suspend, spear_rtc_resume); + static void spear_rtc_shutdown(struct platform_device *pdev) { struct spear_rtc_config *config = platform_get_drvdata(pdev); @@ -497,11 +496,10 @@ MODULE_DEVICE_TABLE(of, spear_rtc_id_table); static struct platform_driver spear_rtc_driver = { .probe = spear_rtc_probe, .remove = spear_rtc_remove, - .suspend = spear_rtc_suspend, - .resume = spear_rtc_resume, .shutdown = spear_rtc_shutdown, .driver = { .name = "rtc-spear", + .pm = &spear_rtc_pm_ops, .of_match_table = of_match_ptr(spear_rtc_id_table), }, };