Patchwork [v15.2,4/6] pvpanic: add document of pvpanic

login
register
mail settings
Submitter Hu Tao
Date March 28, 2013, 6:16 a.m.
Message ID <1364451363-25763-1-git-send-email-hutao@cn.fujitsu.com>
Download mbox | patch
Permalink /patch/231908/
State New
Headers show

Comments

Hu Tao - March 28, 2013, 6:16 a.m.
Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>
---
 docs/specs/pvpanic.txt | 37 +++++++++++++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)
 create mode 100644 docs/specs/pvpanic.txt
Eric Blake - March 28, 2013, 12:16 p.m.
On 03/28/2013 12:16 AM, Hu Tao wrote:
> Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>
> ---
>  docs/specs/pvpanic.txt | 37 +++++++++++++++++++++++++++++++++++++
>  1 file changed, 37 insertions(+)
>  create mode 100644 docs/specs/pvpanic.txt

One typo remaining:

> +ACPI Interface
> +--------------
> +
> +pvpanic device is defined with ACPI ID "QEMU0001". Custom methods:
> +
> +RDPT:       To determine whether guest panic notification is supported.
> +Rrguments:  None

s/Rrguments/Arguments/

I think that can be fixed by whoever merges and sends the pull request,
without needing you to do a respin.  With that fixed, you have:

Reviewed-by: Eric Blake <eblake@redhat.com>
Paolo Bonzini - March 28, 2013, 2:57 p.m.
----- Messaggio originale -----
> Da: "Eric Blake" <eblake@redhat.com>
> A: "Hu Tao" <hutao@cn.fujitsu.com>
> Cc: "qemu-devel" <qemu-devel@nongnu.org>, "Paolo Bonzini" <pbonzini@redhat.com>
> Inviato: Giovedì, 28 marzo 2013 13:16:32
> Oggetto: Re: [PATCH v15.2 4/6] pvpanic: add document of pvpanic
> 
> On 03/28/2013 12:16 AM, Hu Tao wrote:
> > Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>
> > ---
> >  docs/specs/pvpanic.txt | 37 +++++++++++++++++++++++++++++++++++++
> >  1 file changed, 37 insertions(+)
> >  create mode 100644 docs/specs/pvpanic.txt
> 
> One typo remaining:
> 
> > +ACPI Interface
> > +--------------
> > +
> > +pvpanic device is defined with ACPI ID "QEMU0001". Custom methods:
> > +
> > +RDPT:       To determine whether guest panic notification is
> > supported.
> > +Rrguments:  None
> 
> s/Rrguments/Arguments/
> 
> I think that can be fixed by whoever merges and sends the pull
> request,
> without needing you to do a respin.  With that fixed, you have:
> 
> Reviewed-by: Eric Blake <eblake@redhat.com>

Hu, please repost the whole series as v16.  Simpler. :)

Paolo
Hu Tao - March 29, 2013, 7:12 a.m.
On Thu, Mar 28, 2013 at 06:16:32AM -0600, Eric Blake wrote:
> On 03/28/2013 12:16 AM, Hu Tao wrote:
> > Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>
> > ---
> >  docs/specs/pvpanic.txt | 37 +++++++++++++++++++++++++++++++++++++
> >  1 file changed, 37 insertions(+)
> >  create mode 100644 docs/specs/pvpanic.txt
> 
> One typo remaining:
> 
> > +ACPI Interface
> > +--------------
> > +
> > +pvpanic device is defined with ACPI ID "QEMU0001". Custom methods:
> > +
> > +RDPT:       To determine whether guest panic notification is supported.
> > +Rrguments:  None
> 
> s/Rrguments/Arguments/
> 
> I think that can be fixed by whoever merges and sends the pull request,
> without needing you to do a respin.  With that fixed, you have:
> 
> Reviewed-by: Eric Blake <eblake@redhat.com>

Thanks for review!
Hu Tao - March 29, 2013, 7:15 a.m.
On Thu, Mar 28, 2013 at 10:57:57AM -0400, Paolo Bonzini wrote:
> 
> 
> ----- Messaggio originale -----
> > Da: "Eric Blake" <eblake@redhat.com>
> > A: "Hu Tao" <hutao@cn.fujitsu.com>
> > Cc: "qemu-devel" <qemu-devel@nongnu.org>, "Paolo Bonzini" <pbonzini@redhat.com>
> > Inviato: Giovedì, 28 marzo 2013 13:16:32
> > Oggetto: Re: [PATCH v15.2 4/6] pvpanic: add document of pvpanic
> > 
> > On 03/28/2013 12:16 AM, Hu Tao wrote:
> > > Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>
> > > ---
> > >  docs/specs/pvpanic.txt | 37 +++++++++++++++++++++++++++++++++++++
> > >  1 file changed, 37 insertions(+)
> > >  create mode 100644 docs/specs/pvpanic.txt
> > 
> > One typo remaining:
> > 
> > > +ACPI Interface
> > > +--------------
> > > +
> > > +pvpanic device is defined with ACPI ID "QEMU0001". Custom methods:
> > > +
> > > +RDPT:       To determine whether guest panic notification is
> > > supported.
> > > +Rrguments:  None
> > 
> > s/Rrguments/Arguments/
> > 
> > I think that can be fixed by whoever merges and sends the pull
> > request,
> > without needing you to do a respin.  With that fixed, you have:
> > 
> > Reviewed-by: Eric Blake <eblake@redhat.com>
> 
> Hu, please repost the whole series as v16.  Simpler. :)

No problem :)

Patch

diff --git a/docs/specs/pvpanic.txt b/docs/specs/pvpanic.txt
new file mode 100644
index 0000000..6fe8bb6
--- /dev/null
+++ b/docs/specs/pvpanic.txt
@@ -0,0 +1,37 @@ 
+PVPANIC DEVICE
+==============
+
+pvpanic device is a simulated ISA device, through which a guest panic
+event is sent to qemu, and a QMP event is generated. This allows
+management apps (e.g. libvirt) to be notified and respond to the event.
+
+The management app has the option of waiting for GUEST_PANICKED events,
+and/or polling for guest-panicked RunState, to learn when the pvpanic
+device has fired a panic event.
+
+ISA Interface
+-------------
+
+pvpanic uses port 0x505 to receive a panic event from the guest. On
+write, bit 0 is set to indicate guest panic has happened. On read, bit
+0 is set to indicate guest panic notification is supported. Remaining
+bits are reserved, and should be written as 0, and ignored on read.
+
+ACPI Interface
+--------------
+
+pvpanic device is defined with ACPI ID "QEMU0001". Custom methods:
+
+RDPT:       To determine whether guest panic notification is supported.
+Rrguments:  None
+Return:     Returns a byte, bit 0 set to indicate guest panic
+            notification is supported. Other bits are reserved and
+            should be ignored.
+
+WRPT:       To send a guest panic event
+Arguments:  Arg0 is a byte, with bit 0 set to indicate guest panic has
+            happened. Other bits are reserved and should be cleared.
+Return:     None
+
+The ACPI device will automatically refer to the right port in case it
+is modified.