| Message ID | 1364388077-30480-1-git-send-email-honkiko@gmail.com |
|---|---|
| State | Awaiting Upstream, archived |
| Delegated to: | David Miller |
| Headers | show |
On Wed, Mar 27, 2013 at 5:41 AM, Hong Zhiguo <honkiko@gmail.com> wrote: > table->count is uint32_t > > Signed-off-by: Hong Zhiguo <honkiko@gmail.com> Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Thanks for your review comments. I re-patched according to your comments. Please help to review it. Thanks. On Wed, Mar 27, 2013 at 11:19 PM, Jesse Gross <jesse@nicira.com> wrote: > On Wed, Mar 27, 2013 at 5:41 AM, Hong Zhiguo <honkiko@gmail.com> wrote: >> table->count is uint32_t >> >> Signed-off-by: Hong Zhiguo <honkiko@gmail.com> > > Applied, thanks.
diff --git a/net/openvswitch/flow.c b/net/openvswitch/flow.c index fe0e421..67a2b78 100644 --- a/net/openvswitch/flow.c +++ b/net/openvswitch/flow.c @@ -795,9 +795,9 @@ void ovs_flow_tbl_insert(struct flow_table *table, struct sw_flow *flow) void ovs_flow_tbl_remove(struct flow_table *table, struct sw_flow *flow) { + BUG_ON(table->count == 0); hlist_del_rcu(&flow->hash_node[table->node_ver]); table->count--; - BUG_ON(table->count < 0); } /* The size of the argument for each %OVS_KEY_ATTR_* Netlink attribute. */
table->count is uint32_t Signed-off-by: Hong Zhiguo <honkiko@gmail.com> --- net/openvswitch/flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)