Message ID | 1364375482-7439-1-git-send-email-jasowang@redhat.com |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
On Wed, 2013-03-27 at 17:11 +0800, Jason Wang wrote: > For untrusted packets with partial checksum, we need to set the transport header > for precise packet length estimation. We can just let skb_pratial_csum_set() to > do this to avoid extra call to skb_flow_dissect() and simplify the caller. > > Cc: Eric Dumazet <edumazet@google.com> > Signed-off-by: Jason Wang <jasowang@redhat.com> > --- > net/core/skbuff.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/net/core/skbuff.c b/net/core/skbuff.c > index 31c6737..ba64614 100644 > --- a/net/core/skbuff.c > +++ b/net/core/skbuff.c > @@ -3370,6 +3370,7 @@ bool skb_partial_csum_set(struct sk_buff *skb, u16 start, u16 off) > skb->ip_summed = CHECKSUM_PARTIAL; > skb->csum_start = skb_headroom(skb) + start; > skb->csum_offset = off; > + skb_set_transport_header(skb, start); > return true; > } > EXPORT_SYMBOL_GPL(skb_partial_csum_set); Acked-by: Eric Dumazet <edumazet@google.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Eric Dumazet <eric.dumazet@gmail.com> Date: Wed, 27 Mar 2013 07:42:56 -0700 > On Wed, 2013-03-27 at 17:11 +0800, Jason Wang wrote: >> For untrusted packets with partial checksum, we need to set the transport header >> for precise packet length estimation. We can just let skb_pratial_csum_set() to >> do this to avoid extra call to skb_flow_dissect() and simplify the caller. >> >> Cc: Eric Dumazet <edumazet@google.com> >> Signed-off-by: Jason Wang <jasowang@redhat.com> >> --- >> net/core/skbuff.c | 1 + >> 1 files changed, 1 insertions(+), 0 deletions(-) >> >> diff --git a/net/core/skbuff.c b/net/core/skbuff.c >> index 31c6737..ba64614 100644 >> --- a/net/core/skbuff.c >> +++ b/net/core/skbuff.c >> @@ -3370,6 +3370,7 @@ bool skb_partial_csum_set(struct sk_buff *skb, u16 start, u16 off) >> skb->ip_summed = CHECKSUM_PARTIAL; >> skb->csum_start = skb_headroom(skb) + start; >> skb->csum_offset = off; >> + skb_set_transport_header(skb, start); >> return true; >> } >> EXPORT_SYMBOL_GPL(skb_partial_csum_set); > > Acked-by: Eric Dumazet <edumazet@google.com> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/core/skbuff.c b/net/core/skbuff.c index 31c6737..ba64614 100644 --- a/net/core/skbuff.c +++ b/net/core/skbuff.c @@ -3370,6 +3370,7 @@ bool skb_partial_csum_set(struct sk_buff *skb, u16 start, u16 off) skb->ip_summed = CHECKSUM_PARTIAL; skb->csum_start = skb_headroom(skb) + start; skb->csum_offset = off; + skb_set_transport_header(skb, start); return true; } EXPORT_SYMBOL_GPL(skb_partial_csum_set);
For untrusted packets with partial checksum, we need to set the transport header for precise packet length estimation. We can just let skb_pratial_csum_set() to do this to avoid extra call to skb_flow_dissect() and simplify the caller. Cc: Eric Dumazet <edumazet@google.com> Signed-off-by: Jason Wang <jasowang@redhat.com> --- net/core/skbuff.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)