Patchwork Qemu-devel Digest, Vol 120, Issue 887

login
register
mail settings
Submitter Haitham Zuriq
Date March 27, 2013, 8:13 a.m.
Message ID <2qyt69d0ffo7mg8k0ypaqeii.1364371990950@email.android.com>
Download mbox | patch
Permalink /patch/231606/
State New
Headers show

Comments

Haitham Zuriq - March 27, 2013, 8:13 a.m.
Sent from Samsung tablet

-------- Original message --------
From: qemu-devel-request@nongnu.org 
Date: 27/03/2013  9:12 AM  (GMT+03:00) 
To: qemu-devel@nongnu.org 
Subject: Qemu-devel Digest, Vol 120, Issue 887 
 
Send Qemu-devel mailing list submissions to
qemu-devel@nongnu.org

To subscribe or unsubscribe via the World Wide Web, visit
https://lists.nongnu.org/mailman/listinfo/qemu-devel
or, via email, send a message with subject or body 'help' to
qemu-devel-request@nongnu.org

You can reach the person managing the list at
qemu-devel-owner@nongnu.org

When replying, please edit your Subject line so it is more specific
than "Re: Contents of Qemu-devel digest..."


Today's Topics:

   1. Re: coroutine: hung when using gthread backend (Wenchao Xia)
   2. Re: [RFC PATCH v4 00/30] ACPI memory hotplug (li guang)
   3. Re: [RFC PATCH v4 00/30] ACPI memory hotplug (li guang)
   4. Re: [RFC] qmp interface for save vmstate to image (Wenchao Xia)
   5. [Bug 1158912] Re: QEMU Version 1.4.0 - SLIRP hangs VM
      (Kenneth Salerno)
   6. [PATCH] hw/i386/pc: reject to boot a wrong header	magic
      kernel (liguang)


----------------------------------------------------------------------

Message: 1
Date: Wed, 27 Mar 2013 10:11:57 +0800
From: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Stefan Hajnoczi <stefanha@gmail.com>, qemu-devel
<qemu-devel@nongnu.org>,	Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] coroutine: hung when using gthread backend
Message-ID: <5152556D.4050900@linux.vnet.ibm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed

? 2013-3-26 17:56, Peter Maydell ??:
> On 26 March 2013 09:54, Stefan Hajnoczi <stefanha@gmail.com> wrote:
>> On Tue, Mar 26, 2013 at 08:03:50AM +0100, Paolo Bonzini wrote:
>>> coroutine backend gthread hardly works for qemu, only qemu-io and qemu-img.
>>
>> Do you know why it doesn't work?
>
> Because nobody tests it?
>
> -- PMM
>
   It is not enabled by default in configure, so missed in tests. I feel
a full regression test suit covering different configure case is
missing.

Patch

diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index b1e06fa..2b78dfc 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -683,8 +683,10 @@  static void load_linux(void *fw_cfg,
         if (load_multiboot(fw_cfg, f, kernel_filename, initrd_filename,
                            kernel_cmdline, kernel_size, header)) {
             return;
+        } else {
+            fprintf(stderr, "please assure specicified kernel is for x86!\n");
+            exit(1);
         }
-        protocol = 0;
     }

     if (protocol < 0x200 || !(header[0x211] & 0x01)) {