Patchwork [Lucid,CVE-2012-6546,1/2] atm: fix info leak via getsockname()

login
register
mail settings
Submitter Luis Henriques
Date March 26, 2013, 5:18 p.m.
Message ID <1364318313-17073-1-git-send-email-luis.henriques@canonical.com>
Download mbox | patch
Permalink /patch/231488/
State New
Headers show

Comments

Luis Henriques - March 26, 2013, 5:18 p.m.
From: Mathias Krause <minipli@googlemail.com>

CVE-2012-6546

BugLink: http://bugs.launchpad.net/bugs/1156759

The ATM code fails to initialize the two padding bytes of struct
sockaddr_atmpvc inserted for alignment. Add an explicit memset(0)
before filling the structure to avoid the info leak.

Signed-off-by: Mathias Krause <minipli@googlemail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
(back ported from commit 3c0c5cfdcd4d69ffc4b9c0907cec99039f30a50a)

Signed-off-by: Luis Henriques <luis.henriques@canonical.com>

Conflicts:
	net/atm/pvc.c
---
 net/atm/pvc.c | 1 +
 1 file changed, 1 insertion(+)
Tim Gardner - March 26, 2013, 5:39 p.m.

Patch

diff --git a/net/atm/pvc.c b/net/atm/pvc.c
index d4c0245..523c21a 100644
--- a/net/atm/pvc.c
+++ b/net/atm/pvc.c
@@ -93,6 +93,7 @@  static int pvc_getname(struct socket *sock,struct sockaddr *sockaddr,
 	if (!vcc->dev || !test_bit(ATM_VF_ADDR,&vcc->flags)) return -ENOTCONN;
 	*sockaddr_len = sizeof(struct sockaddr_atmpvc);
 	addr = (struct sockaddr_atmpvc *) sockaddr;
+	memset(addr, 0, sizeof(*addr));
 	addr->sap_family = AF_ATMPVC;
 	addr->sap_addr.itf = vcc->dev->number;
 	addr->sap_addr.vpi = vcc->vpi;