From patchwork Tue Mar 26 16:38:42 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mirko Lindner X-Patchwork-Id: 231449 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id C5FB92C05E3 for ; Wed, 27 Mar 2013 03:42:00 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933709Ab3CZQl4 (ORCPT ); Tue, 26 Mar 2013 12:41:56 -0400 Received: from na3sys009aog131.obsmtp.com ([74.125.149.247]:50295 "EHLO na3sys009aog131.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754414Ab3CZQlz (ORCPT ); Tue, 26 Mar 2013 12:41:55 -0400 Received: from sc-owa02.marvell.com ([199.233.58.137]) (using TLSv1) by na3sys009aob131.postini.com ([74.125.148.12]) with SMTP ID DSNKUVHP0tfXGUxjxdRSflpBJ2F/RARQjYY6@postini.com; Tue, 26 Mar 2013 09:41:55 PDT Received: from maili.marvell.com (10.93.76.43) by sc-owa02.marvell.com (10.93.76.22) with Microsoft SMTP Server id 8.3.213.0; Tue, 26 Mar 2013 09:38:54 -0700 Received: from mlindner-lin.localnet (unknown [10.9.1.171]) by maili.marvell.com (Postfix) with ESMTP id 00C054E513; Tue, 26 Mar 2013 09:38:43 -0700 (PDT) From: Mirko Lindner To: "davem@davemloft.net" CC: "netdev@vger.kernel.org" , Stephen Hemminger Subject: [PATCH 2/2] sky2: Threshold for Pause Packet is set wrong Date: Tue, 26 Mar 2013 17:38:42 +0100 Message-ID: <1567731.Oea6BC09CI@mlindner-lin> User-Agent: KMail/4.10.1 (Linux/3.4.28-2.20-desktop; KDE/4.10.1; x86_64; ; ) MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The sky2 driver sets the Rx Upper Threshold for Pause Packet generation to a wrong value which leads to only 2kB of RAM remaining space. This can lead to Rx overflow errors even with activated flow-control. Fix: We should increase the value to 8192/8 Signed-off-by: Mirko Lindner --- drivers/net/ethernet/marvell/sky2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/sky2.c b/drivers/net/ethernet/marvell/sky2.c index fc07ca3..6a0e671 100644 --- a/drivers/net/ethernet/marvell/sky2.c +++ b/drivers/net/ethernet/marvell/sky2.c @@ -1067,7 +1067,7 @@ static void sky2_ramset(struct sky2_hw *hw, u16 q, u32 start, u32 space) sky2_write32(hw, RB_ADDR(q, RB_RX_UTHP), tp); sky2_write32(hw, RB_ADDR(q, RB_RX_LTHP), space/2); - tp = space - 2048/8; + tp = space - 8192/8; sky2_write32(hw, RB_ADDR(q, RB_RX_UTPP), tp); sky2_write32(hw, RB_ADDR(q, RB_RX_LTPP), space/4); } else {