Patchwork [PULL,3/4] qmp: fix handling of boolean values in qmp-shell

login
register
mail settings
Submitter Luiz Capitulino
Date March 26, 2013, 12:38 p.m.
Message ID <1364301526-11431-4-git-send-email-lcapitulino@redhat.com>
Download mbox | patch
Permalink /patch/231188/
State New
Headers show

Comments

Luiz Capitulino - March 26, 2013, 12:38 p.m.
From: Igor Mammedov <imammedo@redhat.com>

qmp-shell converts only integer arguments and the rest
is assumed to be strings which are faithfully sent as
quoted strings by json. But QEMU refuses to accept qmp
command with boolean argument whose value is escaped
as string.

Fix it by special-casing true/false keywords and store
value as corresponding boolean.

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
 QMP/qmp-shell | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

Patch

diff --git a/QMP/qmp-shell b/QMP/qmp-shell
index 24b665c..d126e63 100755
--- a/QMP/qmp-shell
+++ b/QMP/qmp-shell
@@ -101,7 +101,12 @@  class QMPShell(qmp.QEMUMonitorProtocol):
             try:
                 value = int(opt[1])
             except ValueError:
-                value = opt[1]
+                if opt[1] == 'true':
+                    value = True
+                elif opt[1] == 'false':
+                    value = False
+                else:
+                    value = opt[1]
             qmpcmd['arguments'][opt[0]] = value
         return qmpcmd