From patchwork Tue Mar 26 10:08:00 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans de Goede X-Patchwork-Id: 231150 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 9503A2C0089 for ; Tue, 26 Mar 2013 21:11:31 +1100 (EST) Received: from localhost ([::1]:56699 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKQqn-0003lr-Da for incoming@patchwork.ozlabs.org; Tue, 26 Mar 2013 06:11:29 -0400 Received: from eggs.gnu.org ([208.118.235.92]:56455) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKQkS-00030O-LN for qemu-devel@nongnu.org; Tue, 26 Mar 2013 06:04:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UKQkN-0007LO-Ca for qemu-devel@nongnu.org; Tue, 26 Mar 2013 06:04:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37654) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKQkN-0007Kd-31 for qemu-devel@nongnu.org; Tue, 26 Mar 2013 06:04:51 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2QA4oTG027760 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 26 Mar 2013 06:04:50 -0400 Received: from shalem.localdomain.com (vpn1-6-123.ams2.redhat.com [10.36.6.123]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r2QA4ag1014732; Tue, 26 Mar 2013 06:04:49 -0400 From: Hans de Goede To: qemu-devel@nongnu.org Date: Tue, 26 Mar 2013 11:08:00 +0100 Message-Id: <1364292483-16564-9-git-send-email-hdegoede@redhat.com> In-Reply-To: <1364292483-16564-1-git-send-email-hdegoede@redhat.com> References: <1364292483-16564-1-git-send-email-hdegoede@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: Amit Shah , Hans de Goede , Gerd Hoffmann Subject: [Qemu-devel] [PATCH 08/11] qemu-char: add_handlers: Don't re-send the be_open event on unregister X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Resending the be_open event only is useful when a frontend is registering, not when it is unregistering. Signed-off-by: Hans de Goede --- qemu-char.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-char.c b/qemu-char.c index 368e7f5..edf3779 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -214,7 +214,7 @@ void qemu_chr_add_handlers(CharDriverState *s, /* We're connecting to an already opened device, so let's make sure we also get the open event */ - if (s->be_open) { + if (fe_open && s->be_open) { qemu_chr_be_generic_open(s); } }