Patchwork [U-Boot,1/3] exynos5250: remove redundant SPI related configs

login
register
mail settings
Submitter Inderpal Singh
Date March 26, 2013, 9:37 a.m.
Message ID <1364290670-7443-2-git-send-email-inderpal.singh@linaro.org>
Download mbox | patch
Permalink /patch/231127/
State Changes Requested
Delegated to: Minkyu Kang
Headers show

Comments

Inderpal Singh - March 26, 2013, 9:37 a.m.
They have been defined once already. Hence remove the redundant definitions.

Signed-off-by: Inderpal Singh <inderpal.singh@linaro.org>
---
 include/configs/exynos5250-dt.h |   21 ---------------------
 1 file changed, 21 deletions(-)
Rajeshwari Birje - March 26, 2013, 11:21 a.m.
Hi Inderpal Singh,

I observed even this defined twice can you please remove the same also
in your patch.
/* PMIC */
#define CONFIG_POWER
#define CONFIG_POWER_I2C
#define CONFIG_POWER_MAX77686

Regards,
Rajeshwari Shinde.

On Tue, Mar 26, 2013 at 3:07 PM, Inderpal Singh
<inderpal.singh@linaro.org> wrote:
> They have been defined once already. Hence remove the redundant definitions.
>
> Signed-off-by: Inderpal Singh <inderpal.singh@linaro.org>
> ---
>  include/configs/exynos5250-dt.h |   21 ---------------------
>  1 file changed, 21 deletions(-)
>
> diff --git a/include/configs/exynos5250-dt.h b/include/configs/exynos5250-dt.h
> index 7308522..d5d8e3a 100644
> --- a/include/configs/exynos5250-dt.h
> +++ b/include/configs/exynos5250-dt.h
> @@ -267,27 +267,6 @@
>  #define CONFIG_POWER_I2C
>  #define CONFIG_POWER_MAX77686
>
> -/* SPI */
> -#define CONFIG_ENV_IS_IN_SPI_FLASH
> -#define CONFIG_SPI_FLASH
> -
> -#ifdef CONFIG_SPI_FLASH
> -#define CONFIG_EXYNOS_SPI
> -#define CONFIG_CMD_SF
> -#define CONFIG_CMD_SPI
> -#define CONFIG_SPI_FLASH_WINBOND
> -#define CONFIG_SF_DEFAULT_MODE         SPI_MODE_0
> -#define CONFIG_SF_DEFAULT_SPEED                50000000
> -#define EXYNOS5_SPI_NUM_CONTROLLERS    5
> -#endif
> -
> -#ifdef CONFIG_ENV_IS_IN_SPI_FLASH
> -#define CONFIG_ENV_SPI_MODE    SPI_MODE_0
> -#define CONFIG_ENV_SECT_SIZE   CONFIG_ENV_SIZE
> -#define CONFIG_ENV_SPI_BUS     1
> -#define CONFIG_ENV_SPI_MAX_HZ  50000000
> -#endif
> -
>  /* Ethernet Controllor Driver */
>  #ifdef CONFIG_CMD_NET
>  #define CONFIG_SMC911X
> --
> 1.7.9.5
>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot

Patch

diff --git a/include/configs/exynos5250-dt.h b/include/configs/exynos5250-dt.h
index 7308522..d5d8e3a 100644
--- a/include/configs/exynos5250-dt.h
+++ b/include/configs/exynos5250-dt.h
@@ -267,27 +267,6 @@ 
 #define CONFIG_POWER_I2C
 #define CONFIG_POWER_MAX77686
 
-/* SPI */
-#define CONFIG_ENV_IS_IN_SPI_FLASH
-#define CONFIG_SPI_FLASH
-
-#ifdef CONFIG_SPI_FLASH
-#define CONFIG_EXYNOS_SPI
-#define CONFIG_CMD_SF
-#define CONFIG_CMD_SPI
-#define CONFIG_SPI_FLASH_WINBOND
-#define CONFIG_SF_DEFAULT_MODE		SPI_MODE_0
-#define CONFIG_SF_DEFAULT_SPEED		50000000
-#define EXYNOS5_SPI_NUM_CONTROLLERS	5
-#endif
-
-#ifdef CONFIG_ENV_IS_IN_SPI_FLASH
-#define CONFIG_ENV_SPI_MODE	SPI_MODE_0
-#define CONFIG_ENV_SECT_SIZE	CONFIG_ENV_SIZE
-#define CONFIG_ENV_SPI_BUS	1
-#define CONFIG_ENV_SPI_MAX_HZ	50000000
-#endif
-
 /* Ethernet Controllor Driver */
 #ifdef CONFIG_CMD_NET
 #define CONFIG_SMC911X