From patchwork Tue Mar 26 06:56:07 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 231099 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 23AB22C00C9 for ; Tue, 26 Mar 2013 17:56:12 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756391Ab3CZG4K (ORCPT ); Tue, 26 Mar 2013 02:56:10 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:41875 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753712Ab3CZG4J (ORCPT ); Tue, 26 Mar 2013 02:56:09 -0400 Received: from epcpsbgr2.samsung.com (u142.gpu120.samsung.co.kr [203.254.230.142]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MK900AIE9XG8IO0@mailout4.samsung.com> for linux-i2c@vger.kernel.org; Tue, 26 Mar 2013 15:56:07 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.50]) by epcpsbgr2.samsung.com (EPCPMTA) with SMTP id 63.AC.07735.78641515; Tue, 26 Mar 2013 15:56:07 +0900 (KST) X-AuditID: cbfee68e-b7f946d000001e37-82-51514687bf85 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 16.56.13494.78641515; Tue, 26 Mar 2013 15:56:07 +0900 (KST) Received: from DOJG1HAN02 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MK9004W39XJJA30@mmp1.samsung.com>; Tue, 26 Mar 2013 15:56:07 +0900 (KST) From: Jingoo Han To: 'Wolfram Sang' Cc: 'Wolfram Sang' , linux-i2c@vger.kernel.org, 'Ben Dooks' , 'Jingoo Han' Subject: [PATCH 1/5] i2c: stu300: add CONFIG_PM_SLEEP to suspend/resume functions Date: Tue, 26 Mar 2013 15:56:07 +0900 Message-id: <001501ce29ee$fd997150$f8cc53f0$%han@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac4p7v1ycpyzyU1RSmSlP3LAxFmscg== Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrNIsWRmVeSWpSXmKPExsVy+t8zI912t8BAg4aHRhaT1h1gsri88BKr RcffL4wWPdtnslmsPDGL2YHV4++qF8wefVtWMXqcPPWExePzJrkAligum5TUnMyy1CJ9uwSu jLv77rAXtPBWnPr0kKWB8QtXFyMnh4SAicTFv1PZIGwxiQv31gPZXBxCAssYJTZs+8gIU3Sk bworRGIRo0TbhWXMEM4vRolnFz6zglSxCahJfPlymB3EFgGyn338yghSxCzQxyjxuH07C0hC WCBYYuud6WBFLAKqEj2bIWxeAVuJmR1nWSBsQYkfk++B2cwCWhLrdx5ngrDlJTaveQu0mQPo JHWJR391IXbpScxYsAaqXERi34t3UFdvY5f4tUkcYpWAxLfJh1ggWmUlNh1ghiiRlDi44gbL BEaxWUgWz0KyeBaSxbOQbFjAyLKKUTS1ILmgOCm9yEivODG3uDQvXS85P3cTIyTi+nYw3jxg fYgxGWj9RGYp0eR8YMTmlcQbGpsZWZiamBobmVuakSasJM6r1mIdKCSQnliSmp2aWpBaFF9U mpNafIiRiYNTqoHReW3s7y3vJiWtrLisrBpxZ+rD4zEi87LDNgcFpc+4e0LoQ73MtJ0P7e4/ 8Zy6/czH1Y9sv/Un3T7EvPye35N98bd3HFI+7zozx7NrvU/+3+cNNfwqB7oe/za9a5YheO1a 01/PQ/e2JXPI6bGUTHdwS9U95aCs8obL8Xbbg7Cypht3l6kWFGn/VWIpzkg01GIuKk4EAD1S LlzOAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprJKsWRmVeSWpSXmKPExsVy+t9jAd12t8BAg9039CwmrTvAZHF54SVW i46/XxgterbPZLNYeWIWswOrx99VL5g9+rasYvQ4eeoJi8fnTXIBLFENjDYZqYkpqUUKqXnJ +SmZeem2St7B8c7xpmYGhrqGlhbmSgp5ibmptkouPgG6bpk5QIuVFMoSc0qBQgGJxcVK+naY JoSGuOlawDRG6PqGBMH1GBmggYR1jBl3991hL2jhrTj16SFLA+MXri5GTg4JAROJI31TWCFs MYkL99azdTFycQgJLGKUaLuwjBnC+cUo8ezCZ7AqNgE1iS9fDrOD2CJA9rOPXxlBipgF+hgl HrdvZwFJCAsES2y9Mx2siEVAVaJnM4TNK2ArMbPjLAuELSjxY/I9MJtZQEti/c7jTBC2vMTm NW+BNnMAnaQu8eivLsQuPYkZC9ZAlYtI7HvxjnECo8AsJJNmIZk0C8mkWUhaFjCyrGIUTS1I LihOSs810itOzC0uzUvXS87P3cQIjuhn0jsYVzVYHGIU4GBU4uHlCAsIFGJNLCuuzD3EKMHB rCTC+8cxMFCINyWxsiq1KD++qDQntfgQYzLQoxOZpUST84HJJq8k3tDYxMzI0sjMwsjE3Jw0 YSVx3oOt1oFCAumJJanZqakFqUUwW5g4OKUaGBUcxI7t/n3wx7ZGg4yXiReF1567zvvH9ccP TU6Wz7WPvRdafTg0M+eSvpke16XKCzPu/tE5sCvT07ZUjTnCId7D32Hquxa/ze4vLq2StVdx bmtTWzMv4wrTtvCngRkH+o91Zn2affJWZOGMz5FalscPeVjnuR2R+3Mt7H61fXGeUnOGtDPP eSWW4oxEQy3mouJEAJKv9rksAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-i2c-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org Add CONFIG_PM_SLEEP to suspend/resume functions to fix the following build warning when CONFIG_PM_SLEEP is not selected. This is because sleep PM callbacks defined by SIMPLE_DEV_PM_OPS are only used when the CONFIG_PM_SLEEP is enabled. drivers/i2c/busses/i2c-stu300.c:941:12: warning: 'stu300_suspend' defined but not used [-Wunused-function] drivers/i2c/busses/i2c-stu300.c:950:12: warning: 'stu300_resume' defined but not used [-Wunused-function] Signed-off-by: Jingoo Han --- drivers/i2c/busses/i2c-stu300.c | 9 +++------ 1 files changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/i2c/busses/i2c-stu300.c b/drivers/i2c/busses/i2c-stu300.c index 0a6f941..a17874d 100644 --- a/drivers/i2c/busses/i2c-stu300.c +++ b/drivers/i2c/busses/i2c-stu300.c @@ -937,7 +937,7 @@ stu300_probe(struct platform_device *pdev) return 0; } -#ifdef CONFIG_PM +#ifdef CONFIG_PM_SLEEP static int stu300_suspend(struct device *device) { struct stu300_dev *dev = dev_get_drvdata(device); @@ -960,12 +960,9 @@ static int stu300_resume(struct device *device) dev_err(device, "error re-initializing hardware.\n"); return ret; } +#endif static SIMPLE_DEV_PM_OPS(stu300_pm, stu300_suspend, stu300_resume); -#define STU300_I2C_PM (&stu300_pm) -#else -#define STU300_I2C_PM NULL -#endif static int __exit stu300_remove(struct platform_device *pdev) @@ -982,7 +979,7 @@ static struct platform_driver stu300_i2c_driver = { .driver = { .name = NAME, .owner = THIS_MODULE, - .pm = STU300_I2C_PM, + .pm = &stu300_pm, }, .remove = __exit_p(stu300_remove),