Patchwork [8/9] spark: cpufreq: move cpufreq driver to drivers/cpufreq

login
register
mail settings
Submitter viresh kumar
Date March 26, 2013, 4:25 a.m.
Message ID <CAKohponJJKDcFXK-Zs-eCS2=v3=-CrkEqF1FaHz64D-kq888BA@mail.gmail.com>
Download mbox | patch
Permalink /patch/231078/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

viresh kumar - March 26, 2013, 4:25 a.m.
On 26 March 2013 07:30, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> On 25 March 2013 22:37, David Miller <davem@davemloft.net> wrote:
>> From: Viresh Kumar <viresh.kumar@linaro.org>
>> Date: Mon, 25 Mar 2013 22:24:44 +0530
>>
>>> This patch moves cpufreq driver of SPARK architecture to drivers/cpufreq.
>>
>> I don't know what spark is.
>
> :(
>
> s/spark/sparc ...
>
> I will fix patch in V2..

Mistake was done in code too and not only log :)

Here is re-spin of this patch (attached too in case you want to test):

From: Viresh Kumar <viresh.kumar@linaro.org>
Date: Mon, 25 Mar 2013 11:20:23 +0530
Subject: [PATCH] sparc: cpufreq:  move cpufreq driver to drivers/cpufreq

This patch moves cpufreq driver of SPARC architecture to drivers/cpufreq.

Cc: David S. Miller <davem@davemloft.net>
Cc: sparclinux@vger.kernel.org
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
 arch/sparc/Kconfig                                 | 23 ----------------------
 arch/sparc/kernel/Makefile                         |  3 ---
 drivers/cpufreq/Kconfig                            | 23 ++++++++++++++++++++++
 drivers/cpufreq/Makefile                           |  2 ++
 .../cpufreq/sparc-us2e-cpufreq.c                   |  0
 .../cpufreq/sparc-us3-cpufreq.c                    |  0
 6 files changed, 25 insertions(+), 26 deletions(-)
 rename arch/sparc/kernel/us2e_cpufreq.c =>
drivers/cpufreq/sparc-us2e-cpufreq.c (100%)
 rename arch/sparc/kernel/us3_cpufreq.c =>
drivers/cpufreq/sparc-us3-cpufreq.c (100%)

diff --git a/arch/sparc/kernel/us2e_cpufreq.c
b/drivers/cpufreq/sparc-us2e-cpufreq.c
similarity index 100%
rename from arch/sparc/kernel/us2e_cpufreq.c
rename to drivers/cpufreq/sparc-us2e-cpufreq.c
diff --git a/arch/sparc/kernel/us3_cpufreq.c
b/drivers/cpufreq/sparc-us3-cpufreq.c
similarity index 100%
rename from arch/sparc/kernel/us3_cpufreq.c
rename to drivers/cpufreq/sparc-us3-cpufreq.c
viresh kumar - March 31, 2013, 7:30 a.m.
On 26 March 2013 09:55, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> From: Viresh Kumar <viresh.kumar@linaro.org>
> Date: Mon, 25 Mar 2013 11:20:23 +0530
> Subject: [PATCH] sparc: cpufreq:  move cpufreq driver to drivers/cpufreq
>
> This patch moves cpufreq driver of SPARC architecture to drivers/cpufreq.
>
> Cc: David S. Miller <davem@davemloft.net>
> Cc: sparclinux@vger.kernel.org
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
>  arch/sparc/Kconfig                                 | 23 ----------------------
>  arch/sparc/kernel/Makefile                         |  3 ---
>  drivers/cpufreq/Kconfig                            | 23 ++++++++++++++++++++++
>  drivers/cpufreq/Makefile                           |  2 ++
>  .../cpufreq/sparc-us2e-cpufreq.c                   |  0
>  .../cpufreq/sparc-us3-cpufreq.c                    |  0
>  6 files changed, 25 insertions(+), 26 deletions(-)
>  rename arch/sparc/kernel/us2e_cpufreq.c =>
> drivers/cpufreq/sparc-us2e-cpufreq.c (100%)
>  rename arch/sparc/kernel/us3_cpufreq.c =>
> drivers/cpufreq/sparc-us3-cpufreq.c (100%)

Hi David,

Does this one look fine to you?
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - March 31, 2013, 4:40 p.m.
From: Viresh Kumar <viresh.kumar@linaro.org>
Date: Sun, 31 Mar 2013 13:00:21 +0530

> On 26 March 2013 09:55, Viresh Kumar <viresh.kumar@linaro.org> wrote:
>> From: Viresh Kumar <viresh.kumar@linaro.org>
>> Date: Mon, 25 Mar 2013 11:20:23 +0530
>> Subject: [PATCH] sparc: cpufreq:  move cpufreq driver to drivers/cpufreq
>>
>> This patch moves cpufreq driver of SPARC architecture to drivers/cpufreq.
>>
>> Cc: David S. Miller <davem@davemloft.net>
>> Cc: sparclinux@vger.kernel.org
>> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
>> ---
>>  arch/sparc/Kconfig                                 | 23 ----------------------
>>  arch/sparc/kernel/Makefile                         |  3 ---
>>  drivers/cpufreq/Kconfig                            | 23 ++++++++++++++++++++++
>>  drivers/cpufreq/Makefile                           |  2 ++
>>  .../cpufreq/sparc-us2e-cpufreq.c                   |  0
>>  .../cpufreq/sparc-us3-cpufreq.c                    |  0
>>  6 files changed, 25 insertions(+), 26 deletions(-)
>>  rename arch/sparc/kernel/us2e_cpufreq.c =>
>> drivers/cpufreq/sparc-us2e-cpufreq.c (100%)
>>  rename arch/sparc/kernel/us3_cpufreq.c =>
>> drivers/cpufreq/sparc-us3-cpufreq.c (100%)
> 
> Hi David,
> 
> Does this one look fine to you?

Subject line still has the "spark" typo.
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
viresh kumar - April 1, 2013, 4:41 a.m.
On 31 March 2013 22:10, David Miller <davem@davemloft.net> wrote:
>> On 26 March 2013 09:55, Viresh Kumar <viresh.kumar@linaro.org> wrote:
>>> From: Viresh Kumar <viresh.kumar@linaro.org>
>>> Date: Mon, 25 Mar 2013 11:20:23 +0530
>>> Subject: [PATCH] sparc: cpufreq:  move cpufreq driver to drivers/cpufreq

> Subject line still has the "spark" typo.

Your mail was scary, really... HOW can i do it??

And then i saw how you got it wrong. I haven't sent a new mail, so mails subject
remains the same... I copied V2 in the same mail.. Check above, subject looks
fine :)
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
viresh kumar - April 3, 2013, 5:09 p.m.
On 3 April 2013 22:08, David Miller <davem@davemloft.net> wrote:
> From: Viresh Kumar <viresh.kumar@linaro.org>
> Date: Wed, 3 Apr 2013 14:59:44 +0530
>
>> On 1 April 2013 10:11, Viresh Kumar <viresh.kumar@linaro.org> wrote:
>>> On 31 March 2013 22:10, David Miller <davem@davemloft.net> wrote:
>>>>> On 26 March 2013 09:55, Viresh Kumar <viresh.kumar@linaro.org> wrote:
>>>>>> From: Viresh Kumar <viresh.kumar@linaro.org>
>>>>>> Date: Mon, 25 Mar 2013 11:20:23 +0530
>>>>>> Subject: [PATCH] sparc: cpufreq:  move cpufreq driver to drivers/cpufreq
>>>
>>>> Subject line still has the "spark" typo.
>>>
>>> Your mail was scary, really... HOW can i do it??
>>>
>>> And then i saw how you got it wrong. I haven't sent a new mail, so mails subject
>>> remains the same... I copied V2 in the same mail.. Check above, subject looks
>>> fine :)
>>
>> Hi David,
>>
>> I think all pending issues are fixed now... Can i have your Ack please?
>> Or maybe more comments :)
>
> Acked-by: David S. Miller <davem@davemloft.net>

Adding everybody else in cc.
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/arch/sparc/Kconfig b/arch/sparc/Kconfig
index 289127d..52e7680 100644
--- a/arch/sparc/Kconfig
+++ b/arch/sparc/Kconfig
@@ -260,29 +260,6 @@  config HOTPLUG_CPU

 if SPARC64
 source "drivers/cpufreq/Kconfig"
-
-config US3_FREQ
-	tristate "UltraSPARC-III CPU Frequency driver"
-	depends on CPU_FREQ
-	select CPU_FREQ_TABLE
-	help
-	  This adds the CPUFreq driver for UltraSPARC-III processors.
-
-	  For details, take a look at <file:Documentation/cpu-freq>.
-
-	  If in doubt, say N.
-
-config US2E_FREQ
-	tristate "UltraSPARC-IIe CPU Frequency driver"
-	depends on CPU_FREQ
-	select CPU_FREQ_TABLE
-	help
-	  This adds the CPUFreq driver for UltraSPARC-IIe processors.
-
-	  For details, take a look at <file:Documentation/cpu-freq>.
-
-	  If in doubt, say N.
-
 endif

 config US3_MC
diff --git a/arch/sparc/kernel/Makefile b/arch/sparc/kernel/Makefile
index 6cf591b..5276fd4 100644
--- a/arch/sparc/kernel/Makefile
+++ b/arch/sparc/kernel/Makefile
@@ -102,9 +102,6 @@  obj-$(CONFIG_PCI_MSI)        += pci_msi.o

 obj-$(CONFIG_COMPAT)         += sys32.o sys_sparc32.o signal32.o

-# sparc64 cpufreq
-obj-$(CONFIG_US3_FREQ)  += us3_cpufreq.o
-obj-$(CONFIG_US2E_FREQ) += us2e_cpufreq.o
 obj-$(CONFIG_US3_MC)    += chmc.o

 obj-$(CONFIG_KPROBES)   += kprobes.o
diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig
index 602d5db..a1488f5 100644
--- a/drivers/cpufreq/Kconfig
+++ b/drivers/cpufreq/Kconfig
@@ -258,6 +258,29 @@  depends on PPC32 || PPC64
 source "drivers/cpufreq/Kconfig.powerpc"
 endmenu

+menu "SPARC CPU frequency scaling drivers"
+depends on SPARC64
+config SPARC_US3_CPUFREQ
+	tristate "UltraSPARC-III CPU Frequency driver"
+	select CPU_FREQ_TABLE
+	help
+	  This adds the CPUFreq driver for UltraSPARC-III processors.
+
+	  For details, take a look at <file:Documentation/cpu-freq>.
+
+	  If in doubt, say N.
+
+config SPARC_US2E_CPUFREQ
+	tristate "UltraSPARC-IIe CPU Frequency driver"
+	select CPU_FREQ_TABLE
+	help
+	  This adds the CPUFreq driver for UltraSPARC-IIe processors.
+
+	  For details, take a look at <file:Documentation/cpu-freq>.
+
+	  If in doubt, say N.
+endmenu
+
 menu "SH CPU Frequency scaling"
 depends on SUPERH
 config SH_CPU_FREQ
diff --git a/drivers/cpufreq/Makefile b/drivers/cpufreq/Makefile
index ab3a054..050bd0c 100644
--- a/drivers/cpufreq/Makefile
+++ b/drivers/cpufreq/Makefile
@@ -85,4 +85,6 @@  obj-$(CONFIG_ETRAXFS)			+= cris-etraxfs-cpufreq.o
 obj-$(CONFIG_IA64_ACPI_CPUFREQ)		+= ia64-acpi-cpufreq.o
 obj-$(CONFIG_LOONGSON2_CPUFREQ)		+= loongson2_cpufreq.o
 obj-$(CONFIG_SH_CPU_FREQ)		+= sh-cpufreq.o
+obj-$(CONFIG_SPARC_US2E_CPUFREQ)	+= sparc-us2e-cpufreq.o
+obj-$(CONFIG_SPARC_US3_CPUFREQ)		+= sparc-us3-cpufreq.o
 obj-$(CONFIG_UNICORE32)			+= unicore2-cpufreq.o