Patchwork *ping* [patch, fortran, 4.9] Dependency and string length calculation improvements

login
register
mail settings
Submitter Thomas Koenig
Date March 25, 2013, 3:43 p.m.
Message ID <5150709A.6030201@netcologne.de>
Download mbox | patch
Permalink /patch/230750/
State New
Headers show

Comments

Thomas Koenig - March 25, 2013, 3:43 p.m.
*ping*

Slightly updated patch below, with a better test case as suggested
by Dominique.

OK for trunk?

2013-03-16  Thomas Koenig  <tkoenig@gcc.gnu.org>

         PR fortran/45159
         * gfortran.h (gfc_dep_difference):  Add prototype.
         * dependency.c (discard_nops):  New function.
         (gfc_dep_difference):  New function.
         (check_section_vs_section):  Use gfc_dep_difference
         to calculate the difference of starting indices.
         * trans-expr.c (gfc_conv_substring):  Use
         gfc_dep_difference to calculate the length of
         substrings where possible.

2013-03-16  Thomas Koenig  <tkoenig@gcc.gnu.org>

         PR fortran/45159
         * gfortran.dg/string_length_2.f90:  New test.
         * gfortran.dg/dependency_41.f90:  New test.
Thomas Koenig - March 28, 2013, 4:09 p.m.
I wrote:

Ping**2?

I'd like to get these patches committed, if possible, to clear up my
trees a little bit :-)

	Thomas
> *ping*
>
> Slightly updated patch below, with a better test case as suggested
> by Dominique.
>
> OK for trunk?
>
> 2013-03-16  Thomas Koenig  <tkoenig@gcc.gnu.org>
>
>          PR fortran/45159
>          * gfortran.h (gfc_dep_difference):  Add prototype.
>          * dependency.c (discard_nops):  New function.
>          (gfc_dep_difference):  New function.
>          (check_section_vs_section):  Use gfc_dep_difference
>          to calculate the difference of starting indices.
>          * trans-expr.c (gfc_conv_substring):  Use
>          gfc_dep_difference to calculate the length of
>          substrings where possible.
>
> 2013-03-16  Thomas Koenig  <tkoenig@gcc.gnu.org>
>
>          PR fortran/45159
>          * gfortran.dg/string_length_2.f90:  New test.
>          * gfortran.dg/dependency_41.f90:  New test.
>
Tobias Burnus - March 28, 2013, 5:48 p.m.
Thomas Koenig wrote:
> below is a patch which improves dependency checking for array
> assignments and calculation of string lengths. 

Talking about dependencies, I wonder whether you would be interested 
implementing the function
    bool gfc_simply_noncontiguous (gfc_expr *);
or something similarly named.

It should return true, if the expression is known to be noncontiguous. 
Such a function has many uses:
- Diagnostic to reject invalid code such as "contiguous_ptr => 
noncontiguous_target",* passing a noncontiguous expression to c_loc, and 
possibly more
- Compile-time simplification for the IS_CONTIGUOUS intrinsic (not yet 
implemented)
- If we pass a noncontiguous array to a contiguous dummy argument (i.e. 
assumed-size, explicit-size or contiguous attribute), there is the check 
if(new_array != old_array) { unpack(old_array,new_array);free(new_array) 
}. If one knows that the array is noncontiguous, the 
"if(new_array!=old_array) check could be removed (missed optimization)
- Potentially some more uses

Additionally, gfc_simply_noncontiguous has some bugs (both false 
positive and false negative) - especially for BT_CLASS and for 
ref-array/ref-substring handling (esp. when combined).

Actually, for
   type t
     integer i
   end type t
type(t) :: foo(5)
is_contiguous(foo(:)%i), it depends on the aligning. (I think one needs 
to call gfc_target_expr_size for "foo(:)" and compare it with the 
storage size of foo(1)%i.) Of course, if there multiple components, 
foo(:)%i is obviously noncontiguous. (For gfc_simply_contiguous, see the 
Fortran standard for the exact definition of "simply contiguous", which 
should be used with strict==true).


If you will work on it, please tell me - otherwise, I might start to 
work on it. (It is not on top of my agenda, but for Fortran 2008's 
IS_CONTIGUOUS() and for diagnostic reasons, I like to have it.)


  * * *


But now, a bit belated, to your patch.

On 25.03.2013 16:43, Thomas Koenig wrote:
> OK for trunk?

OK - except for the following three minor coding convention nits.


> +}
> +/* Return the difference between two expressions.  Integer expressions of

Two empty lines before the comment.

> +}
> +
>   /* Returns 1 if the two ranges are the same and 0 if they are not (or if the

This time only one empty line is missing.

> -      mpz_clear (tmp);
> +      mpz_clear (tmp); /* gfc_dep_difference returned true, so tmp was initialized.  */

I am not sure whether the comment is needed - but if you want to keep 
it: The line is too long ;-)


Tobias

* Example for that
pointer, contiguous :: ptr
target :: tgt(5)
ptr => tgt(::2)
Mikael Morin - March 28, 2013, 7:32 p.m.
Le 28/03/2013 18:48, Tobias Burnus a écrit :
> Talking about dependencies, I wonder whether you would be interested
> implementing the function
>    bool gfc_simply_noncontiguous (gfc_expr *);
> or something similarly named.
> 
> It should return true, if the expression is known to be noncontiguous.

I suggest having instead a single function returning a two bit integer,
one bit for contiguous, one for noncontiguous.

Mikael
Thomas Koenig - March 28, 2013, 9:39 p.m.
Hi Tobias,

> Talking about dependencies, I wonder whether you would be interested
> implementing the function
>     bool gfc_simply_noncontiguous (gfc_expr *);
> or something similarly named.


> If you will work on it, please tell me -

Sounds interesting.  I'll give it a shot.

	Thomas

Patch

Index: gfortran.h
===================================================================
--- gfortran.h	(Revision 196574)
+++ gfortran.h	(Arbeitskopie)
@@ -2959,6 +2959,7 @@  gfc_namespace* gfc_build_block_ns (gfc_namespace *
 /* dependency.c */
 int gfc_dep_compare_functions (gfc_expr *, gfc_expr *, bool);
 int gfc_dep_compare_expr (gfc_expr *, gfc_expr *);
+bool gfc_dep_difference (gfc_expr *, gfc_expr *, mpz_t *);
 
 /* check.c */
 gfc_try gfc_check_same_strlen (const gfc_expr*, const gfc_expr*, const char*);
Index: dependency.c
===================================================================
--- dependency.c	(Revision 196574)
+++ dependency.c	(Arbeitskopie)
@@ -500,7 +500,270 @@  gfc_dep_compare_expr (gfc_expr *e1, gfc_expr *e2)
     }
 }
 
+/* Helper function to look through parens and unary plus.  */
 
+static gfc_expr*
+discard_nops (gfc_expr *e)
+{
+
+  while (e && e->expr_type == EXPR_OP
+	 && (e->value.op.op == INTRINSIC_UPLUS
+	     || e->value.op.op == INTRINSIC_PARENTHESES))
+    e = e->value.op.op1;
+
+  return e;
+}
+/* Return the difference between two expressions.  Integer expressions of
+   the form 
+
+   X + constant, X - constant and constant + X
+
+   are handled.  Return true on success, false on failure. result is assumed
+   to be uninitialized on entry, and will be initialized on success.
+*/
+
+bool
+gfc_dep_difference (gfc_expr *e1, gfc_expr *e2, mpz_t *result)
+{
+  gfc_expr *e1_op1, *e1_op2, *e2_op1, *e2_op2;
+
+  if (e1 == NULL || e2 == NULL)
+    return false;
+
+  if (e1->ts.type != BT_INTEGER || e2->ts.type != BT_INTEGER)
+    return false;
+
+  e1 = discard_nops (e1);
+  e2 = discard_nops (e2);
+
+  /* Inizialize tentatively, clear if we don't return anything.  */
+  mpz_init (*result);
+
+  /* Case 1: c1 - c2 = c1 - c2, trivially.  */
+
+  if (e1->expr_type == EXPR_CONSTANT && e2->expr_type == EXPR_CONSTANT)
+    {
+      mpz_sub (*result, e1->value.integer, e2->value.integer);
+      return true;
+    }
+
+  if (e1->expr_type == EXPR_OP && e1->value.op.op == INTRINSIC_PLUS)
+    {
+      e1_op1 = discard_nops (e1->value.op.op1);
+      e1_op2 = discard_nops (e1->value.op.op2);
+
+      /* Case 2: (X + c1) - X = c1.  */
+      if (e1_op2->expr_type == EXPR_CONSTANT
+	  && gfc_dep_compare_expr (e1_op1, e2) == 0)
+	{
+	  mpz_set (*result, e1_op2->value.integer);
+	  return true;
+	}
+
+      /* Case 3: (c1 + X) - X = c1. */
+      if (e1_op1->expr_type == EXPR_CONSTANT
+	  && gfc_dep_compare_expr (e1_op2, e2) == 0)
+	{
+	  mpz_set (*result, e1_op1->value.integer);
+	  return true;
+	}
+
+      if (e2->expr_type == EXPR_OP && e2->value.op.op == INTRINSIC_PLUS)
+	{
+	  e2_op1 = discard_nops (e2->value.op.op1);
+	  e2_op2 = discard_nops (e2->value.op.op2);
+
+	  if (e1_op2->expr_type == EXPR_CONSTANT)
+	    {
+	      /* Case 4: X + c1 - (X + c2) = c1 - c2.  */
+	      if (e2_op2->expr_type == EXPR_CONSTANT
+		  && gfc_dep_compare_expr (e1_op1, e2_op1) == 0)
+		{
+		  mpz_sub (*result, e1_op2->value.integer,
+			   e2_op2->value.integer);
+		  return true;
+		}
+	      /* Case 5: X + c1 - (c2 + X) = c1 - c2.  */
+	      if (e2_op1->expr_type == EXPR_CONSTANT
+		  && gfc_dep_compare_expr (e1_op1, e2_op2) == 0)
+		{
+		  mpz_sub (*result, e1_op2->value.integer,
+			   e2_op1->value.integer);
+		  return true;
+		}
+	    }
+	  else if (e1_op1->expr_type == EXPR_CONSTANT)
+	    {
+	      /* Case 6: c1 + X - (X + c2) = c1 - c2.  */
+	      if (e2_op2->expr_type == EXPR_CONSTANT
+		  && gfc_dep_compare_expr (e1_op2, e2_op1) == 0)
+		{
+		  mpz_sub (*result, e1_op1->value.integer,
+			   e2_op2->value.integer);
+		  return true;
+		}
+	      /* Case 7: c1 + X - (c2 + X) = c1 - c2.  */
+	      if (e2_op1->expr_type == EXPR_CONSTANT
+		  && gfc_dep_compare_expr (e1_op2, e2_op2) == 0)
+		{
+		  mpz_sub (*result, e1_op1->value.integer,
+			   e2_op1->value.integer);
+		  return true;
+		}
+	    }
+	}
+
+      if (e2->expr_type == EXPR_OP && e2->value.op.op == INTRINSIC_MINUS)
+	{
+	  e2_op1 = discard_nops (e2->value.op.op1);
+	  e2_op2 = discard_nops (e2->value.op.op2);
+
+	  if (e1_op2->expr_type == EXPR_CONSTANT)
+	    {
+	      /* Case 8: X + c1 - (X - c2) = c1 + c2.  */
+	      if (e2_op2->expr_type == EXPR_CONSTANT
+		  && gfc_dep_compare_expr (e1_op1, e2_op1) == 0)
+		{
+		  mpz_add (*result, e1_op2->value.integer,
+			   e2_op2->value.integer);
+		  return true;
+		}
+	    }
+	  if (e1_op1->expr_type == EXPR_CONSTANT)
+	    {
+	      /* Case 9: c1 + X - (X - c2) = c1 + c2.  */
+	      if (e2_op2->expr_type == EXPR_CONSTANT
+		  && gfc_dep_compare_expr (e1_op2, e2_op1) == 0)
+		{
+		  mpz_add (*result, e1_op1->value.integer,
+			   e2_op2->value.integer);
+		  return true;
+		}
+	    }
+	}
+    }
+
+  if (e1->expr_type == EXPR_OP && e1->value.op.op == INTRINSIC_MINUS)
+    {
+      e1_op1 = discard_nops (e1->value.op.op1);
+      e1_op2 = discard_nops (e1->value.op.op2);
+
+      if (e1_op2->expr_type == EXPR_CONSTANT)
+	{
+	  /* Case 10: (X - c1) - X = -c1  */
+
+	  if (gfc_dep_compare_expr (e1_op1, e2) == 0)
+	    {
+	      mpz_neg (*result, e1_op2->value.integer);
+	      return true;
+	    }
+
+	  if (e2->expr_type == EXPR_OP && e2->value.op.op == INTRINSIC_PLUS)
+	    {
+	      e2_op1 = discard_nops (e2->value.op.op1);
+	      e2_op2 = discard_nops (e2->value.op.op2);
+
+	      /* Case 11: (X - c1) - (X + c2) = -( c1 + c2).  */
+	      if (e2_op2->expr_type == EXPR_CONSTANT
+		  && gfc_dep_compare_expr (e1_op1, e2_op1) == 0)
+		{
+		  mpz_add (*result, e1_op2->value.integer,
+			   e2_op2->value.integer);
+		  mpz_neg (*result, *result);
+		  return true;
+		}
+
+	      /* Case 12: X - c1 - (c2 + X) = - (c1 + c2).  */
+	      if (e2_op1->expr_type == EXPR_CONSTANT
+		  && gfc_dep_compare_expr (e1_op1, e2_op2) == 0)
+		{
+		  mpz_add (*result, e1_op2->value.integer,
+			   e2_op1->value.integer);
+		  mpz_neg (*result, *result);
+		  return true;
+		}
+	    }
+
+	  if (e2->expr_type == EXPR_OP && e2->value.op.op == INTRINSIC_MINUS)
+	    {
+	      e2_op1 = discard_nops (e2->value.op.op1);
+	      e2_op2 = discard_nops (e2->value.op.op2);
+
+	      /* Case 13: (X - c1) - (X - c2) = c2 - c1.  */
+	      if (e2_op2->expr_type == EXPR_CONSTANT
+		  && gfc_dep_compare_expr (e1_op1, e2_op1) == 0)
+		{
+		  mpz_sub (*result, e2_op2->value.integer,
+			   e1_op2->value.integer);
+		  return true;
+		}
+	    }
+	}
+      if (e1_op1->expr_type == EXPR_CONSTANT)
+	{
+	  if (e2->expr_type == EXPR_OP && e2->value.op.op == INTRINSIC_MINUS)
+	    {
+	      e2_op1 = discard_nops (e2->value.op.op1);
+	      e2_op2 = discard_nops (e2->value.op.op2);
+	      
+	      /* Case 14: (c1 - X) - (c2 - X) == c1 - c2.  */
+	      if (gfc_dep_compare_expr (e1_op2, e2_op2) == 0)
+		{
+		  mpz_sub (*result, e1_op1->value.integer,
+			   e2_op1->value.integer);
+		    return true;
+		}
+	    }
+
+	}
+    }
+
+  if (e2->expr_type == EXPR_OP && e2->value.op.op == INTRINSIC_PLUS)
+    {
+      e2_op1 = discard_nops (e2->value.op.op1);
+      e2_op2 = discard_nops (e2->value.op.op2);
+
+      /* Case 15: X - (X + c2) = -c2.  */
+      if (e2_op2->expr_type == EXPR_CONSTANT
+	  && gfc_dep_compare_expr (e1, e2_op1) == 0)
+	{
+	  mpz_neg (*result, e2_op2->value.integer);
+	  return true;
+	}
+      /* Case 16: X - (c2 + X) = -c2.  */
+      if (e2_op1->expr_type == EXPR_CONSTANT
+	  && gfc_dep_compare_expr (e1, e2_op2) == 0)
+	{
+	  mpz_neg (*result, e2_op1->value.integer);
+	  return true;
+	}
+    }
+
+  if (e2->expr_type == EXPR_OP && e2->value.op.op == INTRINSIC_MINUS)
+    {
+      e2_op1 = discard_nops (e2->value.op.op1);
+      e2_op2 = discard_nops (e2->value.op.op2);
+
+      /* Case 17: X - (X - c2) = c2.  */
+      if (e2_op2->expr_type == EXPR_CONSTANT
+	  && gfc_dep_compare_expr (e1, e2_op1) == 0)
+	{
+	  mpz_set (*result, e2_op2->value.integer);
+	  return true;
+	}
+    }
+
+  if (gfc_dep_compare_expr(e1, e2) == 0)
+    {
+      /* Case 18: X - X = 0.  */
+      mpz_set_si (*result, 0);
+      return true;
+    }
+
+  mpz_clear (*result);
+  return false;
+}
+
 /* Returns 1 if the two ranges are the same and 0 if they are not (or if the
    results are indeterminate). 'n' is the dimension to compare.  */
 
@@ -1140,6 +1403,7 @@  check_section_vs_section (gfc_array_ref *l_ar, gfc
   int r_dir;
   int stride_comparison;
   int start_comparison;
+  mpz_t tmp;
 
   /* If they are the same range, return without more ado.  */
   if (is_same_range (l_ar, r_ar, n))
@@ -1282,23 +1546,20 @@  check_section_vs_section (gfc_array_ref *l_ar, gfc
 #define IS_CONSTANT_INTEGER(a) ((a) && ((a)->expr_type == EXPR_CONSTANT) \
 			      && (a)->ts.type == BT_INTEGER)
 
-  if (IS_CONSTANT_INTEGER(l_start) && IS_CONSTANT_INTEGER(r_start)
-      && IS_CONSTANT_INTEGER(l_stride) && IS_CONSTANT_INTEGER(r_stride))
+  if (IS_CONSTANT_INTEGER(l_stride) && IS_CONSTANT_INTEGER(r_stride)
+      && gfc_dep_difference (l_start, r_start, &tmp))
     {
-      mpz_t gcd, tmp;
+      mpz_t gcd;
       int result;
 
       mpz_init (gcd);
-      mpz_init (tmp);
-
       mpz_gcd (gcd, l_stride->value.integer, r_stride->value.integer);
-      mpz_sub (tmp, l_start->value.integer, r_start->value.integer);
 
       mpz_fdiv_r (tmp, tmp, gcd);
       result = mpz_cmp_si (tmp, 0L);
 
       mpz_clear (gcd);
-      mpz_clear (tmp);
+      mpz_clear (tmp); /* gfc_dep_difference returned true, so tmp was initialized.  */
 
       if (result != 0)
 	return GFC_DEP_NODEP;
Index: trans-expr.c
===================================================================
--- trans-expr.c	(Revision 196574)
+++ trans-expr.c	(Arbeitskopie)
@@ -1437,6 +1437,7 @@  gfc_conv_substring (gfc_se * se, gfc_ref * ref, in
   gfc_se start;
   gfc_se end;
   char *msg;
+  mpz_t length;
 
   type = gfc_get_character_type (kind, ref->u.ss.length);
   type = build_pointer_type (type);
@@ -1520,10 +1521,19 @@  gfc_conv_substring (gfc_se * se, gfc_ref * ref, in
       free (msg);
     }
 
-  /* If the start and end expressions are equal, the length is one.  */
+  /* Try to calculate the length from the start and end expressions.  */
   if (ref->u.ss.end
-      && gfc_dep_compare_expr (ref->u.ss.start, ref->u.ss.end) == 0)
-    tmp = build_int_cst (gfc_charlen_type_node, 1);
+      && gfc_dep_difference (ref->u.ss.end, ref->u.ss.start, &length))
+    {
+      int i_len;
+
+      i_len = mpz_get_si (length) + 1;
+      if (i_len < 0)
+	i_len = 0;
+
+      tmp = build_int_cst (gfc_charlen_type_node, i_len);
+      mpz_clear (length);  /* Was initialized by gfc_dep_difference.  */
+    }
   else
     {
       tmp = fold_build2_loc (input_location, MINUS_EXPR, gfc_charlen_type_node,