Patchwork [4/4] Enable feature CONFIG_FEATURE_PIDFILE so that the syslog initscript actually works

login
register
mail settings
Submitter Tilman Keskinöz
Date March 25, 2013, 2:48 p.m.
Message ID <1364222893-23858-4-git-send-email-arved@arved.at>
Download mbox | patch
Permalink /patch/230733/
State Superseded
Headers show

Comments

Tilman Keskinöz - March 25, 2013, 2:48 p.m.
From: Tilman Keskinöz <arved@arved.at>


Signed-off-by: Tilman Keskinöz <arved@arved.at>
---
 package/busybox/busybox-1.20.x.config |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Arnout Vandecappelle - March 28, 2013, 7:12 a.m.
Hi Tilman,


On 25/03/13 15:48, arved@arved.at wrote:
> From: Tilman Keskinöz <arved@arved.at>
>
>
> Signed-off-by: Tilman Keskinöz <arved@arved.at>
> ---
>   package/busybox/busybox-1.20.x.config |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/busybox/busybox-1.20.x.config b/package/busybox/busybox-1.20.x.config
> index 5525434..d199996 100644
> --- a/package/busybox/busybox-1.20.x.config
> +++ b/package/busybox/busybox-1.20.x.config
> @@ -41,7 +41,7 @@ CONFIG_FEATURE_DEVPTS=y
>   CONFIG_FEATURE_CLEAN_UP=y
>   CONFIG_FEATURE_UTMP=y
>   CONFIG_FEATURE_WTMP=y
> -# CONFIG_FEATURE_PIDFILE is not set
> +CONFIG_FEATURE_PIDFILE=y

  Since we care very much about the size of busybox, could you evaluate 
what the size difference is before and after this change?  One smallish 
architecture (e.g. ARM) is enough.

  Could you also make this change to the other busybox versions as well? 
The different busybox configs should only differ because of features 
added/removed in that particular version.


  Regards,
  Arnout

>   CONFIG_FEATURE_SUID=y
>   # CONFIG_FEATURE_SUID_CONFIG is not set
>   # CONFIG_FEATURE_SUID_CONFIG_QUIET is not set
>
Tilman Keskinöz - March 28, 2013, 2:59 p.m.
Hi Arnout,

* Arnout Vandecappelle [Thu, 28 Mar 2013 08:12:38 +0100]:
>> -# CONFIG_FEATURE_PIDFILE is not set
>> +CONFIG_FEATURE_PIDFILE=y
> 
>  Since we care very much about the size of busybox, could you evaluate
> what the size difference is before and after this change?  One smallish
> architecture (e.g. ARM) is enough.
> 
>  Could you also make this change to the other busybox versions as well?
> The different busybox configs should only differ because of features
> added/removed in that particular version.

On ARM the difference is 64 Bytes. (gcc 4.6.x)

If you don't want to enable this feature, another option would be to use
start-stop-daemon -p in the syslog init script.

What do you think?
Arnout Vandecappelle - March 28, 2013, 3:27 p.m.
On 28/03/13 15:59, Tilman Keskinöz wrote:
> Hi Arnout,
>
> * Arnout Vandecappelle [Thu, 28 Mar 2013 08:12:38 +0100]:
>>> -# CONFIG_FEATURE_PIDFILE is not set
>>> +CONFIG_FEATURE_PIDFILE=y
>>
>>   Since we care very much about the size of busybox, could you evaluate
>> what the size difference is before and after this change?  One smallish
>> architecture (e.g. ARM) is enough.
>>
>>   Could you also make this change to the other busybox versions as well?
>> The different busybox configs should only differ because of features
>> added/removed in that particular version.
>
> On ARM the difference is 64 Bytes. (gcc 4.6.x)

  Great, then it is a good idea to enable it by default. Can you do it 
for all busybox versions?

  Question to the list: do we really need to keep several busybox 
versions? For U-Boot or kernel it may make some kind of sense, because 
you have custom patches on top of a specific version. But for busybox?


> If you don't want to enable this feature, another option would be to use
> start-stop-daemon -p in the syslog init script.

  It is already using the -p option, no?

  Regards,
  Arnout
Tilman Keskinöz - March 28, 2013, 3:41 p.m.
* Arnout Vandecappelle [Thu, 28 Mar 2013 16:27:06 +0100]:
>> If you don't want to enable this feature, another option would be to use
>> start-stop-daemon -p in the syslog init script.
> 
>  It is already using the -p option, no?

Sorry, i meant -m, e.g. let start-stop-daemon handle the pidfile creation.

Patch

diff --git a/package/busybox/busybox-1.20.x.config b/package/busybox/busybox-1.20.x.config
index 5525434..d199996 100644
--- a/package/busybox/busybox-1.20.x.config
+++ b/package/busybox/busybox-1.20.x.config
@@ -41,7 +41,7 @@  CONFIG_FEATURE_DEVPTS=y
 CONFIG_FEATURE_CLEAN_UP=y
 CONFIG_FEATURE_UTMP=y
 CONFIG_FEATURE_WTMP=y
-# CONFIG_FEATURE_PIDFILE is not set
+CONFIG_FEATURE_PIDFILE=y
 CONFIG_FEATURE_SUID=y
 # CONFIG_FEATURE_SUID_CONFIG is not set
 # CONFIG_FEATURE_SUID_CONFIG_QUIET is not set