Patchwork [12/17] ARM: mach-imx: tzic: Staticize *tzic_base

login
register
mail settings
Submitter Fabio Estevam
Date March 25, 2013, 12:20 p.m.
Message ID <1364214044-13950-12-git-send-email-fabio.estevam@freescale.com>
Download mbox | patch
Permalink /patch/230701/
State New
Headers show

Comments

Fabio Estevam - March 25, 2013, 12:20 p.m.
Fix the following sparse warning:

arch/arm/mach-imx/tzic.c:52:14: warning: symbol 'tzic_base' was not declared. Should it be static?

Also, reduce the comment in order to fit into 80 characters.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 arch/arm/mach-imx/tzic.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Sascha Hauer - March 25, 2013, 1:45 p.m.
On Mon, Mar 25, 2013 at 09:20:39AM -0300, Fabio Estevam wrote:
> Fix the following sparse warning:
> 
> arch/arm/mach-imx/tzic.c:52:14: warning: symbol 'tzic_base' was not declared. Should it be static?
> 
> Also, reduce the comment in order to fit into 80 characters.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  arch/arm/mach-imx/tzic.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-imx/tzic.c b/arch/arm/mach-imx/tzic.c
> index 9721161..1488a4a 100644
> --- a/arch/arm/mach-imx/tzic.c
> +++ b/arch/arm/mach-imx/tzic.c
> @@ -49,7 +49,7 @@
>  #define TZIC_SWINT	0x0F00	/* Software Interrupt Rigger Register */
>  #define TZIC_ID0	0x0FD0	/* Indentification Register 0 */
>  
> -void __iomem *tzic_base; /* Used as irq controller base in entry-macro.S */
> +static void __iomem *tzic_base; /* irq controller base in entry-macro.S */

The comment is wrong since Linux v3.2, you should remove it.

Sascha

Patch

diff --git a/arch/arm/mach-imx/tzic.c b/arch/arm/mach-imx/tzic.c
index 9721161..1488a4a 100644
--- a/arch/arm/mach-imx/tzic.c
+++ b/arch/arm/mach-imx/tzic.c
@@ -49,7 +49,7 @@ 
 #define TZIC_SWINT	0x0F00	/* Software Interrupt Rigger Register */
 #define TZIC_ID0	0x0FD0	/* Indentification Register 0 */
 
-void __iomem *tzic_base; /* Used as irq controller base in entry-macro.S */
+static void __iomem *tzic_base; /* irq controller base in entry-macro.S */
 static struct irq_domain *domain;
 
 #define TZIC_NUM_IRQS 128