Patchwork [Bug,6128] Fix S01logging pidfile handling

login
register
mail settings
Submitter Tilman Keskinöz
Date March 25, 2013, 11:09 a.m.
Message ID <5150304C.1080708@arved.at>
Download mbox | patch
Permalink /patch/230630/
State Superseded
Headers show

Comments

Tilman Keskinöz - March 25, 2013, 11:09 a.m.
* bugzilla [Wed, 20 Mar 2013 14:29:36 +0000 (UTC)]:
> https://bugs.busybox.net/show_bug.cgi?id=6128
> 
> --- Comment #2 from Thomas Petazzoni <thomas.petazzoni@free-electrons.com> 2013-03-20 14:30:20 UTC ---
> Thanks. Can you send this as two proper separate patches on the Buildroot
> mailing list?
>

--- busybox-1.20.x.config.orig	2013-03-20 14:42:31.297615642 +0100
+++ busybox-1.20.x.config	2013-03-20 14:42:51.045615146 +0100
@@ -41,7 +41,7 @@
 CONFIG_FEATURE_CLEAN_UP=y
 CONFIG_FEATURE_UTMP=y
 CONFIG_FEATURE_WTMP=y
-# CONFIG_FEATURE_PIDFILE is not set
+CONFIG_FEATURE_PIDFILE=y
 CONFIG_FEATURE_SUID=y
 # CONFIG_FEATURE_SUID_CONFIG is not set
 # CONFIG_FEATURE_SUID_CONFIG_QUIET is not set
Thomas Petazzoni - March 25, 2013, 12:25 p.m.
Dear Tilman Keskinöz,

On Mon, 25 Mar 2013 12:09:00 +0100, Tilman Keskinöz wrote:
> * bugzilla [Wed, 20 Mar 2013 14:29:36 +0000 (UTC)]:
> > https://bugs.busybox.net/show_bug.cgi?id=6128
> > 
> > --- Comment #2 from Thomas Petazzoni
> > <thomas.petazzoni@free-electrons.com> 2013-03-20 14:30:20 UTC ---
> > Thanks. Can you send this as two proper separate patches on the
> > Buildroot mailing list?

Thanks, but unfortunately, those patches can't be applied as is. They
should be Git patches, with a commit log that explains why the patch
is needed and what it is doing, a Signed-off-by line, and sent inline
(and not as attachements) using git send-email.

Could you do this?

Thanks a lot for your contribution!

Thomas

Patch

--- S01logging.orig	2013-03-20 14:42:18.313615967 +0100
+++ S01logging	2013-03-20 14:42:35.373615539 +0100
@@ -6,13 +6,13 @@ 
 case "$1" in
   start)
 	echo -n "Starting logging: "
-	start-stop-daemon -S -q -p /var/run/syslog.pid --exec /sbin/syslogd -- -m 0
+	start-stop-daemon -S -q -p /var/run/syslogd.pid --exec /sbin/syslogd -- -m 0
 	start-stop-daemon -S -q -p /var/run/klogd.pid --exec /sbin/klogd
 	echo "OK"
 	;;
   stop)
 	echo -n "Stopping logging: "
-	start-stop-daemon -K -q -p /var/run/syslog.pid
+	start-stop-daemon -K -q -p /var/run/syslogd.pid
 	start-stop-daemon -K -q -p /var/run/klogd.pid
 	echo "OK"
 	;;