Patchwork [6/6] drivers/rtc/rtc-max8907.c: Remove redundant code

login
register
mail settings
Submitter Sachin Kamat
Date March 25, 2013, 10:45 a.m.
Message ID <1364208327-14207-7-git-send-email-sachin.kamat@linaro.org>
Download mbox | patch
Permalink /patch/230621/
State New
Headers show

Comments

Sachin Kamat - March 25, 2013, 10:45 a.m.
Remove unnecessary goto statements to simplify the code.
devm_request_threaded_irq returns 0 upon success, hence
explicit return 0 is not necessary.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 drivers/rtc/rtc-max8907.c |   13 +++----------
 1 files changed, 3 insertions(+), 10 deletions(-)

Patch

diff --git a/drivers/rtc/rtc-max8907.c b/drivers/rtc/rtc-max8907.c
index 9d62cdb..86afb79 100644
--- a/drivers/rtc/rtc-max8907.c
+++ b/drivers/rtc/rtc-max8907.c
@@ -200,23 +200,16 @@  static int max8907_rtc_probe(struct platform_device *pdev)
 
 	rtc->irq = regmap_irq_get_virq(max8907->irqc_rtc,
 				       MAX8907_IRQ_RTC_ALARM0);
-	if (rtc->irq < 0) {
-		ret = rtc->irq;
-		goto err_unregister;
-	}
+	if (rtc->irq < 0)
+		return rtc->irq;
 
 	ret = devm_request_threaded_irq(&pdev->dev, rtc->irq, NULL,
 				max8907_irq_handler,
 				IRQF_ONESHOT, "max8907-alarm0", rtc);
-	if (ret < 0) {
+	if (ret < 0)
 		dev_err(&pdev->dev, "Failed to request IRQ%d: %d\n",
 			rtc->irq, ret);
-		goto err_unregister;
-	}
-
-	return 0;
 
-err_unregister:
 	return ret;
 }