From patchwork Mon Mar 25 10:45:25 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 230619 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-pd0-f186.google.com (mail-pd0-f186.google.com [209.85.192.186]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id E07652C0099 for ; Mon, 25 Mar 2013 21:57:00 +1100 (EST) Received: by mail-pd0-f186.google.com with SMTP id w10sf1327763pde.13 for ; Mon, 25 Mar 2013 03:56:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:mime-version:x-beenthere:x-received:received-spf :x-received:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references:x-original-sender:x-original-authentication-results :reply-to:precedence:mailing-list:list-id:x-google-group-id :list-post:list-help:list-archive:sender:list-subscribe :list-unsubscribe:content-type; bh=3qAws7ufZL6/lee2LJsmW/r4NEbOYqaXnr+WUESCXqQ=; b=Ww73mB47/JPyw8vZw6XGd1+pj9whPOaS86to9EwN8vB82gwWR2VqgAsFse4S7N8vDA pPLyRmfhuO3G661oKJEeIbP5juN7/ha73TKwUlR3PNajkLPFAjq/lyeGszFw/2CODWFu qewl9CdH1n36lvQ6uqVXMvkb5grF23WA9s+lgoy8xw+s0G1IAkMxTx2N6A58zzWht3ni 30xVQA7SGieNE05EXoAcfFEQ+MBV7bU0UVaYRzg6VfnrgntBkTOwnSP2P43jw3baGRRu nTWJRdxcIKwsVnmQJUKFhIsxKDrNRlvY5GJqLGkVquZiehuFY67fo7C2KKIGTEcvqGe0 5tEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:mime-version:x-beenthere:x-received:received-spf :x-received:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references:x-gm-message-state:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:x-google-group-id:list-post:list-help:list-archive:sender :list-subscribe:list-unsubscribe:content-type; bh=3qAws7ufZL6/lee2LJsmW/r4NEbOYqaXnr+WUESCXqQ=; b=IMRJE4C8NUOgPtNTeHV3hfMXLpsHreYyF01H0031otTs75azC5VKWYTH0hEfQKVdrg pY+BCtQv+D+al6NI+QWPcFsuihSkFfTvRBqX1gEbsVUC4RFu27A+whSEsIbUY0C8xf8V YTpZ4KkndgTv+wPDUEwY4Zhgh979TuwZt+kMUP+h5e8JdjDrtknVYcIZ91+mh8mW3S07 ps1jDkD1fYgqBP446YPzMoqEsC1pjEhe7sSAX6Qxm0cL9Afixyw8f+LgmhiebpVdWkgD M3nXGPfnxjnqHCM05PQdiaxLi33NLrCLMW+E1l3dWdrVDgcqeXVB/06MdsKJO/f8KADZ pO1A== X-Received: by 10.50.170.68 with SMTP id ak4mr2274657igc.1.1364209018698; Mon, 25 Mar 2013 03:56:58 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.47.228 with SMTP id g4ls3720071ign.6.gmail; Mon, 25 Mar 2013 03:56:58 -0700 (PDT) X-Received: by 10.67.14.100 with SMTP id ff4mr1737132pad.44.1364209018427; Mon, 25 Mar 2013 03:56:58 -0700 (PDT) Received: from mail-pa0-f50.google.com (mail-pa0-f50.google.com [209.85.220.50]) by gmr-mx.google.com with ESMTPS id gl10si2146640pac.2.2013.03.25.03.56.58 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 25 Mar 2013 03:56:58 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.220.50 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) client-ip=209.85.220.50; Received: by mail-pa0-f50.google.com with SMTP id bg2so966346pad.9 for ; Mon, 25 Mar 2013 03:56:58 -0700 (PDT) X-Received: by 10.68.239.194 with SMTP id vu2mr16519525pbc.147.1364209018349; Mon, 25 Mar 2013 03:56:58 -0700 (PDT) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id y1sm13067861pbg.10.2013.03.25.03.56.55 (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 25 Mar 2013 03:56:57 -0700 (PDT) From: Sachin Kamat To: rtc-linux@googlegroups.com Cc: a.zummo@towertech.it, akpm@linux-foundation.org, sachin.kamat@linaro.org, patches@linaro.org, Jonghwa Lee Subject: [rtc-linux] [PATCH 4/6] drivers/rtc/rtc-max8997.c: Fix incorrect return value on error Date: Mon, 25 Mar 2013 16:15:25 +0530 Message-Id: <1364208327-14207-5-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1364208327-14207-1-git-send-email-sachin.kamat@linaro.org> References: <1364208327-14207-1-git-send-email-sachin.kamat@linaro.org> X-Gm-Message-State: ALoCoQkMDpgm2UkcgPnP+4eSXMz8sCCiaYr1JQdO0UsxS20lyHvMXpFRBakoVC5cTWPaN/uHVoPl X-Original-Sender: sachin.kamat@linaro.org X-Original-Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 209.85.220.50 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) smtp.mail=sachin.kamat@linaro.org Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , 'ret' was being returned without initializing it to error code. While at it also remove duplicate return statement. Signed-off-by: Sachin Kamat Cc: Jonghwa Lee --- drivers/rtc/rtc-max8997.c | 7 ++----- 1 files changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/rtc/rtc-max8997.c b/drivers/rtc/rtc-max8997.c index d12acc4..5693619 100644 --- a/drivers/rtc/rtc-max8997.c +++ b/drivers/rtc/rtc-max8997.c @@ -491,6 +491,7 @@ static int max8997_rtc_probe(struct platform_device *pdev) virq = irq_create_mapping(max8997->irq_domain, MAX8997_PMICIRQ_RTCA1); if (!virq) { dev_err(&pdev->dev, "Failed to create mapping alarm IRQ\n"); + ret = -ENXIO; goto err_out; } info->virq = virq; @@ -498,13 +499,9 @@ static int max8997_rtc_probe(struct platform_device *pdev) ret = devm_request_threaded_irq(&pdev->dev, virq, NULL, max8997_rtc_alarm_irq, 0, "rtc-alarm0", info); - if (ret < 0) { + if (ret < 0) dev_err(&pdev->dev, "Failed to request alarm IRQ: %d: %d\n", info->virq, ret); - goto err_out; - } - - return ret; err_out: return ret;