From patchwork Sun Mar 24 15:45:52 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Michael S. Tsirkin" X-Patchwork-Id: 230464 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 10DDE2C00C3 for ; Mon, 25 Mar 2013 02:45:48 +1100 (EST) Received: from localhost ([::1]:46579 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UJn7B-0001Mf-W1 for incoming@patchwork.ozlabs.org; Sun, 24 Mar 2013 11:45:45 -0400 Received: from eggs.gnu.org ([208.118.235.92]:35270) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UJn6s-0001MH-LL for qemu-devel@nongnu.org; Sun, 24 Mar 2013 11:45:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UJn6p-0004JD-Tc for qemu-devel@nongnu.org; Sun, 24 Mar 2013 11:45:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60536) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UJn6p-0004IC-KU for qemu-devel@nongnu.org; Sun, 24 Mar 2013 11:45:23 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2OFjBMa016771 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 24 Mar 2013 11:45:12 -0400 Received: from redhat.com (vpn-200-70.tlv.redhat.com [10.35.200.70]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with SMTP id r2OFj6R2003049; Sun, 24 Mar 2013 11:45:07 -0400 Date: Sun, 24 Mar 2013 17:45:52 +0200 From: "Michael S. Tsirkin" To: Jason Gunthorpe Message-ID: <20130324154552.GA16346@redhat.com> MIME-Version: 1.0 Content-Disposition: inline X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: Roland Dreier , qemu-devel@nongnu.org, "linux-rdma@vger.kernel.org" , Yishai Hadas , LKML , "Michael R. Hines" , Hal Rosenstock , Sean Hefty , Christoph Lameter Subject: [Qemu-devel] [PATCHv2] ibverbs: add a new IBV_ACCESS_GIFT option X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org At the moment registering an MR breaks COW. If the application does not care that adapter sees stale data (for example, it tracks writes reregisters and resends), it can use a new IBV_ACCESS_GIFT flag to prevent registration from breaking COW. The semantics are similar to that of SPLICE_F_GIFT thus the name. Signed-off-by: Michael S. Tsirkin --- This is compiled but untested. Michael, could you please try this patch (together with the kernel patch I'm sending separately) and report whether setting this flag unbreaks overcommit for you? include/infiniband/verbs.h | 3 ++- man/ibv_reg_mr.3 | 5 +++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/include/infiniband/verbs.h b/include/infiniband/verbs.h index 6acfc81..3290ec9 100644 --- a/include/infiniband/verbs.h +++ b/include/infiniband/verbs.h @@ -290,7 +290,8 @@ enum ibv_access_flags { IBV_ACCESS_REMOTE_WRITE = (1<<1), IBV_ACCESS_REMOTE_READ = (1<<2), IBV_ACCESS_REMOTE_ATOMIC = (1<<3), - IBV_ACCESS_MW_BIND = (1<<4) + IBV_ACCESS_MW_BIND = (1<<4), + IBV_ACCESS_GIFT = (1<<6) }; struct ibv_pd { diff --git a/man/ibv_reg_mr.3 b/man/ibv_reg_mr.3 index 7723771..3c302f0 100644 --- a/man/ibv_reg_mr.3 +++ b/man/ibv_reg_mr.3 @@ -34,6 +34,8 @@ describes the desired memory protection attributes; it is either 0 or the bitwis .B IBV_ACCESS_REMOTE_ATOMIC\fR Enable Remote Atomic Operation Access (if supported) .TP .B IBV_ACCESS_MW_BIND\fR Enable Memory Window Binding +.TP +.B IBV_ACCESS_GIFT\fR This memory is a gift to the adapter: if memory is modified after registration, the local version and data seen by the adapter through this region rkey may differ .PP If .B IBV_ACCESS_REMOTE_WRITE @@ -43,6 +45,9 @@ is set, then .B IBV_ACCESS_LOCAL_WRITE must be set too. .PP +.B IBV_ACCESS_GIFT +is only legal with remote or local read access. +.PP Local read access is always enabled for the MR. .PP .B ibv_dereg_mr()