Patchwork netfilter: xt_osf: fix inversion

login
register
mail settings
Submitter Pablo Neira
Date March 24, 2013, 10:34 a.m.
Message ID <1364121253-7081-1-git-send-email-pablo@netfilter.org>
Download mbox | patch
Permalink /patch/230425/
State Deferred
Headers show

Comments

Pablo Neira - March 24, 2013, 10:34 a.m.
From: Pablo Neira Ayuso <pablo@netfilter.org>

-m osf --genre Windows
-m osf ! --genre Windows

are both matching.

Reported-by: Reported-by: Bourne Without <blackhole@airpost.net>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
 net/netfilter/xt_osf.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Patch

diff --git a/net/netfilter/xt_osf.c b/net/netfilter/xt_osf.c
index a5e673d..110c848 100644
--- a/net/netfilter/xt_osf.c
+++ b/net/netfilter/xt_osf.c
@@ -201,6 +201,7 @@  xt_osf_match_packet(const struct sk_buff *skb, struct xt_action_param *p)
 	unsigned char opts[MAX_IPOPTLEN];
 	const struct xt_osf_finger *kf;
 	const struct xt_osf_user_finger *f;
+	bool invert = info->flags & XT_OSF_INVERT;
 
 	if (!info)
 		return false;
@@ -349,7 +350,7 @@  xt_osf_match_packet(const struct sk_buff *skb, struct xt_action_param *p)
 	if (fcount)
 		fmatch = FMATCH_OK;
 
-	return fmatch == FMATCH_OK;
+	return (fmatch == FMATCH_OK) ^ invert;
 }
 
 static struct xt_match xt_osf_match = {