Patchwork [13/22] ncurses: enable shared library build on the host

login
register
mail settings
Submitter Thomas Petazzoni
Date March 24, 2013, 8:26 a.m.
Message ID <1364113606-20836-14-git-send-email-thomas.petazzoni@free-electrons.com>
Download mbox | patch
Permalink /patch/230390/
State Accepted
Commit af23d762e51be20f812b9d958268843ae4e369cb
Headers show

Comments

Thomas Petazzoni - March 24, 2013, 8:26 a.m.
On the host, we generally build and install a shared library rather
than a static version of libraries. In this specific case, we will
want to build host-gettext, which builds a shared library that depends
on ncurses. And this doesn't work well if ncurses is static because it
hasn't been built with -fPIC. Therefore, let's build ncurses as shared
on the host.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 package/ncurses/ncurses.mk |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Peter Korsgaard - March 24, 2013, 12:48 p.m.
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 Thomas> On the host, we generally build and install a shared library
 Thomas> rather than a static version of libraries. In this specific
 Thomas> case, we will want to build host-gettext, which builds a shared
 Thomas> library that depends on ncurses. And this doesn't work well if
 Thomas> ncurses is static because it hasn't been built with
 Thomas> -fPIC. Therefore, let's build ncurses as shared on the host.

Committed, thanks.

Patch

diff --git a/package/ncurses/ncurses.mk b/package/ncurses/ncurses.mk
index c01dfbc..eb47c36 100644
--- a/package/ncurses/ncurses.mk
+++ b/package/ncurses/ncurses.mk
@@ -116,7 +116,7 @@  define HOST_NCURSES_BUILD_CMDS
 endef
 
 HOST_NCURSES_CONF_OPT = \
-	--without-shared --without-gpm \
+	--with-shared --without-gpm \
 	--without-manpages \
 	--without-cxx \
 	--without-cxx-binding \