Patchwork target-moxie: Fix pointer-to-integer conversion (MinGW-w64)

login
register
mail settings
Submitter Stefan Weil
Date March 24, 2013, 8:04 a.m.
Message ID <1364112288-6479-1-git-send-email-sw@weilnetz.de>
Download mbox | patch
Permalink /patch/230380/
State Accepted
Headers show

Comments

Stefan Weil - March 24, 2013, 8:04 a.m.
The type cast must use tcg_target_long instead of long.
This makes a difference for hosts where sizeof(long) != sizeof(void *).

Cc: Anthony Green <green@moxielogic.com>
Cc: Blue Swirl <blauwirbel@gmail.com>
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
 target-moxie/translate.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Anthony Green - March 28, 2013, 7 p.m.
Hi Stefan,

This change is fine by me.

It's not clear to me, as the author/maintainer of the moxie port, what
my responsibility/authority is.  Do I simply reply to patches like
this with...

Looks good to me.
Signed-off-by: Anthony Green <green@moxielogic.com>

And then somebody commits it to the tree?

Thanks!

AG


On Sun, Mar 24, 2013 at 4:04 AM, Stefan Weil <sw@weilnetz.de> wrote:
> The type cast must use tcg_target_long instead of long.
> This makes a difference for hosts where sizeof(long) != sizeof(void *).
>
> Cc: Anthony Green <green@moxielogic.com>
> Cc: Blue Swirl <blauwirbel@gmail.com>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>  target-moxie/translate.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target-moxie/translate.c b/target-moxie/translate.c
> index 34f166e..cc02bd3 100644
> --- a/target-moxie/translate.c
> +++ b/target-moxie/translate.c
> @@ -133,7 +133,7 @@ static inline void gen_goto_tb(CPUMoxieState *env, DisasContext *ctx,
>          !ctx->singlestep_enabled) {
>          tcg_gen_goto_tb(n);
>          tcg_gen_movi_i32(cpu_pc, dest);
> -        tcg_gen_exit_tb((long) tb + n);
> +        tcg_gen_exit_tb((tcg_target_long)tb + n);
>      } else {
>          tcg_gen_movi_i32(cpu_pc, dest);
>          if (ctx->singlestep_enabled) {
> --
> 1.7.10.4
>
Stefan Weil - March 29, 2013, 7:47 a.m.
Am 28.03.2013 20:00, schrieb Anthony Green:
> Hi Stefan,
>
> This change is fine by me.
>
> It's not clear to me, as the author/maintainer of the moxie port, what
> my responsibility/authority is.  Do I simply reply to patches like
> this with...
>
> Looks good to me.
> Signed-off-by: Anthony Green <green@moxielogic.com>
>
> And then somebody commits it to the tree?
>
> Thanks!
>
> AG

Hi Anthony,

this was a build fix, so hopefully Blue Swirl or Anthony Liguori
will commit it immediately when they see your Signed-off-by.
Feedback from the maintainer is always welcome.

My patch is also a trivial modification which could be handled
by the maintainers of qemu-trivial, but they won't because
I did not cc qemu-trivial@nongnu.org.

For "normal" patches (and also in this case if the patch
remains uncommitted for some time), the maintainer
applies each patch to his/her personal tree, tells the author
and the mailing list that this was done,and sends a pull request
to the list (either after some time or when several patches
were collected in the personal tree).

Regards,
Stefan
Blue Swirl - March 30, 2013, 2 p.m.
On Thu, Mar 28, 2013 at 7:00 PM, Anthony Green <green@moxielogic.com> wrote:
> Hi Stefan,
>
> This change is fine by me.
>
> It's not clear to me, as the author/maintainer of the moxie port, what
> my responsibility/authority is.  Do I simply reply to patches like
> this with...
>
> Looks good to me.
> Signed-off-by: Anthony Green <green@moxielogic.com>

I think Acked-by: or Reviewed-by: tags are fine too.

>
> And then somebody commits it to the tree?

Yes, like I'm going to do now. You could also queue the patches to
your tree (for example, if they collide with your work in progress) by
using git am and then send the patches as part of your patch set or
pull request. In that case, the From: field indicating the original
submitter should be kept intact, but git am should do that for you.

In some cases, like trivial patches, fixing a build breakage or
general refactoring which only needs minor changes to several targets,
the committers do not wait too long for OK from target maintainers.
Positive reviews with tags of course increase confidence to the patch
and a Nack is always possible.

>
> Thanks!
>
> AG
>
>
> On Sun, Mar 24, 2013 at 4:04 AM, Stefan Weil <sw@weilnetz.de> wrote:
>> The type cast must use tcg_target_long instead of long.
>> This makes a difference for hosts where sizeof(long) != sizeof(void *).
>>
>> Cc: Anthony Green <green@moxielogic.com>
>> Cc: Blue Swirl <blauwirbel@gmail.com>
>> Signed-off-by: Stefan Weil <sw@weilnetz.de>
>> ---
>>  target-moxie/translate.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/target-moxie/translate.c b/target-moxie/translate.c
>> index 34f166e..cc02bd3 100644
>> --- a/target-moxie/translate.c
>> +++ b/target-moxie/translate.c
>> @@ -133,7 +133,7 @@ static inline void gen_goto_tb(CPUMoxieState *env, DisasContext *ctx,
>>          !ctx->singlestep_enabled) {
>>          tcg_gen_goto_tb(n);
>>          tcg_gen_movi_i32(cpu_pc, dest);
>> -        tcg_gen_exit_tb((long) tb + n);
>> +        tcg_gen_exit_tb((tcg_target_long)tb + n);
>>      } else {
>>          tcg_gen_movi_i32(cpu_pc, dest);
>>          if (ctx->singlestep_enabled) {
>> --
>> 1.7.10.4
>>
Blue Swirl - March 30, 2013, 6:53 p.m.
Thanks, applied.

On Sun, Mar 24, 2013 at 8:04 AM, Stefan Weil <sw@weilnetz.de> wrote:
> The type cast must use tcg_target_long instead of long.
> This makes a difference for hosts where sizeof(long) != sizeof(void *).
>
> Cc: Anthony Green <green@moxielogic.com>
> Cc: Blue Swirl <blauwirbel@gmail.com>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>  target-moxie/translate.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target-moxie/translate.c b/target-moxie/translate.c
> index 34f166e..cc02bd3 100644
> --- a/target-moxie/translate.c
> +++ b/target-moxie/translate.c
> @@ -133,7 +133,7 @@ static inline void gen_goto_tb(CPUMoxieState *env, DisasContext *ctx,
>          !ctx->singlestep_enabled) {
>          tcg_gen_goto_tb(n);
>          tcg_gen_movi_i32(cpu_pc, dest);
> -        tcg_gen_exit_tb((long) tb + n);
> +        tcg_gen_exit_tb((tcg_target_long)tb + n);
>      } else {
>          tcg_gen_movi_i32(cpu_pc, dest);
>          if (ctx->singlestep_enabled) {
> --
> 1.7.10.4
>

Patch

diff --git a/target-moxie/translate.c b/target-moxie/translate.c
index 34f166e..cc02bd3 100644
--- a/target-moxie/translate.c
+++ b/target-moxie/translate.c
@@ -133,7 +133,7 @@  static inline void gen_goto_tb(CPUMoxieState *env, DisasContext *ctx,
         !ctx->singlestep_enabled) {
         tcg_gen_goto_tb(n);
         tcg_gen_movi_i32(cpu_pc, dest);
-        tcg_gen_exit_tb((long) tb + n);
+        tcg_gen_exit_tb((tcg_target_long)tb + n);
     } else {
         tcg_gen_movi_i32(cpu_pc, dest);
         if (ctx->singlestep_enabled) {