Patchwork [01/14] Revert "block: complete all IOs before .bdrv_truncate"

login
register
mail settings
Submitter Kevin Wolf
Date March 22, 2013, 5:41 p.m.
Message ID <1363974083-28440-2-git-send-email-kwolf@redhat.com>
Download mbox | patch
Permalink /patch/230220/
State New
Headers show

Comments

Kevin Wolf - March 22, 2013, 5:41 p.m.
From: Peter Lieven <pl@dlhnet.de>

brdv_truncate() is also called from readv/writev commands on self-
growing file based storage. this will result in requests waiting
for theirselves to complete.

This reverts commit 9a665b2b8640e464f0a778216fc2dca8d02acf33.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 block.c | 4 ----
 1 file changed, 4 deletions(-)

Patch

diff --git a/block.c b/block.c
index 0a062c9..22647b2 100644
--- a/block.c
+++ b/block.c
@@ -2487,10 +2487,6 @@  int bdrv_truncate(BlockDriverState *bs, int64_t offset)
         return -EACCES;
     if (bdrv_in_use(bs))
         return -EBUSY;
-
-    /* There better not be any in-flight IOs when we truncate the device. */
-    bdrv_drain_all();
-
     ret = drv->bdrv_truncate(bs, offset);
     if (ret == 0) {
         ret = refresh_total_sectors(bs, offset >> BDRV_SECTOR_BITS);